| Message ID | 20230524124628.32295-1-henning.schild@siemens.com |
|---|---|
| Headers | show |
| Series | leds: simatic-ipc-leds-gpio: split up | expand |
On Wed, May 24, 2023 at 02:46:24PM +0200, Henning Schild wrote: > changes since v3: > - add terminator entries to all gpio lookup tables as new p1 > > changes since v2: > - some more style changes from review > > changes since v1: > - move from header- to -core.c-based implementation > - style changes from review > > This series mainly splits the one GPIO driver into two. The split allows > to clearly model runtime and compile time dependencies on the GPIO chip > drivers. > > p2 is kind of not too related to that split but also prepares for more > GPIO based drivers to come. > > p3 takes the driver we had and puts some of its content into a -core, > to be used by the two drivers. > > p4 deals with more fine-grained configuration posibilities and compile > time dependencies. For non-commented patches Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Henning Schild (4): > leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables > leds: simatic-ipc-leds-gpio: move two extra gpio pins into another > table > leds: simatic-ipc-leds-gpio: split up into multiple drivers > leds: simatic-ipc-leds-gpio: introduce more Kconfig switches > > drivers/leds/simple/Kconfig | 31 +++- > drivers/leds/simple/Makefile | 5 +- > .../simple/simatic-ipc-leds-gpio-apollolake.c | 66 +++++++++ > .../leds/simple/simatic-ipc-leds-gpio-core.c | 104 +++++++++++++ > .../simple/simatic-ipc-leds-gpio-f7188x.c | 66 +++++++++ > drivers/leds/simple/simatic-ipc-leds-gpio.c | 139 ------------------ > drivers/leds/simple/simatic-ipc-leds-gpio.h | 22 +++ > drivers/leds/simple/simatic-ipc-leds.c | 1 - > drivers/platform/x86/simatic-ipc.c | 7 +- > 9 files changed, 293 insertions(+), 148 deletions(-) > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c > delete mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.h > > -- > 2.39.3 >
changes since v3: - add terminator entries to all gpio lookup tables as new p1 changes since v2: - some more style changes from review changes since v1: - move from header- to -core.c-based implementation - style changes from review This series mainly splits the one GPIO driver into two. The split allows to clearly model runtime and compile time dependencies on the GPIO chip drivers. p2 is kind of not too related to that split but also prepares for more GPIO based drivers to come. p3 takes the driver we had and puts some of its content into a -core, to be used by the two drivers. p4 deals with more fine-grained configuration posibilities and compile time dependencies. Henning Schild (4): leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table leds: simatic-ipc-leds-gpio: split up into multiple drivers leds: simatic-ipc-leds-gpio: introduce more Kconfig switches drivers/leds/simple/Kconfig | 31 +++- drivers/leds/simple/Makefile | 5 +- .../simple/simatic-ipc-leds-gpio-apollolake.c | 66 +++++++++ .../leds/simple/simatic-ipc-leds-gpio-core.c | 104 +++++++++++++ .../simple/simatic-ipc-leds-gpio-f7188x.c | 66 +++++++++ drivers/leds/simple/simatic-ipc-leds-gpio.c | 139 ------------------ drivers/leds/simple/simatic-ipc-leds-gpio.h | 22 +++ drivers/leds/simple/simatic-ipc-leds.c | 1 - drivers/platform/x86/simatic-ipc.c | 7 +- 9 files changed, 293 insertions(+), 148 deletions(-) create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c delete mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.h