mbox series

[0/3] Add support for high resolution PWMs

Message ID 20230316192134.26436-1-quic_amelende@quicinc.com
Headers show
Series Add support for high resolution PWMs | expand

Message

Anjelique Melendez March 16, 2023, 7:21 p.m. UTC 
Certain PMICs have a high reolution PWM module which can support from 8-bit
to 15-bit PWM. This change series adds support for those PMICs. Thanks!

Anjelique Melendez (3):
  dt-bindings: leds-qcom-lpg: Add qcom,pmk8550-pwm compatible string
  leds: rgb: leds-qcom-lpg: Add support for high resolution PWM
  leds: rgb: leds-qcom-lpg: Add support for PMK8550 PWM

 .../bindings/leds/leds-qcom-lpg.yaml          |   1 +
 drivers/leds/rgb/leds-qcom-lpg.c              | 151 +++++++++++++-----
 2 files changed, 110 insertions(+), 42 deletions(-)

Comments

Krzysztof Kozlowski March 17, 2023, 4:04 p.m. UTC | #1 
On 16/03/2023 20:21, Anjelique Melendez wrote:
> Add qcom,pmk8550-pwm compatible string for the Qualcomm Technologies, Inc.
> PMK8550 PMIC which has two high resolution PWM channels.
> 

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Your driver code has build warnings, so anyway new version is expected...

Best regards,
Krzysztof
Lee Jones March 30, 2023, 1:01 p.m. UTC | #2 
On Thu, 16 Mar 2023, Anjelique Melendez wrote:

> Certain PMICs have a high reolution PWM module which can support from 8-bit
> to 15-bit PWM. This change series adds support for those PMICs. Thanks!
>
> Anjelique Melendez (3):
>   dt-bindings: leds-qcom-lpg: Add qcom,pmk8550-pwm compatible string
>   leds: rgb: leds-qcom-lpg: Add support for high resolution PWM
>   leds: rgb: leds-qcom-lpg: Add support for PMK8550 PWM
>
>  .../bindings/leds/leds-qcom-lpg.yaml          |   1 +
>  drivers/leds/rgb/leds-qcom-lpg.c              | 151 +++++++++++++-----
>  2 files changed, 110 insertions(+), 42 deletions(-)

I guess you'll be fixing the build issues and resubmitting?

Please retrain the Acks you've collected.

--
Lee Jones [李琼斯]