mbox series

[v2,0/2] leds: ledtrig-tty: add tty_led_mode xtension

Message ID 20230217094403.1574468-1-fe@dev.tdt.de
Headers show
Series leds: ledtrig-tty: add tty_led_mode xtension | expand

Message

Florian Eckert Feb. 17, 2023, 9:44 a.m. UTC 
Hello,

here commes v2 of this series to add additional tty_led_modes.
Changes compared to the initial patchset with
20230213140638.620206-1-fe@dev.tdt.de are.

Addressed review comments by Jiri Slaby are:

tty.h:
- Fix compilation error because of wrong rebaseing
- Remove empty lines
- Use new 'tty_get_mget' in 'tty_tiocmget'

ledtrg-tty.c:
- Update commit description
- Use enum for tty_led_mod in struct ledtrig_tty_date
- Rename sysfs file from 'mode' to 'tty_led_mode'
- Change tty_led_mode show function to use loop instead of switch/case
- Change tty_led_mode store function to use loop instead of switch/case
- Check return value of function tty_get_mget

Florian Eckert (2):
  tty: new helper function tty_get_mget
  trigger: ledtrig-tty: add additional modes

 .../ABI/testing/sysfs-class-led-trigger-tty   |  16 ++
 drivers/leds/trigger/ledtrig-tty.c            | 146 ++++++++++++++++--
 drivers/tty/tty_io.c                          |  30 +++-
 include/linux/tty.h                           |   1 +
 4 files changed, 171 insertions(+), 22 deletions(-)