| Message ID | 20220825104422.14156-1-henning.schild@siemens.com |
|---|---|
| Headers | show |
| Series | add support for another simatic board | expand |
On Thu, Aug 25, 2022 at 4:25 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 8/25/22 12:44, Henning Schild wrote: > > changes since v5: > > - adding patch to convert to pr_fmt > > - adding patch to prefix macros with "f7188x_" > > - rebased p1v4 to be p3v5 and added tag > > > > changes since v4: > > - remove int case from a printk in p1 > > - include tags into commit messages > > > > changes since v3: > > - update Kconfig as well > > - drop chip names from comment in driver header > > - add manufacturer check for Fintek again, Nuvoton not possible > > - drop revision printing for Nuvoton > > - restructure defines again > > - add new model 427G > > > > changes since v2: (p1 only) > > - rename macros that change behavior > > - use chip type not device id in the macros > > - reorder defines a bit > > > > changes since v1: > > - remove unused define > > - fix bug where (base + 2) was used as second data bit > > - add macros for "inverted" and "single data bit" > > > > The first two patches apply some style refactorings before actual > > functional changes are made. > > > > Later, This series enables a SuperIO GPIO driver to support a chip from > > the vendor Nuvoton, the driver is for Fintek devices but those just are > > very similar. And in watchdog and hwmon subsystems these SuperIO drivers > > also share code and are sometimes called a family. > > > > In another step the individual banks receive a label to tell them apart, > > a step which potentially changes an interface to legacy users that might > > rely on all banks having the same label, or an exact label. But since a > > later patch wants to use GPIO_LOOKUP unique labels are needed and i > > decided to assign them for all supported chips. > > > > In a following patch the Simatic GPIO LED driver is extended to provide > > LEDs in case that SuperIO GPIO driver can be loaded. > > > > Last but not least the watchdog module of that same SuperIO gets loaded > > on a best effort basis. > > > > The very last patch enables a second model of that same board type. > > > > Henning Schild (7): > > gpio-f7188x: switch over to using pr_fmt > > gpio-f7188x: add a prefix to macros to keep gpio namespace clean > > gpio-f7188x: Add GPIO support for Nuvoton NCT6116 > > gpio-f7188x: use unique labels for banks/chips > > leds: simatic-ipc-leds-gpio: add new model 227G > > platform/x86: simatic-ipc: enable watchdog for 227G > > platform/x86: simatic-ipc: add new model 427G > > So it looks like all these patches are ready for merging now, > the only thing which is missing is an Ack from Pavel or > one of the other LED people for patch 5/7. > > Pavel can have your ack for merging this through another tree > please? > > So what is the plan for merging this? > > I see 2 options: > > Option a: > 1. Merge the GPIO changes (patches 1-4) through the GPIO tree; and > 2. Merge the leds + pdx86 changes through the pdx86 tree > > Option b: > Merge everything through the pdx86 tree, and I will then provide > an immutable branch + signed tag for other subsystems to pull > (if they want to). > Hey! Sorry for the delay, I've just come back from vacation. I'm fine with option b and to that end: Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
Hi All, On 8/25/22 12:44, Henning Schild wrote: > changes since v5: > - adding patch to convert to pr_fmt > - adding patch to prefix macros with "f7188x_" > - rebased p1v4 to be p3v5 and added tag > > changes since v4: > - remove int case from a printk in p1 > - include tags into commit messages > > changes since v3: > - update Kconfig as well > - drop chip names from comment in driver header > - add manufacturer check for Fintek again, Nuvoton not possible > - drop revision printing for Nuvoton > - restructure defines again > - add new model 427G > > changes since v2: (p1 only) > - rename macros that change behavior > - use chip type not device id in the macros > - reorder defines a bit > > changes since v1: > - remove unused define > - fix bug where (base + 2) was used as second data bit > - add macros for "inverted" and "single data bit" > > The first two patches apply some style refactorings before actual > functional changes are made. > > Later, This series enables a SuperIO GPIO driver to support a chip from > the vendor Nuvoton, the driver is for Fintek devices but those just are > very similar. And in watchdog and hwmon subsystems these SuperIO drivers > also share code and are sometimes called a family. > > In another step the individual banks receive a label to tell them apart, > a step which potentially changes an interface to legacy users that might > rely on all banks having the same label, or an exact label. But since a > later patch wants to use GPIO_LOOKUP unique labels are needed and i > decided to assign them for all supported chips. > > In a following patch the Simatic GPIO LED driver is extended to provide > LEDs in case that SuperIO GPIO driver can be loaded. > > Last but not least the watchdog module of that same SuperIO gets loaded > on a best effort basis. > > The very last patch enables a second model of that same board type. > > Henning Schild (7): > gpio-f7188x: switch over to using pr_fmt > gpio-f7188x: add a prefix to macros to keep gpio namespace clean > gpio-f7188x: Add GPIO support for Nuvoton NCT6116 > gpio-f7188x: use unique labels for banks/chips > leds: simatic-ipc-leds-gpio: add new model 227G > platform/x86: simatic-ipc: enable watchdog for 227G > platform/x86: simatic-ipc: add new model 427G Despite the "leds: simatic-ipc-leds-gpio: add new model 227G" missing an ack from the LED subsys maintainers I have decided to move forward with this. The LED changes in that patch are quite small / trivial, it actually touches both drivers/leds and drivers/platform/x86 and the latter changes are bigger and it also has been Reviewed by both me and Andy. So I'm going for the it is easier to ask for forgiveness then ... route here wrt the missing LEDs subsys ack. I've just pushed a new platform-drivers-x86-simatec branch which contains 6.0-rc1 + these 7 patches. Next I'm to send out a pull-req (based on a signed tag) to the involved subsys maintainers and merge that signed tag into my review-hans branch (and from there it will go to pdx86/for-next). Regards, Hans > > drivers/gpio/Kconfig | 3 +- > drivers/gpio/gpio-f7188x.c | 275 +++++++++++------- > drivers/leds/simple/simatic-ipc-leds-gpio.c | 42 ++- > drivers/platform/x86/simatic-ipc.c | 10 +- > .../platform_data/x86/simatic-ipc-base.h | 1 + > include/linux/platform_data/x86/simatic-ipc.h | 2 + > 6 files changed, 216 insertions(+), 117 deletions(-) >
On Thu, Sep 1, 2022 at 4:53 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Dear GPIO and LED subsystem maintainers, > > Here is a pull-request for v6.0-rc1 + the > "[PATCH v6 0/7] add support for another simatic board" series > for merging into the gpio and leds subsystems. > > Regards, > > Hans > > > The following changes since commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868: > > Linux 6.0-rc1 (2022-08-14 15:50:18 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git tags/platform-drivers-x86-simatec-1 > > for you to fetch changes up to 8f5c9858c5db129359b5de2f60f5f034bf5d56c0: > > platform/x86: simatic-ipc: add new model 427G (2022-09-01 16:15:03 +0200) > > ---------------------------------------------------------------- > Tag (immutable branch) for: > v6.0-rc1 + "[PATCH v6 0/7] add support for another simatic board" series > for merging into the gpio, leds and pdx86 subsystems. > > ---------------------------------------------------------------- > Henning Schild (7): > gpio-f7188x: switch over to using pr_fmt > gpio-f7188x: add a prefix to macros to keep gpio namespace clean > gpio-f7188x: Add GPIO support for Nuvoton NCT6116 > gpio-f7188x: use unique labels for banks/chips > leds: simatic-ipc-leds-gpio: add new model 227G > platform/x86: simatic-ipc: enable watchdog for 227G > platform/x86: simatic-ipc: add new model 427G > > drivers/gpio/Kconfig | 3 +- > drivers/gpio/gpio-f7188x.c | 275 ++++++++++++--------- > drivers/leds/simple/simatic-ipc-leds-gpio.c | 42 +++- > drivers/platform/x86/simatic-ipc.c | 10 +- > include/linux/platform_data/x86/simatic-ipc-base.h | 1 + > include/linux/platform_data/x86/simatic-ipc.h | 2 + > 6 files changed, 216 insertions(+), 117 deletions(-) > Pulled, thanks! Bart