Message ID | 20220815080230.37408-1-u.kleine-koenig@pengutronix.de |
---|---|
Headers | show |
Series | i2c: Make remove callback return void | expand |
On Mon, Aug 15, 2022 at 10:02:26AM +0200, Uwe Kleine-König wrote: > Returning an error value from an i2c remove callback results in an error > message being emitted by the i2c core, but otherwise it doesn't make a > difference. The device goes away anyhow and the devm cleanups are > called. > > As lm3697_remove() already emits an error message on failure and the > additional error message by the i2c core doesn't add any useful > information, don't pass the error value up the stack. Instead continue > to clean up and return 0. > > This patch is a preparation for making i2c remove callbacks return void. > > Acked-by: Pavel Machek <pavel@ucw.cz> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Applied to an immutable branch, thanks!
> As some conflicts are expected I sent this early after -rc1 such that it > can be included early into next and be put on an immutable branch for > subsystems to resolve merge conflicts. I pushed the series out now, so it should hit -next tomorrow. The immutable branch is here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/make_remove_callback_void-immutable Enjoy!