From patchwork Sat Jul 9 09:46:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Knecht X-Patchwork-Id: 589085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172D1C433EF for ; Sat, 9 Jul 2022 09:47:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229491AbiGIJr1 (ORCPT ); Sat, 9 Jul 2022 05:47:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbiGIJr0 (ORCPT ); Sat, 9 Jul 2022 05:47:26 -0400 Received: from msg-4.mailo.com (ip-15.mailobj.net [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2682166B9A; Sat, 9 Jul 2022 02:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1657360019; bh=PZMiRCw/3zOUWfsTqtEzWFw9v3Kdr/HClpegfsoasT8=; h=X-EA-Auth:From:To:Cc:Subject:Date:Message-Id:X-Mailer: MIME-Version:Content-Transfer-Encoding; b=H6kPXhS5umLYUmnvzE7s4oh6TYgLNcXqzWySi9SVqPo+sc/EFBfdJDvJy/oKi6Z9s yQbODAJmdywq6e/kQXYgqQvd9v9rySgvpfSKlAoXE+xZ0pzve3N96K8uAo64p+0S6O iGxNc56F+mFcptSgfvIRQZYZPG4Tr2Il855o1968= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.207] Sat, 9 Jul 2022 11:46:58 +0200 (CEST) X-EA-Auth: Tq1NwqQf3cKl0ayS9KOZB72Yo48GGq+JVy58jxPysDU38vUqGO++HUGexVYA7WQ3BqUBuAOFhnoOce1EKu46eCBXiu68vm3PCwbN5jhI9kg= From: Vincent Knecht To: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Vincent Knecht , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, hns@goldelico.com Subject: [PATCH v4 0/7] leds: Fix/Add is31fl319{0,1,3} support Date: Sat, 9 Jul 2022 11:46:33 +0200 Message-Id: <20220709094642.4078222-1-vincent.knecht@mailoo.org> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org v4: - took Andy's comments into account - add patch 7 for cleanup and formatting fixes v3: - pick up Rob's R-b for patches 1 and 2 - reinstate bindings docs license and maintainer changes with Nikolaus agreement - took Andy's comments on patch 4 into account v2: - keep original bindings license and maintainer/owner (Rob) - squash bindings patches 2 & 4 (Krzysztof) v1-resend: - no change, resending after configuring git to accomodate for smtp provider limit of 5 emails per batch - just change cover-letter to mention si-en chip for idol347 The is31fl3190, is31fl3191 and is31fl3193 chips (1 or 3 PWM channels) cannot be handled the same as is31fl3196 and is31fl3199, if only because the register map is different. Also: - the software shutdown bit is reversed - and additional field needs to be set to enable all channels - the led-max-microamp current values and setting are not the same Datasheets: https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf https://lumissil.com/assets/pdf/core/IS31FL3191_DS.pdf https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf https://lumissil.com/assets/pdf/core/IS31FL3196_DS.pdf https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf This series: - converts dt-bindings to dtschema, adding all si-en compatibles for convenience and consistency, and adding constraints on supported values for eg. reg address and led-max-microamp - changes vars, structs and defines to not use 319X suffix but 3190 for 319{0,1,3} and 3196 for 319{6,9} - adds fields in chipdef struct for chip-specific values - only in patch 6, adds is31fl319{0,1,3} specific values so those chips can work. - patch 7 cleanups parts non touched in previous patches Tested on msm8916-alcatel-idol347, which probably has an si-en,sn3190 or si-en,sn3191 (only one white led indicator). Vincent Knecht (7): dt-bindings: leds: Convert is31fl319x to dtschema dt-bindings: leds: is31fl319x: Document variants specificities leds: is31fl319x: Add missing si-en compatibles leds: is31fl319x: Use non-wildcard names for vars, structs and defines leds: is31fl319x: Move chipset-specific values in chipdef struct leds: is31fl319x: Add support for is31fl319{0,1,3} chips leds: is31fl319x: Cleanup formatting and dev_dbg calls .../bindings/leds/issi,is31fl319x.yaml | 193 ++++++++ .../bindings/leds/leds-is31fl319x.txt | 61 --- drivers/leds/leds-is31fl319x.c | 425 +++++++++++++----- 3 files changed, 495 insertions(+), 184 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl319x.txt