mbox series

[v15,0/2] leds: mt6360: Add LED driver for MT6360

Message ID 20210716081731.80118-1-gene.chen.richtek@gmail.com
Headers show
Series leds: mt6360: Add LED driver for MT6360 | expand

Message

Gene Chen July 16, 2021, 8:17 a.m. UTC
This patch series add MT6360 LED support contains driver and binding document

Gene Chen (2)
 dt-bindings: leds: Add bindings for MT6360 LED
 leds: mt6360: Add LED driver for MT6360

 Documentation/devicetree/bindings/leds/leds-mt6360.yaml |  159 ++
 drivers/leds/flash/Kconfig                              |   13 
 drivers/leds/flash/Makefile                             |    1 
 drivers/leds/flash/leds-mt6360.c                        |  910 ++++++++++++++++
 4 files changed, 1083 insertions(+)

changelogs between v1 & v2
 - add led driver with mfd

changelogs between v2 & v3
 - independent add led driver
 - add dt-binding document
 - refactor macros definition for easy to debug
 - parse device tree by fwnode
 - use devm*ext to register led class device

changelogs between v3 & v4
 - fix binding document description
 - use GENMASK and add unit postfix to definition
 - isink register led class device

changelogs between v4 & v5
 - change rgb isink to multicolor control
 - add binding reference to mfd yaml

changelogs between v5 & v6
 - Use DT to decide RGB LED is multicolor device or indicator device only

changelogs between v6 & v7
 - Add binding multicolor device sample code
 - Add flash ops mutex lock
 - Remove V4L2 init with indicator device

changelogs between v7 & v8
 - Add mutex for led fault get ops
 - Fix flash and multicolor no-ops return 0
 - Add LED_FUNCTION_MOONLIGHT

changelogs between v8 & v9
 - reuse api in flash and multicolor header

changelogs between v9 & v10
 - add comment for reuse registration functions in flash and multicolor

changelogs between v10 & v11
 - match dt-binding reg property comment to the functionality name
 - remove exist patch in linux-next
 - dicide multicolor channel by color definitiion

changelogs between v11 & v12
 - Fix print size_t by %zu
 - Fix dt-binding name regular experssion

changelogs between v12 & v13
 - Fix kbuild test rebot build error

changelogs between v13 & v14
 - Move driver to flash folder
 - Remove LED FUNCTION MOONLIGHT
 - Keep 80 char per line

changelogs between v14 & v15
 - Add ack in commit message

Comments

Gene Chen Oct. 5, 2021, 9:21 a.m. UTC | #1
Gene Chen <gene.chen.richtek@gmail.com> 於 2021年7月16日 週五 下午4:33寫道:
>

>

> This patch series add MT6360 LED support contains driver and binding document

>

> Gene Chen (2)

>  dt-bindings: leds: Add bindings for MT6360 LED

>  leds: mt6360: Add LED driver for MT6360

>

>  Documentation/devicetree/bindings/leds/leds-mt6360.yaml |  159 ++

>  drivers/leds/flash/Kconfig                              |   13

>  drivers/leds/flash/Makefile                             |    1

>  drivers/leds/flash/leds-mt6360.c                        |  910 ++++++++++++++++

>  4 files changed, 1083 insertions(+)

>

> changelogs between v1 & v2

>  - add led driver with mfd

>

> changelogs between v2 & v3

>  - independent add led driver

>  - add dt-binding document

>  - refactor macros definition for easy to debug

>  - parse device tree by fwnode

>  - use devm*ext to register led class device

>

> changelogs between v3 & v4

>  - fix binding document description

>  - use GENMASK and add unit postfix to definition

>  - isink register led class device

>

> changelogs between v4 & v5

>  - change rgb isink to multicolor control

>  - add binding reference to mfd yaml

>

> changelogs between v5 & v6

>  - Use DT to decide RGB LED is multicolor device or indicator device only

>

> changelogs between v6 & v7

>  - Add binding multicolor device sample code

>  - Add flash ops mutex lock

>  - Remove V4L2 init with indicator device

>

> changelogs between v7 & v8

>  - Add mutex for led fault get ops

>  - Fix flash and multicolor no-ops return 0

>  - Add LED_FUNCTION_MOONLIGHT

>

> changelogs between v8 & v9

>  - reuse api in flash and multicolor header

>

> changelogs between v9 & v10

>  - add comment for reuse registration functions in flash and multicolor

>

> changelogs between v10 & v11

>  - match dt-binding reg property comment to the functionality name

>  - remove exist patch in linux-next

>  - dicide multicolor channel by color definitiion

>

> changelogs between v11 & v12

>  - Fix print size_t by %zu

>  - Fix dt-binding name regular experssion

>

> changelogs between v12 & v13

>  - Fix kbuild test rebot build error

>

> changelogs between v13 & v14

>  - Move driver to flash folder

>  - Remove LED FUNCTION MOONLIGHT

>  - Keep 80 char per line

>

> changelogs between v14 & v15

>  - Add ack in commit message

>


Dear Reviewers,

Please let me know if any concern.

Thanks.
Jacek Anaszewski Oct. 5, 2021, 7:33 p.m. UTC | #2
Pavel,

On 10/5/21 11:21 AM, Gene Chen wrote:
> Gene Chen <gene.chen.richtek@gmail.com> 於 2021年7月16日 週五 下午4:33寫道:

>>

>>

>> This patch series add MT6360 LED support contains driver and binding document

>>

>> Gene Chen (2)

>>   dt-bindings: leds: Add bindings for MT6360 LED

>>   leds: mt6360: Add LED driver for MT6360

>>

>>   Documentation/devicetree/bindings/leds/leds-mt6360.yaml |  159 ++

>>   drivers/leds/flash/Kconfig                              |   13

>>   drivers/leds/flash/Makefile                             |    1

>>   drivers/leds/flash/leds-mt6360.c                        |  910 ++++++++++++++++

>>   4 files changed, 1083 insertions(+)


Do you see Gene's emails or maybe they land somehow in your spam folder?
It's been four months since last version addressing your remarks.

-- 
Best regards,
Jacek Anaszewski