mbox series

[v2,0/2] leds: bcm63x8: improve read and write functions

Message ID 20210224101110.20179-1-noltari@gmail.com
Headers show
Series leds: bcm63x8: improve read and write functions | expand

Message

Álvaro Fernández Rojas Feb. 24, 2021, 10:11 a.m. UTC 
This code is proven to work in BMIPS BE/LE and ARM BE/LE.
See bcm2835-rng and bcmgenet.c:
https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/char/hw_random/bcm2835-rng.c#L42-L60
https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88

v2: fix comments style.

Álvaro Fernández Rojas (2):
  leds: bcm6328: improve write and read functions
  leds: bcm6358: improve write and read functions

 drivers/leds/leds-bcm6328.c | 26 ++++++++++++++------------
 drivers/leds/leds-bcm6358.c | 26 ++++++++++++++------------
 2 files changed, 28 insertions(+), 24 deletions(-)

Comments

Álvaro Fernández Rojas Feb. 24, 2021, 3:54 p.m. UTC | #1 
Hi Florian,

> El 24 feb 2021, a las 16:45, Florian Fainelli <f.fainelli@gmail.com> escribió:
> 
> 
> 
> On 2/24/2021 2:11 AM, Álvaro Fernández Rojas wrote:
>> This code is proven to work in BMIPS BE/LE and ARM BE/LE.
>> See bcm2835-rng and bcmgenet.c:
>> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/char/hw_random/bcm2835-rng.c#L42-L60
>> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88
> 
> What is the motivation for doing this? bcm2835-rng and bcmgenet are used
> across MIPS and ARM platforms therefore they need to be compatible with
> both, but these two LEDs drivers are super specialized, are you working
> on porting the 6328 LED driver to the newer ARM-based DSL SoCs such as
> 63138 and 63148?

I just wanted to have all bmips drivers in line (at least regarding read/write).
If I remember correctly someone told me that this controller was also present on some little endian SoCs, but you can confirm that :).
Unfortunately I haven’t got any devices with ARM-based DSL SoCs, so the answer is no.

> -- 
> Florian

Best regards,
Álvaro.
Florian Fainelli Feb. 24, 2021, 5:43 p.m. UTC | #2 
On 2/24/2021 7:54 AM, Álvaro Fernández Rojas wrote:
> Hi Florian,
> 
>> El 24 feb 2021, a las 16:45, Florian Fainelli <f.fainelli@gmail.com> escribió:
>>
>>
>>
>> On 2/24/2021 2:11 AM, Álvaro Fernández Rojas wrote:
>>> This code is proven to work in BMIPS BE/LE and ARM BE/LE.
>>> See bcm2835-rng and bcmgenet.c:
>>> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/char/hw_random/bcm2835-rng.c#L42-L60
>>> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88
>>
>> What is the motivation for doing this? bcm2835-rng and bcmgenet are used
>> across MIPS and ARM platforms therefore they need to be compatible with
>> both, but these two LEDs drivers are super specialized, are you working
>> on porting the 6328 LED driver to the newer ARM-based DSL SoCs such as
>> 63138 and 63148?
> 
> I just wanted to have all bmips drivers in line (at least regarding read/write).
> If I remember correctly someone told me that this controller was also present on some little endian SoCs, but you can confirm that :).
> Unfortunately I haven’t got any devices with ARM-based DSL SoCs, so the answer is no.

The 6328 LED controller could be utilized on the ARM-based DSL SoCs,
however 6358 will not, so changing the I/O accessors for that driver
sounds like just code churn to me.