| Message ID | 20190430191730.19450-1-dmurphy@ti.com |
|---|---|
| Headers | show |
| Series | LMU Common code intro | expand |
On 4/30/19 12:17 PM, Dan Murphy wrote: > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index da00b9ed5a5c..3ae24eaf4cde 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -776,6 +776,14 @@ config LEDS_NIC78BX > To compile this driver as a module, choose M here: the module > will be called leds-nic78bx. > > +config LEDS_TI_LMU_COMMON > + tristate "LED driver for TI LMU" what does LMU mean? > + depends on REGMAP > + help > + Say Y to enable the LED driver for TI LMU devices. > + This supports common features between the TI LM3532, LM3631, LM3632, > + LM3633, LM3695 and LM3697. Fix help indentation above to use tab + 2 spaces consistently. > comment "LED Triggers" > source "drivers/leds/trigger/Kconfig" thanks. -- ~Randy
Randy On 4/30/19 2:23 PM, Randy Dunlap wrote: > On 4/30/19 12:17 PM, Dan Murphy wrote: >> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig >> index da00b9ed5a5c..3ae24eaf4cde 100644 >> --- a/drivers/leds/Kconfig >> +++ b/drivers/leds/Kconfig >> @@ -776,6 +776,14 @@ config LEDS_NIC78BX >> To compile this driver as a module, choose M here: the module >> will be called leds-nic78bx. >> >> +config LEDS_TI_LMU_COMMON >> + tristate "LED driver for TI LMU" > > what does LMU mean? Lighting management unit it is defined in the DT documentation > >> + depends on REGMAP >> + help >> + Say Y to enable the LED driver for TI LMU devices. >> + This supports common features between the TI LM3532, LM3631, LM3632, >> + LM3633, LM3695 and LM3697. > > Fix help indentation above to use tab + 2 spaces consistently. > UGH I wish I had this comment 2 weeks ago. But I can fix it Dan >> comment "LED Triggers" >> source "drivers/leds/trigger/Kconfig" > > > thanks. >
On 4/30/19 9:30 PM, Dan Murphy wrote: > Randy > > On 4/30/19 2:23 PM, Randy Dunlap wrote: >> On 4/30/19 12:17 PM, Dan Murphy wrote: >>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig >>> index da00b9ed5a5c..3ae24eaf4cde 100644 >>> --- a/drivers/leds/Kconfig >>> +++ b/drivers/leds/Kconfig >>> @@ -776,6 +776,14 @@ config LEDS_NIC78BX >>> To compile this driver as a module, choose M here: the module >>> will be called leds-nic78bx. >>> >>> +config LEDS_TI_LMU_COMMON >>> + tristate "LED driver for TI LMU" >> >> what does LMU mean? > > Lighting management unit it is defined in the DT documentation > >> >>> + depends on REGMAP >>> + help >>> + Say Y to enable the LED driver for TI LMU devices. >>> + This supports common features between the TI LM3532, LM3631, LM3632, >>> + LM3633, LM3695 and LM3697. >> >> Fix help indentation above to use tab + 2 spaces consistently. >> > > UGH I wish I had this comment 2 weeks ago. > But I can fix it I will amend this while merging, no need to resend. -- Best regards, Jacek Anaszewski
Jacek On 4/30/19 2:32 PM, Jacek Anaszewski wrote: > On 4/30/19 9:30 PM, Dan Murphy wrote: >> Randy >> >> On 4/30/19 2:23 PM, Randy Dunlap wrote: >>> On 4/30/19 12:17 PM, Dan Murphy wrote: >>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig >>>> index da00b9ed5a5c..3ae24eaf4cde 100644 >>>> --- a/drivers/leds/Kconfig >>>> +++ b/drivers/leds/Kconfig >>>> @@ -776,6 +776,14 @@ config LEDS_NIC78BX >>>> To compile this driver as a module, choose M here: the module >>>> will be called leds-nic78bx. >>>> +config LEDS_TI_LMU_COMMON >>>> + tristate "LED driver for TI LMU" >>> >>> what does LMU mean? >> >> Lighting management unit it is defined in the DT documentation >> >>> >>>> + depends on REGMAP >>>> + help >>>> + Say Y to enable the LED driver for TI LMU devices. >>>> + This supports common features between the TI LM3532, LM3631, LM3632, >>>> + LM3633, LM3695 and LM3697. >>> >>> Fix help indentation above to use tab + 2 spaces consistently. >>> >> >> UGH I wish I had this comment 2 weeks ago. >> But I can fix it > > I will amend this while merging, no need to resend. > Thank you. I will wait to rebase/repost the LM36274 patchset until after the this series is merged. Honestly the only change to the LM36274 patchset is adding Rob's RB to the dt patches and rebasing the Kconfig. Dan
On Tue 2019-04-30 14:17:25, Dan Murphy wrote: > Document the ramp-up and ramp-down property in the binding. > Removing the "sec" from the property definition as seconds is > implied. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchwork/patch/1058759/ > > v2 - Fixed commit message as this was not just a modification but adding documentation > https://lore.kernel.org/patchwork/patch/1054504/ > > .../devicetree/bindings/mfd/ti-lmu.txt | 20 ++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/ti-lmu.txt b/Documentation/devicetree/bindings/mfd/ti-lmu.txt > index 86ca786d54fc..adae96c79d39 100644 > --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt > +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt > @@ -25,6 +25,12 @@ Required properties: > > Optional property: "properties". > - enable-gpios: A GPIO specifier for hardware enable pin. > + - ramp-up-ms: Current ramping from one brightness level to > + the a higher brightness level. > + Range from 2048 us - 117.44 s > + - ramp-down-ms: Current ramping from one brightness level to > + the a lower brightness level. > + Range from 2048 us - 117.44 s Can you use ramp-up/down-us for consistency? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Tue 2019-04-30 14:17:28, Dan Murphy wrote: > The LM3697 is a single function LED driver. The single function LED > driver needs to reside in the LED directory as a dedicated LED driver > and not as a MFD device. The device does have common brightness and ramp > features and those can be accomodated by a TI LMU framework. > > The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated > LED dt binding needs to be added. The new LM3697 LED dt binding will then > reside in the Documentation/devicetree/bindings/leds directory and follow the > current LED and general bindings guidelines. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchwork/patch/1058762/ > > v2 - Made changes to reference ti,brightness-resolution to the ti-lmu.txt - > https://lore.kernel.org/patchwork/patch/1054501/ > > .../devicetree/bindings/leds/leds-lm3697.txt | 73 +++++++++++++++++++ > .../devicetree/bindings/mfd/ti-lmu.txt | 27 +------ > 2 files changed, 74 insertions(+), 26 deletions(-) > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt > new file mode 100644 > index 000000000000..02378f33c9ab > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt > @@ -0,0 +1,73 @@ > +* Texas Instruments - LM3697 Highly Efficient White LED Driver > + > +The LM3697 11-bit LED driver provides high- > +performance backlight dimming for 1, 2, or 3 series > +LED strings while delivering up to 90% efficiency. > + > +This device is suitable for display and keypad Lighting "lightning." Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi Lee, This patch set has dependency on the previous one for lm3532, which also touches ti-lmu.txt bindings, and for which I already created immutable branch. Now if I created another immutable branch for this patch set we would have to resolve conflicts between the two, as they would both be based on 5.1-rc1. Adds much overhead and is error prone. Therefore I propose to apply this patch set on top of my merge of LED tree with the immutable branch for lm3532. Please let me know if you see it differently. I'll wait for your response until Friday, and then proceed with the above as I think it should be harmless for MFD. Best regards, Jacek Anaszewski On 4/30/19 9:17 PM, Dan Murphy wrote: > Hello > > I have added the Reviewed-by for dt bindings as well as made the Kconfig change > pointed out for the common code flag > > Dan > > Dan Murphy (7): > dt-bindings: mfd: LMU: Fix lm3632 dt binding example > dt-bindings: mfd: LMU: Add the ramp up/down property > dt-bindings: mfd: LMU: Add ti,brightness-resolution > leds: TI LMU: Add common code for TI LMU devices > dt-bindings: ti-lmu: Modify dt bindings for the LM3697 > mfd: ti-lmu: Remove support for LM3697 > leds: lm3697: Introduce the lm3697 driver > > .../devicetree/bindings/leds/leds-lm3697.txt | 73 ++++ > .../devicetree/bindings/mfd/ti-lmu.txt | 56 ++- > drivers/leds/Kconfig | 15 + > drivers/leds/Makefile | 2 + > drivers/leds/leds-lm3697.c | 395 ++++++++++++++++++ > drivers/leds/ti-lmu-led-common.c | 155 +++++++ > drivers/mfd/Kconfig | 2 +- > drivers/mfd/ti-lmu.c | 17 - > include/linux/mfd/ti-lmu-register.h | 44 -- > include/linux/mfd/ti-lmu.h | 1 - > include/linux/ti-lmu-led-common.h | 47 +++ > 11 files changed, 712 insertions(+), 95 deletions(-) > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt > create mode 100644 drivers/leds/leds-lm3697.c > create mode 100644 drivers/leds/ti-lmu-led-common.c > create mode 100644 include/linux/ti-lmu-led-common.h >
On 4/30/19 5:05 PM, Pavel Machek wrote: > On Tue 2019-04-30 14:17:28, Dan Murphy wrote: >> The LM3697 is a single function LED driver. The single function LED >> driver needs to reside in the LED directory as a dedicated LED driver >> and not as a MFD device. The device does have common brightness and ramp >> features and those can be accomodated by a TI LMU framework. >> >> The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated >> LED dt binding needs to be added. The new LM3697 LED dt binding will then >> reside in the Documentation/devicetree/bindings/leds directory and follow the >> current LED and general bindings guidelines. >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> >> v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchwork/patch/1058762/ >> >> v2 - Made changes to reference ti,brightness-resolution to the ti-lmu.txt - >> https://lore.kernel.org/patchwork/patch/1054501/ >> >> .../devicetree/bindings/leds/leds-lm3697.txt | 73 +++++++++++++++++++ >> .../devicetree/bindings/mfd/ti-lmu.txt | 27 +------ >> 2 files changed, 74 insertions(+), 26 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt >> new file mode 100644 >> index 000000000000..02378f33c9ab >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt >> @@ -0,0 +1,73 @@ >> +* Texas Instruments - LM3697 Highly Efficient White LED Driver >> + >> +The LM3697 11-bit LED driver provides high- >> +performance backlight dimming for 1, 2, or 3 series >> +LED strings while delivering up to 90% efficiency. >> + >> +This device is suitable for display and keypad Lighting > > "lightning." Heh. Don't think you meant lightning but I get what you are saying s/Lighting/lighting Dan > Pavel >
On Tue 2019-04-30 17:07:32, Dan Murphy wrote: > > > On 4/30/19 5:05 PM, Pavel Machek wrote: > > On Tue 2019-04-30 14:17:28, Dan Murphy wrote: > >> The LM3697 is a single function LED driver. The single function LED > >> driver needs to reside in the LED directory as a dedicated LED driver > >> and not as a MFD device. The device does have common brightness and ramp > >> features and those can be accomodated by a TI LMU framework. > >> > >> The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated > >> LED dt binding needs to be added. The new LM3697 LED dt binding will then > >> reside in the Documentation/devicetree/bindings/leds directory and follow the > >> current LED and general bindings guidelines. > >> > >> Reviewed-by: Rob Herring <robh@kernel.org> > >> Signed-off-by: Dan Murphy <dmurphy@ti.com> > >> --- > >> > >> v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchwork/patch/1058762/ > >> > >> v2 - Made changes to reference ti,brightness-resolution to the ti-lmu.txt - > >> https://lore.kernel.org/patchwork/patch/1054501/ > >> > >> .../devicetree/bindings/leds/leds-lm3697.txt | 73 +++++++++++++++++++ > >> .../devicetree/bindings/mfd/ti-lmu.txt | 27 +------ > >> 2 files changed, 74 insertions(+), 26 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt > >> > >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt > >> new file mode 100644 > >> index 000000000000..02378f33c9ab > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt > >> @@ -0,0 +1,73 @@ > >> +* Texas Instruments - LM3697 Highly Efficient White LED Driver > >> + > >> +The LM3697 11-bit LED driver provides high- > >> +performance backlight dimming for 1, 2, or 3 series > >> +LED strings while delivering up to 90% efficiency. > >> + > >> +This device is suitable for display and keypad Lighting > > > > "lightning." > > Heh. Don't think you meant lightning but I get what you are saying > > s/Lighting/lighting Yep. Sorry :-). Plus I'd add a dot (".") at the end of sentence. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Ekhm, I forgot to add the main recipient. Adding Lee. On 5/1/19 12:05 AM, Jacek Anaszewski wrote: > Hi Lee, > > This patch set has dependency on the previous one for lm3532, which > also touches ti-lmu.txt bindings, and for which I already created > immutable branch. Now if I created another immutable branch for > this patch set we would have to resolve conflicts between the two, > as they would both be based on 5.1-rc1. Adds much overhead and > is error prone. Therefore I propose to apply this patch set on > top of my merge of LED tree with the immutable branch for lm3532. > > Please let me know if you see it differently. I'll wait for your > response until Friday, and then proceed with the above as I think > it should be harmless for MFD. > > Best regards, > Jacek Anaszewski > > On 4/30/19 9:17 PM, Dan Murphy wrote: >> Hello >> >> I have added the Reviewed-by for dt bindings as well as made the >> Kconfig change >> pointed out for the common code flag >> >> Dan >> >> Dan Murphy (7): >> dt-bindings: mfd: LMU: Fix lm3632 dt binding example >> dt-bindings: mfd: LMU: Add the ramp up/down property >> dt-bindings: mfd: LMU: Add ti,brightness-resolution >> leds: TI LMU: Add common code for TI LMU devices >> dt-bindings: ti-lmu: Modify dt bindings for the LM3697 >> mfd: ti-lmu: Remove support for LM3697 >> leds: lm3697: Introduce the lm3697 driver >> >> .../devicetree/bindings/leds/leds-lm3697.txt | 73 ++++ >> .../devicetree/bindings/mfd/ti-lmu.txt | 56 ++- >> drivers/leds/Kconfig | 15 + >> drivers/leds/Makefile | 2 + >> drivers/leds/leds-lm3697.c | 395 ++++++++++++++++++ >> drivers/leds/ti-lmu-led-common.c | 155 +++++++ >> drivers/mfd/Kconfig | 2 +- >> drivers/mfd/ti-lmu.c | 17 - >> include/linux/mfd/ti-lmu-register.h | 44 -- >> include/linux/mfd/ti-lmu.h | 1 - >> include/linux/ti-lmu-led-common.h | 47 +++ >> 11 files changed, 712 insertions(+), 95 deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/leds/leds-lm3697.txt >> create mode 100644 drivers/leds/leds-lm3697.c >> create mode 100644 drivers/leds/ti-lmu-led-common.c >> create mode 100644 include/linux/ti-lmu-led-common.h >> > > -- Best regards, Jacek Anaszewski
Pavel On 4/30/19 5:01 PM, Pavel Machek wrote: > On Tue 2019-04-30 14:17:25, Dan Murphy wrote: >> Document the ramp-up and ramp-down property in the binding. >> Removing the "sec" from the property definition as seconds is >> implied. >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> >> v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchwork/patch/1058759/ >> >> v2 - Fixed commit message as this was not just a modification but adding documentation >> https://lore.kernel.org/patchwork/patch/1054504/ >> >> .../devicetree/bindings/mfd/ti-lmu.txt | 20 ++++++++++++------- >> 1 file changed, 13 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/ti-lmu.txt b/Documentation/devicetree/bindings/mfd/ti-lmu.txt >> index 86ca786d54fc..adae96c79d39 100644 >> --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt >> +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt >> @@ -25,6 +25,12 @@ Required properties: >> >> Optional property: > > "properties". > Ack >> - enable-gpios: A GPIO specifier for hardware enable pin. >> + - ramp-up-ms: Current ramping from one brightness level to >> + the a higher brightness level. >> + Range from 2048 us - 117.44 s >> + - ramp-down-ms: Current ramping from one brightness level to >> + the a lower brightness level. >> + Range from 2048 us - 117.44 s > > Can you use ramp-up/down-us for consistency? Sure I can change it to ramp-up/down-us. I just converted it ramp-up/down-msec to ramp-ramp-up/down-ms. Probably makes more sense anyway with the range actually given is in us. Dan > Pavel >
Finally the patch set missed merge window for 5.2 due to other requested improvements. Thanks, Jacek Anaszewski On 5/1/19 11:45 AM, Jacek Anaszewski wrote: > Ekhm, I forgot to add the main recipient. > > Adding Lee. > > On 5/1/19 12:05 AM, Jacek Anaszewski wrote: >> Hi Lee, >> >> This patch set has dependency on the previous one for lm3532, which >> also touches ti-lmu.txt bindings, and for which I already created >> immutable branch. Now if I created another immutable branch for >> this patch set we would have to resolve conflicts between the two, >> as they would both be based on 5.1-rc1. Adds much overhead and >> is error prone. Therefore I propose to apply this patch set on >> top of my merge of LED tree with the immutable branch for lm3532. >> >> Please let me know if you see it differently. I'll wait for your >> response until Friday, and then proceed with the above as I think >> it should be harmless for MFD. >> >> Best regards, >> Jacek Anaszewski >> >> On 4/30/19 9:17 PM, Dan Murphy wrote: >>> Hello >>> >>> I have added the Reviewed-by for dt bindings as well as made the >>> Kconfig change >>> pointed out for the common code flag >>> >>> Dan >>> >>> Dan Murphy (7): >>> dt-bindings: mfd: LMU: Fix lm3632 dt binding example >>> dt-bindings: mfd: LMU: Add the ramp up/down property >>> dt-bindings: mfd: LMU: Add ti,brightness-resolution >>> leds: TI LMU: Add common code for TI LMU devices >>> dt-bindings: ti-lmu: Modify dt bindings for the LM3697 >>> mfd: ti-lmu: Remove support for LM3697 >>> leds: lm3697: Introduce the lm3697 driver >>> >>> .../devicetree/bindings/leds/leds-lm3697.txt | 73 ++++ >>> .../devicetree/bindings/mfd/ti-lmu.txt | 56 ++- >>> drivers/leds/Kconfig | 15 + >>> drivers/leds/Makefile | 2 + >>> drivers/leds/leds-lm3697.c | 395 ++++++++++++++++++ >>> drivers/leds/ti-lmu-led-common.c | 155 +++++++ >>> drivers/mfd/Kconfig | 2 +- >>> drivers/mfd/ti-lmu.c | 17 - >>> include/linux/mfd/ti-lmu-register.h | 44 -- >>> include/linux/mfd/ti-lmu.h | 1 - >>> include/linux/ti-lmu-led-common.h | 47 +++ >>> 11 files changed, 712 insertions(+), 95 deletions(-) >>> create mode 100644 >>> Documentation/devicetree/bindings/leds/leds-lm3697.txt >>> create mode 100644 drivers/leds/leds-lm3697.c >>> create mode 100644 drivers/leds/ti-lmu-led-common.c >>> create mode 100644 include/linux/ti-lmu-led-common.h >>> >> >> >
I have posted v4 with requested corrections plus I have an additional patchset that is based off of this patch set for the LM36274. I can post that as well and we can present everything for 5.3 Maybe even the base MC FW ;) Dan On 5/7/19 1:49 PM, Jacek Anaszewski wrote: > Finally the patch set missed merge window for 5.2 due to > other requested improvements. > > Thanks, > Jacek Anaszewski > > On 5/1/19 11:45 AM, Jacek Anaszewski wrote: >> Ekhm, I forgot to add the main recipient. >> >> Adding Lee. >> >> On 5/1/19 12:05 AM, Jacek Anaszewski wrote: >>> Hi Lee, >>> >>> This patch set has dependency on the previous one for lm3532, which >>> also touches ti-lmu.txt bindings, and for which I already created >>> immutable branch. Now if I created another immutable branch for >>> this patch set we would have to resolve conflicts between the two, >>> as they would both be based on 5.1-rc1. Adds much overhead and >>> is error prone. Therefore I propose to apply this patch set on >>> top of my merge of LED tree with the immutable branch for lm3532. >>> >>> Please let me know if you see it differently. I'll wait for your >>> response until Friday, and then proceed with the above as I think >>> it should be harmless for MFD. >>> >>> Best regards, >>> Jacek Anaszewski >>> >>> On 4/30/19 9:17 PM, Dan Murphy wrote: >>>> Hello >>>> >>>> I have added the Reviewed-by for dt bindings as well as made the Kconfig change >>>> pointed out for the common code flag >>>> >>>> Dan >>>> >>>> Dan Murphy (7): >>>> dt-bindings: mfd: LMU: Fix lm3632 dt binding example >>>> dt-bindings: mfd: LMU: Add the ramp up/down property >>>> dt-bindings: mfd: LMU: Add ti,brightness-resolution >>>> leds: TI LMU: Add common code for TI LMU devices >>>> dt-bindings: ti-lmu: Modify dt bindings for the LM3697 >>>> mfd: ti-lmu: Remove support for LM3697 >>>> leds: lm3697: Introduce the lm3697 driver >>>> >>>> .../devicetree/bindings/leds/leds-lm3697.txt | 73 ++++ >>>> .../devicetree/bindings/mfd/ti-lmu.txt | 56 ++- >>>> drivers/leds/Kconfig | 15 + >>>> drivers/leds/Makefile | 2 + >>>> drivers/leds/leds-lm3697.c | 395 ++++++++++++++++++ >>>> drivers/leds/ti-lmu-led-common.c | 155 +++++++ >>>> drivers/mfd/Kconfig | 2 +- >>>> drivers/mfd/ti-lmu.c | 17 - >>>> include/linux/mfd/ti-lmu-register.h | 44 -- >>>> include/linux/mfd/ti-lmu.h | 1 - >>>> include/linux/ti-lmu-led-common.h | 47 +++ >>>> 11 files changed, 712 insertions(+), 95 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt >>>> create mode 100644 drivers/leds/leds-lm3697.c >>>> create mode 100644 drivers/leds/ti-lmu-led-common.c >>>> create mode 100644 include/linux/ti-lmu-led-common.h >>>> >>> >>> >>
On 5/7/19 9:06 PM, Dan Murphy wrote: > I have posted v4 with requested corrections plus I have an additional patchset that is based off of this patch set > for the LM36274. Yes, I've seen it but it was quite late. Let it receive fair testing. > I can post that as well and we can present everything for 5.3 > > Maybe even the base MC FW ;) Is it somehow related? -- Best regards, Jacek Anaszewski
Jacek On 5/7/19 2:13 PM, Jacek Anaszewski wrote: > On 5/7/19 9:06 PM, Dan Murphy wrote: >> I have posted v4 with requested corrections plus I have an additional patchset that is based off of this patch set >> for the LM36274. > > Yes, I've seen it but it was quite late. Let it receive > fair testing. > OK do you want me to combine both patchsets? Or leave them separated? >> I can post that as well and we can present everything for 5.3 >> >> Maybe even the base MC FW ;) > > Is it somehow related? > No Dan
On 5/7/19 9:29 PM, Dan Murphy wrote: > Jacek > > On 5/7/19 2:13 PM, Jacek Anaszewski wrote: >> On 5/7/19 9:06 PM, Dan Murphy wrote: >>> I have posted v4 with requested corrections plus I have an additional patchset that is based off of this patch set >>> for the LM36274. >> >> Yes, I've seen it but it was quite late. Let it receive >> fair testing. >> > > OK do you want me to combine both patchsets? Or leave them separated? If that one for LM36274 still applies cleanly there is no need to resend. > >>> I can post that as well and we can present everything for 5.3 >>> >>> Maybe even the base MC FW ;) >> >> Is it somehow related? >> > > No I presume there will be also another approach to MC FW (see [0]). It would be indeed nice to conclude it somehow for 5.3. [0] https://www.spinics.net/lists/linux-leds/msg12166.html -- Best regards, Jacek Anaszewski
Jacek On 5/7/19 2:47 PM, Jacek Anaszewski wrote: > On 5/7/19 9:29 PM, Dan Murphy wrote: >> Jacek >> >> On 5/7/19 2:13 PM, Jacek Anaszewski wrote: >>> On 5/7/19 9:06 PM, Dan Murphy wrote: >>>> I have posted v4 with requested corrections plus I have an additional patchset that is based off of this patch set >>>> for the LM36274. >>> >>> Yes, I've seen it but it was quite late. Let it receive >>> fair testing. >>> >> >> OK do you want me to combine both patchsets? Or leave them separated? > > If that one for LM36274 still applies cleanly there is no need > to resend. > It did not. There were conflicts with the file name change as well as the Kconfig rearrangement >> >>>> I can post that as well and we can present everything for 5.3 >>>> >>>> Maybe even the base MC FW ;) >>> >>> Is it somehow related? >>> >> >> No > > I presume there will be also another approach to MC FW (see [0]). > It would be indeed nice to conclude it somehow for 5.3. > > [0] https://www.spinics.net/lists/linux-leds/msg12166.html > I am not seeing that change the directory structure for grouping LED modules in one colors directory. I will move this conversation to that thread. Dan
Dan, On 5/7/19 9:49 PM, Dan Murphy wrote: > Jacek > > On 5/7/19 2:47 PM, Jacek Anaszewski wrote: >> On 5/7/19 9:29 PM, Dan Murphy wrote: >>> Jacek >>> >>> On 5/7/19 2:13 PM, Jacek Anaszewski wrote: >>>> On 5/7/19 9:06 PM, Dan Murphy wrote: >>>>> I have posted v4 with requested corrections plus I have an additional patchset that is based off of this patch set >>>>> for the LM36274. >>>> >>>> Yes, I've seen it but it was quite late. Let it receive >>>> fair testing. >>>> >>> >>> OK do you want me to combine both patchsets? Or leave them separated? >> >> If that one for LM36274 still applies cleanly there is no need >> to resend. >> > > It did not. There were conflicts with the file name change as well as the Kconfig rearrangement So please send only the update of this patch. No need to resend the "[PATCH v4 0/7] LMU Rework" patch set. -- Best regards, Jacek Anaszewski
On Wed, 01 May 2019, Jacek Anaszewski wrote: > Ekhm, I forgot to add the main recipient. > > Adding Lee. > > On 5/1/19 12:05 AM, Jacek Anaszewski wrote: > > Hi Lee, > > > > This patch set has dependency on the previous one for lm3532, which > > also touches ti-lmu.txt bindings, and for which I already created > > immutable branch. Now if I created another immutable branch for > > this patch set we would have to resolve conflicts between the two, > > as they would both be based on 5.1-rc1. Adds much overhead and > > is error prone. Therefore I propose to apply this patch set on > > top of my merge of LED tree with the immutable branch for lm3532. > > > > Please let me know if you see it differently. I'll wait for your > > response until Friday, and then proceed with the above as I think > > it should be harmless for MFD. Looks like this set wasn't sent until -rc6 which is when I normally stop applying significant patches. I think it's best that we wait until the next rotation. That way all this dependency related hoop-jumping just goes away. > > On 4/30/19 9:17 PM, Dan Murphy wrote: > > > Hello > > > > > > I have added the Reviewed-by for dt bindings as well as made the > > > Kconfig change > > > pointed out for the common code flag > > > > > > Dan > > > > > > Dan Murphy (7): > > > dt-bindings: mfd: LMU: Fix lm3632 dt binding example > > > dt-bindings: mfd: LMU: Add the ramp up/down property > > > dt-bindings: mfd: LMU: Add ti,brightness-resolution > > > leds: TI LMU: Add common code for TI LMU devices > > > dt-bindings: ti-lmu: Modify dt bindings for the LM3697 > > > mfd: ti-lmu: Remove support for LM3697 > > > leds: lm3697: Introduce the lm3697 driver > > > > > > .../devicetree/bindings/leds/leds-lm3697.txt | 73 ++++ > > > .../devicetree/bindings/mfd/ti-lmu.txt | 56 ++- > > > drivers/leds/Kconfig | 15 + > > > drivers/leds/Makefile | 2 + > > > drivers/leds/leds-lm3697.c | 395 ++++++++++++++++++ > > > drivers/leds/ti-lmu-led-common.c | 155 +++++++ > > > drivers/mfd/Kconfig | 2 +- > > > drivers/mfd/ti-lmu.c | 17 - > > > include/linux/mfd/ti-lmu-register.h | 44 -- > > > include/linux/mfd/ti-lmu.h | 1 - > > > include/linux/ti-lmu-led-common.h | 47 +++ > > > 11 files changed, 712 insertions(+), 95 deletions(-) > > > create mode 100644 > > > Documentation/devicetree/bindings/leds/leds-lm3697.txt > > > create mode 100644 drivers/leds/leds-lm3697.c > > > create mode 100644 drivers/leds/ti-lmu-led-common.c > > > create mode 100644 include/linux/ti-lmu-led-common.h > > > > > > > > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog