| Message ID | 20241112143056.565122-2-cvam0000@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | kselftest: tmpfs: Add ksft macros and skip if no root | expand |
diff --git a/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c b/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c index b5c3ddb90942..f0b36e7a152e 100644 --- a/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c +++ b/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c @@ -23,10 +23,21 @@ #include <sys/mount.h> #include <unistd.h> +#include "../kselftest.h" + int main(void) { int fd; + /* Setting up kselftest framework */ + ksft_print_header(); + ksft_set_plan(1); + + /* Check if test is run as root */ + if (geteuid()) { + ksft_exit_fail_msg("Error : Need to run as root"); + } + if (unshare(CLONE_NEWNS) == -1) { if (errno == ENOSYS || errno == EPERM) { fprintf(stderr, "error: unshare, errno %d\n", errno);
Add 'ksft_exit_fail_msg()', if not run as root, with an appropriate Warning. Add 'ksft_print_header()' and 'ksft_set_plan()' to structure test outputs more effectively. Test logs: Before Change: - Without root error: unshare, errno 1 - With root No, output After Change: - Without root TAP version 13 1..1 Bail out! Error : Need to run as root# Planned tests != run tests (1 != 0) - With root TAP version 13 1..1 Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com> --- tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c | 11 +++++++++++ 1 file changed, 11 insertions(+)