From patchwork Thu Jul 25 02:34:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Jun X-Patchwork-Id: 814505 Received: from cmccmta3.chinamobile.com (cmccmta6.chinamobile.com [111.22.67.139]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A6211103; Thu, 25 Jul 2024 02:34:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=111.22.67.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721874867; cv=none; b=VzN/egYMfu2BeEEDuKSwikpn9kqFvWADXW9y7vrwjJ0LAPaVhHDj+9SSaJPDRAIcoukhsTJCQBwx53yeoSubuo5iD5sQw2lIs627uifOCbDqNo+UrmEjAG6OSEuc2pRifvisWGYuWD+F8ZIn9UD9/VgqcUirdG3jrfRPv4/LbSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721874867; c=relaxed/simple; bh=b0p9hIs73UVjOkDg+cEbXbIHemjxZEx4CTcG+jIMPMk=; h=From:To:Cc:Subject:Date:Message-Id; b=Imj0f2sAuNjn1Jdu/iJhBVV/hotRkVephijX30MDFqGPNjWo+knVi1jVQbbNcHsUv9PSLrhivyw2W42OF7NHtLFwB1InNIti1UE67EInyywIkQdNxT/g9fdBrcOHXX4RFT17JjJAcGt1o02BsMx5G8vFP9Uqpe0N18/eKudbvqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cmss.chinamobile.com; spf=pass smtp.mailfrom=cmss.chinamobile.com; arc=none smtp.client-ip=111.22.67.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cmss.chinamobile.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmss.chinamobile.com X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from spf.mail.chinamobile.com (unknown[10.188.0.87]) by rmmx-syy-dmz-app09-12009 (RichMail) with SMTP id 2ee966a1b99af42-a3f42; Thu, 25 Jul 2024 10:34:02 +0800 (CST) X-RM-TRANSID: 2ee966a1b99af42-a3f42 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from ubuntu.localdomain (unknown[223.108.79.96]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee266a1b999d04-c6c8c; Thu, 25 Jul 2024 10:34:02 +0800 (CST) X-RM-TRANSID: 2ee266a1b999d04-c6c8c From: Zhu Jun To: zhang.lyra@gmail.com Cc: shuah@kernel.org, kees@kernel.org, luto@amacapital.net, wad@chromium.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, zhujun2@cmss.chinamobile.com Subject: [PATCH v4] tools/testing:Fix the wrong format specifier Date: Wed, 24 Jul 2024 19:34:01 -0700 Message-Id: <20240725023401.13365-1-zhujun2@cmss.chinamobile.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The format specifier in fprintf is "%u", that "%u" should use unsigned int type instead.the problem is discovered by reading code. Signed-off-by: Zhu Jun --- v1->v2: modify commit info add how to find the problem in the log v2->v3: Seems this can use macro WTERMSIG like those above usage, rather than changing the print format. v3->v4: Now the commit summary doesn't match the change you are making. Also WTERMSIG() is incorrect for this conditional code path. See comments below in the code path. I would leave the v2 code intact. How are you testing this change? Please include the details in the change log. tools/testing/selftests/kselftest_harness.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h index e05ac8261046..675b8f43e148 100644 --- a/tools/testing/selftests/kselftest_harness.h +++ b/tools/testing/selftests/kselftest_harness.h @@ -910,7 +910,7 @@ void __wait_for_test(struct __test_metadata *t) .sa_flags = SA_SIGINFO, }; struct sigaction saved_action; - int status; + unsigned int status; if (sigaction(SIGALRM, &action, &saved_action)) { t->passed = 0;