From patchwork Mon Jan 20 13:06:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 208899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C070AC2D0DB for ; Mon, 20 Jan 2020 13:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98F7022522 for ; Mon, 20 Jan 2020 13:08:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bhX7yiQC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbgATNGr (ORCPT ); Mon, 20 Jan 2020 08:06:47 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:28249 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727289AbgATNGr (ORCPT ); Mon, 20 Jan 2020 08:06:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579525606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVICxkwYE819T09jumS9b6kqZZVW9alGabNhw2Byv4c=; b=bhX7yiQC06ov8M3HpddvHv1pG1e/EwEZ6AzVoYP+YZaot0iUufBUXPWd1c8e7WTe+FmGBj HSllop26wd/fEU9wb3SCNorMgXZ+JGdZAJLmxDIbzeDNgMedZR+zw3NS3Awlkhlu2Oe42k tuHM1oxS0oGxA5+lE/ec2khu+6SZ1AE= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-jxfYp7ZhOXmqOffpz_V1dg-1; Mon, 20 Jan 2020 08:06:45 -0500 X-MC-Unique: jxfYp7ZhOXmqOffpz_V1dg-1 Received: by mail-lj1-f200.google.com with SMTP id z17so7516645ljz.2 for ; Mon, 20 Jan 2020 05:06:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=oVICxkwYE819T09jumS9b6kqZZVW9alGabNhw2Byv4c=; b=ZaNTM7tjFGzkSi+2UQ/KJkgeTXDaD7Y7d/sLDABKkq9smD9cBF2+SV+Lqe83xBnud9 SNSXQBmUyMiiLwjzHBP0uh01w8VXMAGj6BKEtNndkQQy+vJGYm/D+0xmNJVXoumqi84N s3ZlYRvmwWKu9VQey14R5nvNLRLQmKhd7RadrfQnw/qxVuAi5b4B1WmGcbop1JQdsvkJ 9CqYfpjHuYsqH+gJQslgCEAtmLWua9BYfPrvzSdUXhnExQFOjM+u3KJWtsYb65OWYLP6 rMt1uFED4d1nu7yVtmaTUEEOv0ZqWrKnQJWlwvZAXLUH5NZgUvWaDUkX0T56fjKDcP9h atlQ== X-Gm-Message-State: APjAAAUivZ8IdX4H5a2pxf4hM00EufJK4P1zYeZyS/yzfWyV+3qH56mU JXACaj5vFc7TkYXqIta265YZ/KDCYC9heDYlT0wnolmmfRd7v+gfowrDeKpDgD9CdzihxYVLjAP 0A/7r9lpbAmhBqLn/+KG07ZV8fmzI X-Received: by 2002:a2e:9015:: with SMTP id h21mr13901701ljg.69.1579525603444; Mon, 20 Jan 2020 05:06:43 -0800 (PST) X-Google-Smtp-Source: APXvYqxl6cjsyjw8Scl4Npe4TQQoKpYIFE7qfthL3twnuQzv1KZL4kmSTEjNXwjKvkvlIou0OEBbwA== X-Received: by 2002:a2e:9015:: with SMTP id h21mr13901661ljg.69.1579525603114; Mon, 20 Jan 2020 05:06:43 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id z5sm16825740lji.40.2020.01.20.05.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 05:06:42 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 59E971804D7; Mon, 20 Jan 2020 14:06:41 +0100 (CET) Subject: [PATCH bpf-next v5 01/11] samples/bpf: Don't try to remove user's homedir on clean From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Alexei Starovoitov Cc: Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Doug Ledford , Jason Gunthorpe , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Shuah Khan , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, clang-built-linux@googlegroups.com Date: Mon, 20 Jan 2020 14:06:41 +0100 Message-ID: <157952560126.1683545.7273054725976032511.stgit@toke.dk> In-Reply-To: <157952560001.1683545.16757917515390545122.stgit@toke.dk> References: <157952560001.1683545.16757917515390545122.stgit@toke.dk> User-Agent: StGit/0.21 MIME-Version: 1.0 Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org From: Toke Høiland-Jørgensen The 'clean' rule in the samples/bpf Makefile tries to remove backup files (ending in ~). However, if no such files exist, it will instead try to remove the user's home directory. While the attempt is mostly harmless, it does lead to a somewhat scary warning like this: rm: cannot remove '~': Is a directory Fix this by using find instead of shell expansion to locate any actual backup files that need to be removed. Fixes: b62a796c109c ("samples/bpf: allow make to be run from samples/bpf/ directory") Acked-by: Jesper Dangaard Brouer Signed-off-by: Toke Høiland-Jørgensen --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index 5b89c0370f33..f86d713a17a5 100644 --- a/samples/bpf/Makefile +++ b/samples/bpf/Makefile @@ -254,7 +254,7 @@ all: clean: $(MAKE) -C ../../ M=$(CURDIR) clean - @rm -f *~ + @find $(CURDIR) -type f -name '*~' -delete $(LIBBPF): FORCE # Fix up variables inherited from Kbuild that tools/ build system won't like