Message ID | GV1PR10MB6563BEFEA4269E1DDBC264B1E8BBA@GV1PR10MB6563.EURPRD10.PROD.OUTLOOK.COM |
---|---|
Headers | show |
Series | selftests/bpf: Update multiple prog_tests to use ASSERT_ macros | expand |
Hello: This series was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Tue, 21 Nov 2023 05:33:14 +0530 you wrote: > Multiple files/programs in `tools/testing/selftests/bpf/prog_tests/` still > heavily use the `CHECK` macro, even when better `ASSERT_` alternatives are > available. > > As it was already pointed out by Yonghong Song [1] in the bpf selftests the use > of the ASSERT_* series of macros is preferred over the CHECK macro. > > [...] Here is the summary with links: - [bpf-next,v3,1/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bpf_tcp_ca https://git.kernel.org/bpf/bpf-next/c/b0e2a0395312 - [bpf-next,v3,2/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bind_perm https://git.kernel.org/bpf/bpf-next/c/3ec1114a9745 - [bpf-next,v3,3/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bpf_obj_id https://git.kernel.org/bpf/bpf-next/c/f125d09b99fc - [bpf-next,v3,4/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in vmlinux https://git.kernel.org/bpf/bpf-next/c/3ece0e85f679 You are awesome, thank you!
On Mon, Nov 20, 2023 at 10:49:39PM -0800, Yonghong Song wrote: > Yuran, next time when you submit patches, you can carry 'Acked-by' tag > from previous revision if there are no significant changes. This will > reduce some of reviewers and maintainers' work. > Alright, I will keep that in mind in the future. Thanks, Yuran Pereira