| Message ID | 20250225110252.28866-1-hayashi.kunihiko@socionext.com |
|---|---|
| Headers | show |
| Series | Fix some issues related to an interrupt type in pci_endpoint_test | expand |
On Tue, Feb 25, 2025, at 12:02, Kunihiko Hayashi wrote: > The pci_endpoint_test_request_irq() and pci_endpoint_test_release_irq() > are called repeatedly by the users through pci_endpoint_test_set_irq(). > So using the managed version of IRQ functions within these functions > has no effect. > > Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Acked-by: Arnd Bergmann <arnd@arndb.de>
Hello, > This series solves some issues about global "irq_type" that is used for > indicating the current type for users. > > In addition, avoid an unexpected warning that occur due to interrupts > remaining after displaying an error caused by devm_request_irq(). > > Patch 1 includes adding GET_IRQTYPE test (check for failure). > Patch 2-4 include fixes for stable kernels that have global "irq_type". > Patch 5-6 include improvements for the latest. Applied to misc, thank you! Krzysztof
This series solves some issues about global "irq_type" that is used for indicating the current type for users. In addition, avoid an unexpected warning that occur due to interrupts remaining after displaying an error caused by devm_request_irq(). Patch 1 includes adding GET_IRQTYPE test (check for failure). Patch 2-4 include fixes for stable kernels that have global "irq_type". Patch 5-6 include improvements for the latest. Changes since v3: - Add GET_IRQTYPE check to pci_endpoint test in selftests - Add the reason why global variables aren't necessary (patch 5/6) - Add Reviewed-by: lines (patch {2, 4, 6}/6) Changes since v2: - Rebase to v6.14-rc1 - Update message to clarify, and add result of call trace (patch 1/5) - Add Reviewed-by: lines (patch 2/5) - Add new patch to remove global "irq_type" variable (patch 4/5) - Add new patch to replace "devm" version of IRQ functions (patch 5/5) Changes since v1: - Divide original patch into two - Add an error message example - Add "pcitest" display example - Add a patch to fix an interrupt remaining issue Kunihiko Hayashi (6): selftests: pci_endpoint: Add GET_IRQTYPE checks to each interrupt test misc: pci_endpoint_test: Avoid issue of interrupts remaining after request_irq error misc: pci_endpoint_test: Fix displaying irq_type after request_irq error misc: pci_endpoint_test: Fix irq_type to convey the correct type misc: pci_endpoint_test: Remove global 'irq_type' and 'no_msi' misc: pci_endpoint_test: Do not use managed irq functions drivers/misc/pci_endpoint_test.c | 31 +++++++------------ .../pci_endpoint/pci_endpoint_test.c | 11 ++++++- 2 files changed, 21 insertions(+), 21 deletions(-)