From patchwork Thu Nov 14 21:50:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alexis_Lothor=C3=A9?= X-Patchwork-Id: 843319 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53FBD76026; Thu, 14 Nov 2024 21:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731621075; cv=none; b=hC3PTjFM4W78uZq867umISczP4EKQQlMtLxXWbnYM3vMyOv3VVZhw9216L4WfM4WbGXOY3VajHjxCEC1kF4dX6y2UHOTIO+e+0fWj8MkyTr4XmMwRJgRBxWyoQM6gRmtVgWHOL1wtSYYy1uYbL+VopzTx5kUTbKjXoml0J6eEzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731621075; c=relaxed/simple; bh=WjZXsL/Ggv5UxmzL0W2lHjr1qDI30J7jiFurXL1yZN4=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=lB3oMVBSl1u27WxJBgWY4ISbNiYn2UgSpIyJq/9C+oi1lyP/1XJglkmVkUQJjKqbXvrHgLqh7eeShoGlXLwIZOzS//tSjFtef0F7XyivPgBeEHgXu7VL6Kf+myrCcE4eywDRtBK6RpPaxEoljvzhSlqd3kTtBM5TGXd6SYHrzS4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=RMedzhgu; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="RMedzhgu" Received: by mail.gandi.net (Postfix) with ESMTPSA id 8D6A520003; Thu, 14 Nov 2024 21:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1731621070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n3bfEiuXzWiyxNpW5BbZa2NuPMpbT/vYsRPGYQ4Ljww=; b=RMedzhgu3sJZurlFt3wTLbZwSnVLYQLfXU1TtNlvI3EPOzi6cUGJQe1vaNUvJXmeZT65Bw 22kGKeMLw2ZOC+PBhzMwrB+pgIsLONZSoUdTd4MJaHGUd/kl0K/XCHFundwPNnOrqqTq4T YgzTBGhsZaJNApguYsSLZ+0Uh1s9+mADWj5K0lj4a4QHw33ZjC8a1n4mSWR3TLGXtMrW0r jW2MPdAe79+zeP5+fQNR7D4/UCbyVAVSg4PJWWqbEO5Y4z+jzJysnqWawRDMOi5IhRjs+K r7Mz5niUKboLJ//BXEvts+YofQwKF5bxZBvWhQKYBLa4oHBPyWNPX/I1uG53hw== From: =?utf-8?q?Alexis_Lothor=C3=A9_=28eBPF_Foundation=29?= Subject: [PATCH bpf-next v2 00/13] selftests/bpf: migrate test_flow_dissector.sh to test_progs Date: Thu, 14 Nov 2024 22:50:31 +0100 Message-Id: <20241114-flow_dissector-v2-0-ee4a3be3de65@bootlin.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAKdwNmcC/12NQQrCMBBFryKzNpJJq6WuvIcUsZOJHahJSUqtl N7dkKXLx+e9v0HiKJzgetgg8iJJgs9gjgeg4elfrMRmBqNNjRpb5cbweVhJiWkOUVXca9KNI7x UkKUpspO1BO/QT055Xmfo8jJIysK3PC1Y9hJFrP6jCyqtTEO1dfrcGku3PoR5FH+i8IZu3/cfu Z1tlbgAAAA= X-Change-ID: 20241019-flow_dissector-3eb0c07fc163 To: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer Cc: ebpf@linuxfoundation.org, Thomas Petazzoni , Bastien Curutchet , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, =?utf-8?q?Alexis_Lothor=C3=A9_=28eBPF_Foundation?= =?utf-8?q?=29?= X-Mailer: b4 0.14.2 X-GND-Sasl: alexis.lothore@bootlin.com Hello, this new series aims to migrate test_flow_dissector.sh into test_progs. There are 2 "main" parts in test_flow_dissector.sh: - a set of tests checking flow_dissector programs attachment to either root namespace or non-root namespace - dissection test The first set is integrated in flow_dissector.c, which already contains some existing tests for flow_dissector programs. This series uses the opportunity to update a bit this file (use new assert, re-split tests, etc) The second part is migrated into a new file under test_progs, flow_dissector_classification.c. It uses the same eBPF programs as flow_dissector.c, but the difference is rather about how those program are executed: - flow_dissector.c manually runs programs with BPF_PROG_RUN - flow_dissector_classification.c sends real packets to be dissected, and so it also executes kernel code related to eBPF flow dissector (eg: __skb_flow_bpf_to_target) Acked-by: Stanislav Fomichev Acked-by: Stanislav Fomichev --- Changes in v2: - allow tests to run in parallel - move some generic helpers to network_helpers.h - define proper function for ASSERT_MEMEQ - fetch acked-by tags - Link to v1: https://lore.kernel.org/r/20241113-flow_dissector-v1-0-27c4df0592dc@bootlin.com --- Alexis Lothoré (eBPF Foundation) (13): selftests/bpf: add a macro to compare raw memory selftests/bpf: use ASSERT_MEMEQ to compare bpf flow keys selftests/bpf: replace CHECK calls with ASSERT macros in flow_dissector test selftests/bpf: re-split main function into dedicated tests selftests/bpf: expose all subtests from flow_dissector selftests/bpf: add gre packets testing to flow_dissector selftests/bpf: migrate flow_dissector namespace exclusivity test selftests/bpf: Enable generic tc actions in selftests config selftests/bpf: move ip checksum helper to network helpers selftests/bpf: rename pseudo headers checksum computation selftests/bpf: add network helpers to generate udp checksums selftests/bpf: migrate bpf flow dissectors tests to test_progs selftests/bpf: remove test_flow_dissector.sh tools/testing/selftests/bpf/.gitignore | 1 - tools/testing/selftests/bpf/Makefile | 3 +- tools/testing/selftests/bpf/config | 1 + tools/testing/selftests/bpf/network_helpers.h | 64 +- .../selftests/bpf/prog_tests/flow_dissector.c | 323 +++++++-- .../bpf/prog_tests/flow_dissector_classification.c | 807 +++++++++++++++++++++ .../selftests/bpf/prog_tests/xdp_metadata.c | 24 +- tools/testing/selftests/bpf/test_flow_dissector.c | 780 -------------------- tools/testing/selftests/bpf/test_flow_dissector.sh | 178 ----- tools/testing/selftests/bpf/test_progs.c | 15 + tools/testing/selftests/bpf/test_progs.h | 15 + tools/testing/selftests/bpf/xdp_hw_metadata.c | 12 +- 12 files changed, 1153 insertions(+), 1070 deletions(-) --- base-commit: 9e71d50d3befb93a6394b0979f8ebd0dc9bd8d0f change-id: 20241019-flow_dissector-3eb0c07fc163 Best regards,