| Message ID | 20240823211902.143210-1-jmaloy@redhat.com |
|---|---|
| Headers | show |
| Series | Adding SO_PEEK_OFF for TCPv6 | expand |
On Sat, Aug 24, 2024 at 5:19 AM <jmaloy@redhat.com> wrote: > > From: Jon Maloy <jmaloy@redhat.com> > > When we added the SO_PEEK_OFF socket option to TCP we forgot > to add it even for TCP on IPv6. Even though you said "we forgot", I'm not sure if this patch series belongs to net-next material... > > We do that here. > > Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") > Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > Reviewed-by: Stefano Brivio <sbrivio@redhat.com> > Tested-by: Stefano Brivio <sbrivio@redhat.com> > Signed-off-by: Jon Maloy <jmaloy@redhat.com> Reviewed-by: Jason Xing <kerneljasonxing@gmail.com> You seem to forget to carry Eric's Reviewed-by tag, please see the link :) https://lore.kernel.org/all/CANn89iJmdGdAN1OZEfoM2LNVOewkYDuPXObRoNWhGyn93P=8OQ@mail.gmail.com/ Thanks, Jason
On Fri, Aug 23, 2024 at 11:19 PM <jmaloy@redhat.com> wrote: > > From: Jon Maloy <jmaloy@redhat.com> > > When we added the SO_PEEK_OFF socket option to TCP we forgot > to add it even for TCP on IPv6. > > We do that here. > > Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") > Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > Reviewed-by: Stefano Brivio <sbrivio@redhat.com> > Tested-by: Stefano Brivio <sbrivio@redhat.com> > Signed-off-by: Jon Maloy <jmaloy@redhat.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Thanks.
On 2024-08-23 19:51, Jason Xing wrote: > On Sat, Aug 24, 2024 at 5:19 AM <jmaloy@redhat.com> wrote: >> From: Jon Maloy <jmaloy@redhat.com> >> >> When we added the SO_PEEK_OFF socket option to TCP we forgot >> to add it even for TCP on IPv6. > Even though you said "we forgot", I'm not sure if this patch series > belongs to net-next material... I agree regarding the fix. The selftest is new however, and belongs in net-next because of that. Since I made it one series I decided for net-next, but I leave it to the discretion of Jakub and the maintainer of the linux-kselftest system to decide where they go. ///jon > >> We do that here. >> >> Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") >> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> >> Reviewed-by: Stefano Brivio <sbrivio@redhat.com> >> Tested-by: Stefano Brivio <sbrivio@redhat.com> >> Signed-off-by: Jon Maloy <jmaloy@redhat.com> > Reviewed-by: Jason Xing <kerneljasonxing@gmail.com> > > You seem to forget to carry Eric's Reviewed-by tag, please see the link :) > https://lore.kernel.org/all/CANn89iJmdGdAN1OZEfoM2LNVOewkYDuPXObRoNWhGyn93P=8OQ@mail.gmail.com/ > > Thanks, > Jason >
From: Jon Maloy <jmaloy@redhat.com> Adding SO_PEEK_OFF for TCPv6 and selftest for both TCPv4 and TCPv6. Jon Maloy (2): tcp: add SO_PEEK_OFF socket option tor TCPv6 selftests: add selftest for tcp SO_PEEK_OFF support net/ipv6/af_inet6.c | 1 + tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/tcp_so_peek_off.c | 181 ++++++++++++++++++ 3 files changed, 183 insertions(+) create mode 100644 tools/testing/selftests/net/tcp_so_peek_off.c