mbox series

[PATCH-cgroup,0/2] cgroup/cpuset: Account for boot time isolated CPUs

Message ID 20240820195536.202066-1-longman@redhat.com
Headers show
Series cgroup/cpuset: Account for boot time isolated CPUs | expand

Message

Waiman Long Aug. 20, 2024, 7:55 p.m. UTC 
The current cpuset code and test_cpuset_prs.sh test have not fully
account for the possibility of pre-isolated CPUs added by the "isolcpus"
boot command line parameter. This patch series modifies them to do the
right thing whether or not "isolcpus" is present or not.

The updated test_cpuset_prs.sh was run successfully with or without the
"isolcpus" option.

Waiman Long (2):
  cgroup/cpuset: Account for boot time isolated CPUs
  selftest/cgroup: Make test_cpuset_prs.sh deal with pre-isolated CPUs

 kernel/cgroup/cpuset.c                        | 23 +++++++---
 .../selftests/cgroup/test_cpuset_prs.sh       | 44 ++++++++++++++-----
 2 files changed, 51 insertions(+), 16 deletions(-)

Comments

Waiman Long Aug. 26, 2024, 7:01 p.m. UTC | #1 
On 8/20/24 15:55, Waiman Long wrote:
> The current cpuset code and test_cpuset_prs.sh test have not fully
> account for the possibility of pre-isolated CPUs added by the "isolcpus"
> boot command line parameter. This patch series modifies them to do the
> right thing whether or not "isolcpus" is present or not.
>
> The updated test_cpuset_prs.sh was run successfully with or without the
> "isolcpus" option.
>
> Waiman Long (2):
>    cgroup/cpuset: Account for boot time isolated CPUs
>    selftest/cgroup: Make test_cpuset_prs.sh deal with pre-isolated CPUs
>
>   kernel/cgroup/cpuset.c                        | 23 +++++++---
>   .../selftests/cgroup/test_cpuset_prs.sh       | 44 ++++++++++++++-----
>   2 files changed, 51 insertions(+), 16 deletions(-)
>
Ping! Any comment on these patches?

Thanks,
Longman
Tejun Heo Aug. 26, 2024, 7:05 p.m. UTC | #2 
Hello, Waiman.

On Mon, Aug 26, 2024 at 03:01:21PM -0400, Waiman Long wrote:
> Ping! Any comment on these patches?

cgroup side looks fine to me. Ping isol people?

Thanks.
Waiman Long Aug. 26, 2024, 7:41 p.m. UTC | #3 
On 8/26/24 15:05, Tejun Heo wrote:
> Hello, Waiman.
>
> On Mon, Aug 26, 2024 at 03:01:21PM -0400, Waiman Long wrote:
>> Ping! Any comment on these patches?
> cgroup side looks fine to me. Ping isol people?

This patchset is specific to cpuset code and doesn't touch any isolation 
code at all. My other isolation related patch series [1] does have a 
dependency on this one to work correctly.

[1] https://lore.kernel.org/lkml/20240821142312.236970-1-longman@redhat.com/

Cheers,
Longman
Tejun Heo Aug. 26, 2024, 8:16 p.m. UTC | #4 
On Mon, Aug 26, 2024 at 03:41:23PM -0400, Waiman Long wrote:
> 
> On 8/26/24 15:05, Tejun Heo wrote:
> > Hello, Waiman.
> > 
> > On Mon, Aug 26, 2024 at 03:01:21PM -0400, Waiman Long wrote:
> > > Ping! Any comment on these patches?
> > cgroup side looks fine to me. Ping isol people?
> 
> This patchset is specific to cpuset code and doesn't touch any isolation
> code at all. My other isolation related patch series [1] does have a
> dependency on this one to work correctly.
> 
> [1] https://lore.kernel.org/lkml/20240821142312.236970-1-longman@redhat.com/

Oh, I was confused of the two patchsets. I thought the second one was the
replacement for this one. Will take another look.

Thanks.