mbox series

[v3,0/6] ALSA: some driver fixes for control input validations

Message ID 20240616073454.16512-1-tiwai@suse.de
Headers show
Series ALSA: some driver fixes for control input validations | expand

Message

Takashi Iwai June 16, 2024, 7:34 a.m. UTC 
Hi,

this is a v3 patch set as a follow up of the thread about the errors
reported by kselftest mixer-test.  It changes HD-audio and vmaster
control behavior to return -EINVAL for invalid input values.

There is a change in kselftest itself to skip the verification after
write tests for volatile controls, too.  It's for the channel map
controls that can't hold the stable values.

v2->v3:
* Replace with Mark's patch for kselftest
* Apply the validation for user controls in put callback instead

v1->v2:
* Skip only verification after write in kselftest
* Add sanity check to HDMI chmap write, too

v2: https://lore.kernel.org/r/20240614153717.30143-1-tiwai@suse.de
v1: https://lore.kernel.org/r/20240614124728.27901-1-tiwai@suse.de

Takashi

===

Mark Brown (1):
  kselftest/alsa: Fix validation of writes to volatile controls

Takashi Iwai (5):
  ALSA: vmaster: Return error for invalid input values
  ALSA: hda: Return -EINVAL for invalid volume/switch inputs
  ALSA: control: Apply sanity check of input values for user elements
  ALSA: chmap: Mark Channel Map controls as volatile
  ALSA: hda: Add input value sanity checks to HDMI channel map controls

 sound/core/control.c                      |  6 ++-
 sound/core/pcm_lib.c                      |  1 +
 sound/core/vmaster.c                      |  8 ++++
 sound/hda/hdmi_chmap.c                    | 18 +++++++++
 sound/pci/hda/hda_codec.c                 | 23 +++++++++---
 tools/testing/selftests/alsa/mixer-test.c | 45 +++++++++++++++--------
 6 files changed, 79 insertions(+), 22 deletions(-)