| Message ID | 20221031084924.1742169-1-li.meng@amd.com |
|---|---|
| Headers | show |
| Series | Add tbench/gitsource new test cases for amd-pstate-ut | expand |
On 10/31/22 04:04, Shuah Khan wrote: > On 10/31/22 02:49, Meng Li wrote: >> Hi all: >> >> First, rename amd-pstate-ut.sh to basic.sh as a basic test, mainly for >> AMD P-State kernel drivers. The purpose of this modification is to >> facilitate the subsequent addition of gitsource, tbench and other tests. >> >> Second, split basic.sh into run.sh and basic.sh. >> The modification makes basic.sh more pure, just for test basic kernel >> functions. The file of run.sh mainly contains functions such as test >> entry, parameter check, prerequisite and log clearing etc. >> >> Third, add tbench.sh trigger the tbench testing and monitor the cpu. >> >> Fourth, add gitsource.sh trigger the gitsource testing and monitor the cpu >> information. >> >> Finally, modify rst document to introduce test steps and results etc. >> > >> >> Changes from V4->V5: >> - selftests: amd-pstate: >> - - rename amd-pstate-ut.sh to basic.sh. >> - - split basic.sh into run.sh and basic.sh. >> - - modify tbench.sh to prompt to install tbench. >> - - modify commit messages and description informations of shell files. >> - Documentation: amd-pstate: >> - - correct spell errors. >> > > v5 series looks good. Please cleanup checkpatch errors in a couple of files. > Not too concerned about long line warnings as these seem like "echo" > statements with output text. > Applied to linux-kselftest next now after fixing the white space error. Please run checkpatch in the future. thanks, -- Shuah
[AMD Official Use Only - General] > -----Original Message----- > From: Shuah Khan <skhan@linuxfoundation.org> > Sent: Tuesday, November 1, 2022 5:27 PM > To: Meng, Li (Jassmine) <Li.Meng@amd.com>; Huang, Ray > <Ray.Huang@amd.com>; linux-kselftest@vger.kernel.org > Cc: Rafael J . Wysocki <rafael.j.wysocki@intel.com>; Fontenot, Nathan > <Nathan.Fontenot@amd.com>; Sharma, Deepak > <Deepak.Sharma@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Limonciello, Mario > <Mario.Limonciello@amd.com>; Huang, Shimmer > <Shimmer.Huang@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; Du, > Xiaojian <Xiaojian.Du@amd.com>; Viresh Kumar <viresh.kumar@linaro.org>; > Borislav Petkov <bp@alien8.de>; linux-kernel@vger.kernel.org; Shuah Khan > <skhan@linuxfoundation.org> > Subject: Re: [PATCH V5 0/5] Add tbench/gitsource new test cases for amd- > pstate-ut > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On 10/31/22 04:04, Shuah Khan wrote: > > On 10/31/22 02:49, Meng Li wrote: > >> Hi all: > >> > >> First, rename amd-pstate-ut.sh to basic.sh as a basic test, mainly > >> for AMD P-State kernel drivers. The purpose of this modification is > >> to facilitate the subsequent addition of gitsource, tbench and other tests. > >> > >> Second, split basic.sh into run.sh and basic.sh. > >> The modification makes basic.sh more pure, just for test basic kernel > >> functions. The file of run.sh mainly contains functions such as test > >> entry, parameter check, prerequisite and log clearing etc. > >> > >> Third, add tbench.sh trigger the tbench testing and monitor the cpu. > >> > >> Fourth, add gitsource.sh trigger the gitsource testing and monitor > >> the cpu information. > >> > >> Finally, modify rst document to introduce test steps and results etc. > >> > > > >> > >> Changes from V4->V5: > >> - selftests: amd-pstate: > >> - - rename amd-pstate-ut.sh to basic.sh. > >> - - split basic.sh into run.sh and basic.sh. > >> - - modify tbench.sh to prompt to install tbench. > >> - - modify commit messages and description informations of shell files. > >> - Documentation: amd-pstate: > >> - - correct spell errors. > >> > > > > v5 series looks good. Please cleanup checkpatch errors in a couple of files. > > Not too concerned about long line warnings as these seem like "echo" > > statements with output text. > > > > Applied to linux-kselftest next now after fixing the white space error. Please > run checkpatch in the future. > Thank you very much. I will pay attention to it. Jasmine > thanks, > -- Shuah