mbox series

[0/4] Documentation: KUnit: minor fixes

Message ID 20220813042055.136832-1-tales.aparecida@gmail.com
Headers show
Series Documentation: KUnit: minor fixes | expand

Message

Tales Aparecida Aug. 13, 2022, 4:20 a.m. UTC
Hi,

This is a short series of minor fixes to the Kunit documentation,
they probably can be squashed but I suppose it's easier
to review them individually.

Thanks for any feedbacks,
Tales

Tales Aparecida (4):
  Documentation: kunit: fix trivial typo
  Documentation: Kunit: Fix inconsistent titles
  Documentation: KUnit: Fix non-uml anchor
  Documentation: Kunit: Add ref for other kinds of tests

 Documentation/dev-tools/kunit/architecture.rst | 4 ++--
 Documentation/dev-tools/kunit/faq.rst          | 8 +++++---
 Documentation/dev-tools/kunit/index.rst        | 2 ++
 Documentation/dev-tools/kunit/run_wrapper.rst  | 4 +++-
 Documentation/dev-tools/kunit/usage.rst        | 4 ++--
 5 files changed, 14 insertions(+), 8 deletions(-)

Comments

André Almeida Aug. 15, 2022, 4:51 p.m. UTC | #1
Hi Tales,

On 8/13/22 01:20, Tales Aparecida wrote:
> Hi,
> 
> This is a short series of minor fixes to the Kunit documentation,
> they probably can be squashed but I suppose it's easier
> to review them individually.
> 
> Thanks for any feedbacks,
> Tales
> 

Series is Reviewed-by: André Almeida <andrealmeid@igalia.com>
Sadiya Kazi Aug. 17, 2022, 6:41 a.m. UTC | #2
On Sat, Aug 13, 2022 at 9:51 AM Tales Aparecida
<tales.aparecida@gmail.com> wrote:
>
> Missing closing block-quote
>
> Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com>
> ---


Hi,
I do agree with David on a more descriptive commit message to be
addressed in future patches. Otherwise, it looks good to me.

Reviewed-by: Sadiya Kazi <sadiyakazi@google.com>

Best Regards,
Sadiya




>  Documentation/dev-tools/kunit/run_wrapper.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/dev-tools/kunit/run_wrapper.rst b/Documentation/dev-tools/kunit/run_wrapper.rst
> index cce203138fb7..db1e867820e7 100644
> --- a/Documentation/dev-tools/kunit/run_wrapper.rst
> +++ b/Documentation/dev-tools/kunit/run_wrapper.rst
> @@ -30,7 +30,7 @@ We may want to use the following options:
>
>  .. code-block::
>
> -       ./tools/testing/kunit/kunit.py run --timeout=30 --jobs=`nproc --all
> +       ./tools/testing/kunit/kunit.py run --timeout=30 --jobs=`nproc --all`
>
>  - ``--timeout`` sets a maximum amount of time for tests to run.
>  - ``--jobs`` sets the number of threads to build the kernel.
> --
> 2.37.1
>
Tales Aparecida Aug. 18, 2022, 6:20 p.m. UTC | #3
On 13/08/2022 01:20, Tales Aparecida wrote:
> Hi,
> 
> This is a short series of minor fixes to the Kunit documentation,
> they probably can be squashed but I suppose it's easier
> to review them individually.
> 
> Thanks for any feedbacks,
> Tales
> 
> Tales Aparecida (4):
>    Documentation: kunit: fix trivial typo
>    Documentation: Kunit: Fix inconsistent titles
>    Documentation: KUnit: Fix non-uml anchor
>    Documentation: Kunit: Add ref for other kinds of tests
> 
>   Documentation/dev-tools/kunit/architecture.rst | 4 ++--
>   Documentation/dev-tools/kunit/faq.rst          | 8 +++++---
>   Documentation/dev-tools/kunit/index.rst        | 2 ++
>   Documentation/dev-tools/kunit/run_wrapper.rst  | 4 +++-
>   Documentation/dev-tools/kunit/usage.rst        | 4 ++--
>   5 files changed, 14 insertions(+), 8 deletions(-)
> 

Hello,

Thanks for the reviews, everyone!
Should I send a V2 with squashed commits or will a committer handle that?

Kind regards,
Tales