| Message ID | 20210307145502.2916364-1-fenghua.yu@intel.com |
|---|---|
| Headers | show |
| Series | Miscellaneous fixes for resctrl selftests | expand |
Hi Fenghua, Thanks for the patches. Sanity tested them on AMD systems. Appears to work fine. Few minor comments in few patches. Tested-by: Babu Moger <babu.moger@amd.com> Thanks Babu > -----Original Message----- > From: Fenghua Yu <fenghua.yu@intel.com> > Sent: Sunday, March 7, 2021 8:55 AM > To: Shuah Khan <shuah@kernel.org>; Tony Luck <tony.luck@intel.com>; > Reinette Chatre <reinette.chatre@intel.com>; Moger, Babu > <Babu.Moger@amd.com> > Cc: linux-kselftest <linux-kselftest@vger.kernel.org>; linux-kernel <linux- > kernel@vger.kernel.org>; Fenghua Yu <fenghua.yu@intel.com> > Subject: [PATCH v5 00/21] Miscellaneous fixes for resctrl selftests > > This patch set has several miscellaneous fixes to resctrl selftest tool that are > easily visible to user. V1 had fixes to CAT test and CMT test but they were > dropped in V2 because having them here made the patchset humongous. So, > changes to CAT test and CMT test will be posted in another patchset. > > Change Log: > v5: > - Address various comments from Shuah Khan: > 1. Move a few fixing patches before cleaning patches. > 2. Call kselftest APIs to log test results instead of printf(). > 3. Add .gitignore to ignore resctrl_tests. > 4. Share show_cache_info() in CAT and CMT tests. > 5. Define long_mask, cbm_mask, count_of_bits etc as static variables. > > v4: > - Address various comments from Shuah Khan: > 1. Combine a few patches e.g. a couple of fixing typos patches into one > and a couple of unmounting patches into one etc. > 2. Add config file. > 3. Remove "Fixes" tags. > 4. Change strcmp() to strncmp(). > 5. Move the global variable fixing patch to the patch 1 so that the > compilation issue is fixed first. > > Please note: > - I didn't move the patch of renaming CQM to CMT to the end of the series > because code and commit messages in a few other patches depend on the > new term of "CMT". If move the renaming patch to the end, the previous > patches use the old "CQM" term and code which will be changed soon at > the end of series and will cause more code and explanations. > [v3: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org > %2Flkml%2F2020%2F10%2F28%2F137&data=04%7C01%7Cbabu.moger%4 > 0amd.com%7Cd188e85e961f4d246fb208d8e17901e7%7C3dd8961fe4884e608e > 11a82d994e183d%7C0%7C0%7C637507257122356726%7CUnknown%7CTWFpb > GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M > n0%3D%7C1000&sdata=nHYN3OHv3eCZyC29T4cuiyD8SbGKoISOxsXFJHV0 > M54%3D&reserved=0] > > v3: > Address various comments (commit messages, return value on test failure, print > failure info on test failure etc) from Reinette and Tony. > [v2: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker > nel.org%2Flinux- > kselftest%2Fcover.1589835155.git.sai.praneeth.prakhya%40intel.com%2F& > ;data=04%7C01%7Cbabu.moger%40amd.com%7Cd188e85e961f4d246fb208d8e > 17901e7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6375072571 > 22356726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l > uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gHzm10%2B76r > NybPHxD2Uf6OmQINMyptbsH2mXU0QYxfw%3D&reserved=0] > > v2: > 1. Dropped changes to CAT test and CMT test as they will be posted in a later > series. > 2. Added several other fixes > [v1: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker > nel.org%2Flinux- > kselftest%2Fcover.1583657204.git.sai.praneeth.prakhya%40intel.com%2F& > ;data=04%7C01%7Cbabu.moger%40amd.com%7Cd188e85e961f4d246fb208d8e > 17901e7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6375072571 > 22356726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l > uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vQYNiVeuWVK > v6Eo8BlE%2BhBSScWbI2bznPmbnAm6esXM%3D&reserved=0] > > Fenghua Yu (19): > selftests/resctrl: Enable gcc checks to detect buffer overflows > selftests/resctrl: Fix compilation issues for global variables > selftests/resctrl: Fix compilation issues for other global variables > selftests/resctrl: Clean up resctrl features check > selftests/resctrl: Fix missing options "-n" and "-p" > selftests/resctrl: Rename CQM test as CMT test > selftests/resctrl: Call kselftest APIs to log test results > selftests/resctrl: Share show_cache_info() by CAT and CMT tests > selftests/resctrl: Add config dependencies > selftests/resctrl: Check for resctrl mount point only if resctrl FS is > supported > selftests/resctrl: Use resctrl/info for feature detection > selftests/resctrl: Fix MBA/MBM results reporting format > selftests/resctrl: Don't hard code value of "no_of_bits" variable > selftests/resctrl: Modularize resctrl test suite main() function > selftests/resctrl: Skip the test if requested resctrl feature is not > supported > selftests/resctrl: Fix unmount resctrl FS > selftests/resctrl: Fix incorrect parsing of iMC counters > selftests/resctrl: Fix checking for < 0 for unsigned values > selftests/resctrl: Create .gitignore to include resctrl_tests > > Reinette Chatre (2): > selftests/resctrl: Ensure sibling CPU is not same as original CPU > selftests/resctrl: Fix a printed message > > tools/testing/selftests/resctrl/.gitignore | 2 + > tools/testing/selftests/resctrl/Makefile | 2 +- > tools/testing/selftests/resctrl/README | 4 +- > tools/testing/selftests/resctrl/cache.c | 52 +++++- > tools/testing/selftests/resctrl/cat_test.c | 57 ++---- > .../resctrl/{cqm_test.c => cmt_test.c} | 75 +++----- > tools/testing/selftests/resctrl/config | 2 + > tools/testing/selftests/resctrl/fill_buf.c | 4 +- > tools/testing/selftests/resctrl/mba_test.c | 43 ++--- > tools/testing/selftests/resctrl/mbm_test.c | 42 ++--- > tools/testing/selftests/resctrl/resctrl.h | 29 +++- > .../testing/selftests/resctrl/resctrl_tests.c | 163 ++++++++++++------ > tools/testing/selftests/resctrl/resctrl_val.c | 95 ++++++---- > tools/testing/selftests/resctrl/resctrlfs.c | 134 ++++++++------ > 14 files changed, 408 insertions(+), 296 deletions(-) create mode 100644 > tools/testing/selftests/resctrl/.gitignore > rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (56%) create > mode 100644 tools/testing/selftests/resctrl/config > > -- > 2.30.1
Hi, Babu, On Fri, Mar 12, 2021 at 01:08:11PM -0600, Babu Moger wrote: > Hi Fenghua, Thanks for the patches. > Sanity tested them on AMD systems. Appears to work fine. > Few minor comments in few patches. > Tested-by: Babu Moger <babu.moger@amd.com> I will add Tested-by: Babu Moger in the series and address your comments. Thank you for your review! -Fenghua
On 3/12/21 3:11 PM, Fenghua Yu wrote: > Hi, Babu, > > On Fri, Mar 12, 2021 at 01:08:11PM -0600, Babu Moger wrote: >> Hi Fenghua, Thanks for the patches. >> Sanity tested them on AMD systems. Appears to work fine. >> Few minor comments in few patches. >> Tested-by: Babu Moger <babu.moger@amd.com> > > I will add Tested-by: Babu Moger in the series and address your > comments. > > Thank you for your review! > Looks like a few patches in this series needs updates. Do you plan to send the new revision for consideration for 5.13? thanks, -- Shuah
This patch set has several miscellaneous fixes to resctrl selftest tool that are easily visible to user. V1 had fixes to CAT test and CMT test but they were dropped in V2 because having them here made the patchset humongous. So, changes to CAT test and CMT test will be posted in another patchset. Change Log: v5: - Address various comments from Shuah Khan: 1. Move a few fixing patches before cleaning patches. 2. Call kselftest APIs to log test results instead of printf(). 3. Add .gitignore to ignore resctrl_tests. 4. Share show_cache_info() in CAT and CMT tests. 5. Define long_mask, cbm_mask, count_of_bits etc as static variables. v4: - Address various comments from Shuah Khan: 1. Combine a few patches e.g. a couple of fixing typos patches into one and a couple of unmounting patches into one etc. 2. Add config file. 3. Remove "Fixes" tags. 4. Change strcmp() to strncmp(). 5. Move the global variable fixing patch to the patch 1 so that the compilation issue is fixed first. Please note: - I didn't move the patch of renaming CQM to CMT to the end of the series because code and commit messages in a few other patches depend on the new term of "CMT". If move the renaming patch to the end, the previous patches use the old "CQM" term and code which will be changed soon at the end of series and will cause more code and explanations. [v3: https://lkml.org/lkml/2020/10/28/137] v3: Address various comments (commit messages, return value on test failure, print failure info on test failure etc) from Reinette and Tony. [v2: https://lore.kernel.org/linux-kselftest/cover.1589835155.git.sai.praneeth.prakhya@intel.com/] v2: 1. Dropped changes to CAT test and CMT test as they will be posted in a later series. 2. Added several other fixes [v1: https://lore.kernel.org/linux-kselftest/cover.1583657204.git.sai.praneeth.prakhya@intel.com/] Fenghua Yu (19): selftests/resctrl: Enable gcc checks to detect buffer overflows selftests/resctrl: Fix compilation issues for global variables selftests/resctrl: Fix compilation issues for other global variables selftests/resctrl: Clean up resctrl features check selftests/resctrl: Fix missing options "-n" and "-p" selftests/resctrl: Rename CQM test as CMT test selftests/resctrl: Call kselftest APIs to log test results selftests/resctrl: Share show_cache_info() by CAT and CMT tests selftests/resctrl: Add config dependencies selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported selftests/resctrl: Use resctrl/info for feature detection selftests/resctrl: Fix MBA/MBM results reporting format selftests/resctrl: Don't hard code value of "no_of_bits" variable selftests/resctrl: Modularize resctrl test suite main() function selftests/resctrl: Skip the test if requested resctrl feature is not supported selftests/resctrl: Fix unmount resctrl FS selftests/resctrl: Fix incorrect parsing of iMC counters selftests/resctrl: Fix checking for < 0 for unsigned values selftests/resctrl: Create .gitignore to include resctrl_tests Reinette Chatre (2): selftests/resctrl: Ensure sibling CPU is not same as original CPU selftests/resctrl: Fix a printed message tools/testing/selftests/resctrl/.gitignore | 2 + tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/README | 4 +- tools/testing/selftests/resctrl/cache.c | 52 +++++- tools/testing/selftests/resctrl/cat_test.c | 57 ++---- .../resctrl/{cqm_test.c => cmt_test.c} | 75 +++----- tools/testing/selftests/resctrl/config | 2 + tools/testing/selftests/resctrl/fill_buf.c | 4 +- tools/testing/selftests/resctrl/mba_test.c | 43 ++--- tools/testing/selftests/resctrl/mbm_test.c | 42 ++--- tools/testing/selftests/resctrl/resctrl.h | 29 +++- .../testing/selftests/resctrl/resctrl_tests.c | 163 ++++++++++++------ tools/testing/selftests/resctrl/resctrl_val.c | 95 ++++++---- tools/testing/selftests/resctrl/resctrlfs.c | 134 ++++++++------ 14 files changed, 408 insertions(+), 296 deletions(-) create mode 100644 tools/testing/selftests/resctrl/.gitignore rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (56%) create mode 100644 tools/testing/selftests/resctrl/config