[v1,05/12] HID: cp2112: Don't call ->to_irq() explicitly

Message ID	20230703185222.50554-6-andriy.shevchenko@linux.intel.com
State	Accepted
Commit	b5ac00880a57273ed4d8ba6d37c91c1fd261b191
Headers	show Return-Path: <linux-input-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Andy Shevchenko <andy@kernel.org> Subject: [PATCH v1 05/12] HID: cp2112: Don't call ->to_irq() explicitly Date: Mon, 3 Jul 2023 21:52:15 +0300 Message-Id: <20230703185222.50554-6-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	HID: cp2112: Cleanups and refactorings \| expand [v1,00/12] HID: cp2112: Cleanups and refactorings [v1,01/12] lib/string_choices: Add str_write_read() helper [v1,02/12] HID: cp2112: Use str_write_read() and str_read_write() [v1,03/12] HID: cp2112: Make irq_chip immutable [v1,04/12] HID: cp2112: Switch to for_each_set_bit() to simplify the code [v1,05/12] HID: cp2112: Don't call ->to_irq() explicitly [v1,06/12] HID: cp2112: Remove dead code [v1,07/12] HID: cp2112: Define maximum GPIO constant and use it [v1,08/12] HID: cp2112: Define all GPIO mask and use it [v1,09/12] HID: cp2112: Use BIT() in GPIO setter and getter [v1,10/12] HID: cp2112: Use sysfs_emit() to instead of scnprintf() [v1,11/12] HID: cp2112: Convert to DEVICE_ATTR_RW() [v1,12/12] HID: cp2112: Use octal permissions

Message ID

20230703185222.50554-6-andriy.shevchenko@linux.intel.com

State

Accepted

Commit

b5ac00880a57273ed4d8ba6d37c91c1fd261b191

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Andy Shevchenko <andy@kernel.org>
Subject: [PATCH v1 05/12] HID: cp2112: Don't call ->to_irq() explicitly
Date: Mon,  3 Jul 2023 21:52:15 +0300
Message-Id: <20230703185222.50554-6-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com>
References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

HID: cp2112: Cleanups and refactorings | expand

Commit Message

Andy Shevchenko July 3, 2023, 6:52 p.m. UTC

GPIO library guarantees that ->to_irq() is always exists.
Moreover, it tending to become a nische thingy and has to
not be used in ordinary drivers. Hence, replace that by
irq_find_mapping().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/hid/hid-cp2112.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index fb4548feb0c8..15b626359281 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -1112,10 +1112,9 @@  static void cp2112_gpio_poll_callback(struct work_struct *work)
 
 	gpio_mask = ret;
 	for_each_set_bit(virq, &dev->irq_mask, 8) {
-		if (!dev->gc.to_irq)
-			break;
-
-		irq = dev->gc.to_irq(&dev->gc, virq);
+		irq = irq_find_mapping(dev->gc.irq.domain, virq);
+		if (!irq)
+			continue;
 
 		d = irq_get_irq_data(irq);
 		if (!d)

[v1,05/12] HID: cp2112: Don't call ->to_irq() explicitly

Commit Message

Patch