[v1,12/12] HID: cp2112: Use octal permissions

Message ID	20230703185222.50554-13-andriy.shevchenko@linux.intel.com
State	Accepted
Commit	a6a5eccc6e1d8b21c12e70cda7e15b6541e4eb37
Headers	show Return-Path: <linux-input-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Andy Shevchenko <andy@kernel.org> Subject: [PATCH v1 12/12] HID: cp2112: Use octal permissions Date: Mon, 3 Jul 2023 21:52:22 +0300 Message-Id: <20230703185222.50554-13-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	HID: cp2112: Cleanups and refactorings \| expand [v1,00/12] HID: cp2112: Cleanups and refactorings [v1,01/12] lib/string_choices: Add str_write_read() helper [v1,02/12] HID: cp2112: Use str_write_read() and str_read_write() [v1,03/12] HID: cp2112: Make irq_chip immutable [v1,04/12] HID: cp2112: Switch to for_each_set_bit() to simplify the code [v1,05/12] HID: cp2112: Don't call ->to_irq() explicitly [v1,06/12] HID: cp2112: Remove dead code [v1,07/12] HID: cp2112: Define maximum GPIO constant and use it [v1,08/12] HID: cp2112: Define all GPIO mask and use it [v1,09/12] HID: cp2112: Use BIT() in GPIO setter and getter [v1,10/12] HID: cp2112: Use sysfs_emit() to instead of scnprintf() [v1,11/12] HID: cp2112: Convert to DEVICE_ATTR_RW() [v1,12/12] HID: cp2112: Use octal permissions

Message ID

20230703185222.50554-13-andriy.shevchenko@linux.intel.com

State

Accepted

Commit

a6a5eccc6e1d8b21c12e70cda7e15b6541e4eb37

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Andy Shevchenko <andy@kernel.org>
Subject: [PATCH v1 12/12] HID: cp2112: Use octal permissions
Date: Mon,  3 Jul 2023 21:52:22 +0300
Message-Id: <20230703185222.50554-13-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com>
References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

HID: cp2112: Cleanups and refactorings | expand

Commit Message

Andy Shevchenko July 3, 2023, 6:52 p.m. UTC

Octal permissions are preferred as stated in
Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions
with octal permissions when creating the files.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/hid/hid-cp2112.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index 3c6a3be8fc02..adbe8a47cf67 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -175,7 +175,7 @@  struct cp2112_device {
 };
 
 static int gpio_push_pull = CP2112_GPIO_ALL_GPIO_MASK;
-module_param(gpio_push_pull, int, S_IRUGO | S_IWUSR);
+module_param(gpio_push_pull, int, 0644);
 MODULE_PARM_DESC(gpio_push_pull, "GPIO push-pull configuration bitmask");
 
 static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
@@ -1057,7 +1057,7 @@  static void chmod_sysfs_attrs(struct hid_device *hdev)
 	}
 
 	for (attr = cp2112_attr_group.attrs; *attr; ++attr) {
-		umode_t mode = (buf[1] & 1) ? S_IWUSR | S_IRUGO : S_IRUGO;
+		umode_t mode = (buf[1] & 1) ? 0644: 0444;
 		ret = sysfs_chmod_file(&hdev->dev.kobj, *attr, mode);
 		if (ret < 0)
 			hid_err(hdev, "error chmoding sysfs file %s\n",

[v1,12/12] HID: cp2112: Use octal permissions

Commit Message

Patch