From patchwork Sun Nov 13 03:30:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 624501 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 848BCC4332F for ; Sun, 13 Nov 2022 03:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235138AbiKMDal (ORCPT ); Sat, 12 Nov 2022 22:30:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235125AbiKMDak (ORCPT ); Sat, 12 Nov 2022 22:30:40 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B780013DF7 for ; Sat, 12 Nov 2022 19:30:39 -0800 (PST) From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1668310234; bh=2gTkiOcwRu1rvtsieSB6uYYfG6KwpnDzYJ7VI3RNyQA=; h=From:To:Cc:Subject:Date:From; b=b+WhP7YAnAS8pr7aHdB3Jd89kWdSvdLDW7JXO+7p6QDkJPFCKHIeablhfi6hZJVAk aUPJmiokBqqZEYesqNT2f2QNOEsfiRhZ0byPrg7N8FzHSxPzcBp0KmR5X8OuA1+k0/ qh3BCMAbMS2ky54HSMU/PAH9kuVRnT3Xx/bcUyf8= To: Benjamin Herrenschmidt , Dmitry Torokhov Cc: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] macintosh/mac_hid.c: don't load by default Date: Sun, 13 Nov 2022 04:30:22 +0100 Message-Id: <20221113033022.2639-1-linux@weissschuh.net> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1668310220; l=1025; i=linux@weissschuh.net; s=20211113; h=from:subject; bh=2gTkiOcwRu1rvtsieSB6uYYfG6KwpnDzYJ7VI3RNyQA=; b=/j6qqxCFitLVms6T0bo554pD1PYuGU4fej2PB1Xt0KyhqBLYFyNUkX4SOqLu/KdIPnSZhFsqjkBg 3h1eojjyBbDRrxOrzFCCOvAKyxqK+6wbQJaNfxQj6LsvS1MZuqjR X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=9LP6KM4vD/8CwHW7nouRBhWLyQLcK1MkP6aTZbzUlj4= Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org There should be no need to automatically load this driver on *all* machines with a keyboard. This driver is of very limited utility and has to be enabled by the user explicitly anyway. Furthermore its own header comment has deprecated it for 17 years. Fixes: 99b089c3c38a ("Input: Mac button emulation - implement as an input filter") Signed-off-by: Thomas Weißschuh --- drivers/macintosh/mac_hid.c | 2 -- 1 file changed, 2 deletions(-) base-commit: fef7fd48922d11b22620e19f9c9101647bfe943d diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c index d8c4d5664145..d01d28890db4 100644 --- a/drivers/macintosh/mac_hid.c +++ b/drivers/macintosh/mac_hid.c @@ -149,8 +149,6 @@ static const struct input_device_id mac_hid_emumouse_ids[] = { { }, }; -MODULE_DEVICE_TABLE(input, mac_hid_emumouse_ids); - static struct input_handler mac_hid_emumouse_handler = { .filter = mac_hid_emumouse_filter, .connect = mac_hid_emumouse_connect,