From patchwork Wed Aug 18 15:27:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Junghans X-Patchwork-Id: 499206 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB0FC43214 for ; Wed, 18 Aug 2021 15:28:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE5F661076 for ; Wed, 18 Aug 2021 15:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239608AbhHRP3I (ORCPT ); Wed, 18 Aug 2021 11:29:08 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:18180 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239494AbhHRP3I (ORCPT ); Wed, 18 Aug 2021 11:29:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1629300506; s=strato-dkim-0002; d=inhub.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=IK99A/GynHBsNekMV/T4efD0GVoEvLYRB6wYA/qAU0k=; b=AvJtHJWRHaTfTnbwda80QOtZddUK19id620jzB3p+bdTYFuSTd2Qf3QpM1Pa7ZMSps YgDXXFx1oo2UXPOdPsK/NQ/Yizk+I5jVJagv/vyLywDe3YP4wuqDL04Q1/5lcLcFYni2 VPZ6stANe6kjgfPDDLS8QwPQ9QVjJuwRNZSBGNxXnPF+REX504DCM0k4MjHD43/K8aVe rySpMLwfgEI9EG3g4YyXBHCSgeiaTV/VyHZ87xD4RaghwhYc1Swm1QQtjpPpK8WPmNXd NIFNgXQhxSrCleOH0VHVKLTMH2/ln64m9SvK9td1mdXKXgpgvEuG7uPtMakEylWqBdiS WAIA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":OGMGfEG7NfU1WQAxQKSndOy9b62IXRUXP1G+n0e9SfNgfKKxghMZpWooHBd6LckRo6Cg2ToZyvlfQhM6" X-RZG-CLASS-ID: mo00 Received: from crypto.lan.inhub.de by smtp.strato.de (RZmta 47.31.0 AUTH) with ESMTPSA id k00d02x7IFSQq0C (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 18 Aug 2021 17:28:26 +0200 (CEST) From: Tobias Junghans To: linux-input@vger.kernel.org, Rishi Gupta , Jiri Kosina , Benjamin Tissoires Cc: Tobias Junghans Subject: [PATCH 1/2] HID: mcp2221: enable HID I/O during probe Date: Wed, 18 Aug 2021 17:27:42 +0200 Message-Id: <20210818152743.163929-1-tobias.junghans@inhub.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org devm_gpiochip_add_data() calls the gpio_chip->get_direction handler for each line, resulting in device I/O in mcp_gpio_get_direction(). However unless hid_device_io_start() is called, mcp2221_raw_event() is not called during probe, causing mcp_gpio_get_direction() to time out. This fixes that probing takes 12 seconds to complete. Signed-off-by: Tobias Junghans Reviewed-by: Rishi Gupta --- drivers/hid/hid-mcp2221.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c index 4211b9839209..8e54173b195c 100644 --- a/drivers/hid/hid-mcp2221.c +++ b/drivers/hid/hid-mcp2221.c @@ -895,7 +895,10 @@ static int mcp2221_probe(struct hid_device *hdev, mcp->gc->can_sleep = 1; mcp->gc->parent = &hdev->dev; + hid_device_io_start(hdev); ret = devm_gpiochip_add_data(&hdev->dev, mcp->gc, mcp); + hid_device_io_stop(hdev); + if (ret) goto err_gc;