From patchwork Fri Mar 26 14:34:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 409488 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1488706jai; Fri, 26 Mar 2021 07:35:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznSCD3/hM6L7cMcl2q1joBVK4HAzS3O+gQUlx2bbJk3gU5/JjPSlzcsyx2EDgn8EKjj+k0 X-Received: by 2002:a17:906:8447:: with SMTP id e7mr15966296ejy.523.1616769350332; Fri, 26 Mar 2021 07:35:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616769350; cv=none; d=google.com; s=arc-20160816; b=Hwqu57SxXL4TwwUXzsSE4iF6uKCGHv109M3rlMPFgdkCHX3QWF7BdXp2va6G2koVx5 uDEBcnz3zhpJenML4Um+cCQt8pXfXOUUd6n1sHo6DqCQcp1fz36IX9QHOXeGQEtOoHUO t9yBgfB9uRk0kB1+TGRKhz/KHCVJFxtNYmQr5GZxKCoF1BV5z6ZI5VpfJI3l2nP+u1aN OasqtxO7cgytbMInFauPW9T4E3pJN979ZUkDSUKwFR6PqxE4CNkRafkDRj7t7WAho3Ol EBswxClTrQJIHSElorj0YvZcJZ4LaiVAwI4am3MxSRi/4q1lCjqgNf7zrmUpzc7ghZaq Z6NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KY+ot5dzoWxg13y22fAr16+A3Tqxw//rMDzqbWyDuaI=; b=0x7nrdvCXydDQh7TiUTeWYMdg+cyO0Gqqg4YN0Gk4eqsPV4iKY/umypGAGMlihLiaX uldmPsHanIe/hnAS7b7OsmJmiOfZAAgTrnsgF7Q18Y3IR4jOwZSNrS/70ZQR9Jfa5mzk hi9Ca+hVhGoeDrz/Lw+6HI9uFVtuffc1RRRpLsM40kdoqCdmEADy0CPxeIObrmIzR8av ceg/GgUpU3n6RHkp8li1J0iCZfPvYhg5/3BwF7sJqLEdCLxnNIeo4cZa8tejkA4eHQvl E00uXit/xfm7yQpvI7NodihEMhbFp5qdtPtmAbS88eBA1Wdw0Yqlt7Zf/FJ+8x6uiYm6 irvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="e5yd/uey"; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si2126144edz.7.2021.03.26.07.35.50; Fri, 26 Mar 2021 07:35:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="e5yd/uey"; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbhCZOfR (ORCPT + 1 other); Fri, 26 Mar 2021 10:35:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbhCZOfI (ORCPT ); Fri, 26 Mar 2021 10:35:08 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81084C0613B2 for ; Fri, 26 Mar 2021 07:35:07 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id b9so5844998wrt.8 for ; Fri, 26 Mar 2021 07:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KY+ot5dzoWxg13y22fAr16+A3Tqxw//rMDzqbWyDuaI=; b=e5yd/ueye/lKJH2c40Aeqvr4G3DXwcpQzPjCIFfr+s2BV+TGCk/I5W7r/K4w4+fRoQ gxklrV/kmFnk5mbKiUJ63f3wXyZ7woUvAgUKsEy2o/nFdNTYqleS5DwBCi4dlosL++GA 3M7XHNlHMN/O5wAM1P0ITL+WgqCMdeIhvcGr1O5uensGqZxrASHEj7FFFHTPbV2oTzln wiXx5JVb53jeR+3+RS8vA0gbIztp8rlQ8GQipYoh1c5B20MDfImhvf3Yjn+NdkqsWLHV XEZoGMnu92awWzJ+df0f0UOClWcz7vpbYwmpn1pVwD2SdZ3uTGs8DDUBUWf13Qss+iKk wpAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KY+ot5dzoWxg13y22fAr16+A3Tqxw//rMDzqbWyDuaI=; b=IaKsU2QZ4mFj4kGAkUVS1sV90uEaoJwoAeOLUQv2U0nYvFLvyGGq5kxMs1wq64YoZ4 bYaRBDDD4lz6h3jbZoGrMGfDOYXjdxZZpLMAE6F3zHdLglOhjKHFxRomFEOXmATE/Zc3 iIAKfyKM0b4I0btOZBmQtdQNgy4RrQZDdJ2AX/vZs3ieSMpMOfY00wc9tK8OnS/BZeIX I18ffSisNS5bLxceqoCw9KlxgXqCPSOnl5E3i7twD1C+ZUmDzyiI70YJ0EyFukJqNj4G SSW2kEyrkRMjTFVhFr1JR6qPWAnpHYNbYXqEpMpPlZSCLYznG1aVb0uRducyZvBJIxGE +UWQ== X-Gm-Message-State: AOAM53367R7G00b3B6CJWKa38WQBv1AtnBZq5DT3D7V+dTtKlTEaVnnX +KFB0rIWmCKEEowO5M78xg3JnQ== X-Received: by 2002:a5d:6092:: with SMTP id w18mr14806536wrt.52.1616769306280; Fri, 26 Mar 2021 07:35:06 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:05 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-input@vger.kernel.org Subject: [PATCH 04/25] HID: intel-ish: Supply some missing param descriptions Date: Fri, 26 Mar 2021 14:34:37 +0000 Message-Id: <20210326143458.508959-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/bus.c:173: warning: Function parameter or member 'fw_client' not described in 'ishtp_get_fw_client_id' drivers/hid/intel-ish-hid/ishtp/bus.c:845: warning: Function parameter or member 'device' not described in 'ishtp_device' drivers/hid/intel-ish-hid/ishtp/bus.c:858: warning: Function parameter or member 'device' not described in 'ishtp_get_pci_device' drivers/hid/intel-ish-hid/ishtp/bus.c:871: warning: Function parameter or member 'cl_device' not described in 'ishtp_trace_callback' drivers/hid/intel-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "Uwe Kleine-König" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp/bus.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.27.0 diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c index ffc9ce5c86ee6..c1c7d5356208d 100644 --- a/drivers/hid/intel-ish-hid/ishtp/bus.c +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c @@ -164,6 +164,7 @@ EXPORT_SYMBOL(ishtp_fw_cl_get_client); /** * ishtp_get_fw_client_id() - Get fw client id + * @fw_client: firmware client used to fetch the ID * * This interface is used to reset HW get FW client id. * @@ -835,6 +836,7 @@ int ishtp_use_dma_transfer(void) /** * ishtp_device() - Return device pointer + * @device: ISH-TP client device instance * * This interface is used to return device pointer from ishtp_cl_device * instance. @@ -851,6 +853,7 @@ EXPORT_SYMBOL(ishtp_device); * ishtp_get_pci_device() - Return PCI device dev pointer * This interface is used to return PCI device pointer * from ishtp_cl_device instance. + * @device: ISH-TP client device instance * * Return: device *. */ @@ -862,6 +865,7 @@ EXPORT_SYMBOL(ishtp_get_pci_device); /** * ishtp_trace_callback() - Return trace callback + * @cl_device: ISH-TP client device instance * * This interface is used to return trace callback function pointer. * @@ -875,6 +879,7 @@ EXPORT_SYMBOL(ishtp_trace_callback); /** * ish_hw_reset() - Call HW reset IPC callback + * @dev: ISHTP device instance * * This interface is used to reset HW in case of error. *