From patchwork Fri Mar 26 14:34:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 409501 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1489244jai; Fri, 26 Mar 2021 07:36:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYObFNeXBScnkMKzhrA72tFTqAzoeC5CTb6n2kE5NBHPCfWJLCh83OkEaXvKb8E8iZUG94 X-Received: by 2002:a50:fd8b:: with SMTP id o11mr15380077edt.346.1616769384954; Fri, 26 Mar 2021 07:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616769384; cv=none; d=google.com; s=arc-20160816; b=kL5bFOYqVu4MB5VuU6AzmyxJgetxxdrZezmH6zC4op0949mrw3C4+zwYozlMmohG+2 zuTqJe301lC3GGEDW8juyF3ZNNkwDDHvFM5xVcAGAEznWKlv5ZgEgq+Kx4pf86spotPq iQCh5NycTXDoPUZa8jZUcMpyzSS+2YixSBJcoG139oQ8ERxefa6SKhyPK1SR+SiixdTB Immdy3WtbpVEGj+0j05Yvoj/tC+4kEoWEvsJwvzerePP6ooWVIsdRrRtXeOZYq8vEL1T edlzzhuP760McSYpdyixuQYQQrb8JRcG3viUE5r0exESPnjislti+SZy7K2vmmVnhWec hdYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NvG+DHxLWGqXLwCLHTxA35O2VaR78VX0X5hX1fU7v18=; b=PWlmsVLbHdKhaHLrfOJLWWThF1w3CfcXQK9g9Uja8VTMexoJ2e9ciE1YvSoI2SE8FD uUFoLadP/Yjy9dfXPRjmFGt6TUKZPtukHI6rNp5vLzsGZICFSFjUSheEelpMMPx5cvQY 6rFV9ndiClxMumIwRFuhDUTIhI6K8X8gh+P2hJLNNgAsKxElLJNkuLg7MIcNsqAOcD1g ZNR2uqUkDE0daH/Ul2BSIcFbVYTQ8WTW+CZIiBQwcMlqmSB7Q7bJHF30hoC5d/XAKim9 yE47E5NTEp3XFoy74037usBzXIKfdi9nsqF/Ud1hF66sgJ9oSgrJbU+F4JANzkv66DBi Ag8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rhuQcSAm; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si2126144edz.7.2021.03.26.07.36.24; Fri, 26 Mar 2021 07:36:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rhuQcSAm; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230465AbhCZOfz (ORCPT + 1 other); Fri, 26 Mar 2021 10:35:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbhCZOfS (ORCPT ); Fri, 26 Mar 2021 10:35:18 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C315C0613AA for ; Fri, 26 Mar 2021 07:35:18 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id j7so5896143wrd.1 for ; Fri, 26 Mar 2021 07:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NvG+DHxLWGqXLwCLHTxA35O2VaR78VX0X5hX1fU7v18=; b=rhuQcSAmr2qobE5MLtzwGEi0Lr/Y4/8iBHF839/53MF2Y9lFQ8GQCe+x75wrZgsaAb LMgYAGmQsYZiHJpvm/vSh8fcstZ+DFoaGyOUuXaT0cP+EsWE1v4/JdDHvgDy+DOYGv5M YYcUQfeJq1REa1KWNc+wm6CuQbE9ZF5o79O0SwBP2m3L9QLTrcO1HVJPhQbXEY7pJ7qW 3jprm3kXueIE5fFH1JsBSfeNzWZTnvfbivyVhNtP1bANq+VAhso2JPqVVREHvmNpEwfE +unXLRSzUoiys9tWkPjK4aKv0SmMFZBvt96R9lTaj4rHBbpeNVu2PZlfevGLXEkVaKqJ pdUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NvG+DHxLWGqXLwCLHTxA35O2VaR78VX0X5hX1fU7v18=; b=gZaikoREBhmKEc+nTPzDAHtMTGC4pLboIi5vmw2SyezbwOHzBLNJQdaE90/1bDaQER IVJ5W4UzVUauhvSJy5ExmP+7OoixmrulapzCenFqvOLhmW++Q/oWP9y4dbZm1adjPO/T egdNPmXWZvKsaeoLvoi7/8OWv5+BoVhx2tAZOcQINiRgZBdUwrfOxX1oGV4MC3gzuWbM rEuAUH5d2ylGX8S+kWnktuovvzaCA1pxgW3xOzHXmotXs/NHskxTZkhDphODZkt8+Lr/ H47vmqO9vyEuvjfFsHtcJcjXRoNu7rMzVoidyWx9kW7sKCX2SJJlTSKIepMpn0DPYu+N DYeQ== X-Gm-Message-State: AOAM533PBYao+hTtalRLrIc+6aR+VGG7ejo9R5ojBEKmdQalXirt4xr1 6njw0zQVrhV5fKNhuUI7gcZcmA== X-Received: by 2002:a5d:4688:: with SMTP id u8mr14801801wrq.39.1616769316887; Fri, 26 Mar 2021 07:35:16 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:16 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Bruno_Pr=C3=A9mont?= , Jiri Kosina , Benjamin Tissoires , "L. Vinyard, Jr" , linux-input@vger.kernel.org Subject: [PATCH 15/25] HID: hid-picolcd_core: Remove unused variable 'ret' Date: Fri, 26 Mar 2021 14:34:48 +0000 Message-Id: <20210326143458.508959-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-picolcd_core.c: In function ‘picolcd_raw_event’: drivers/hid/hid-picolcd_core.c:332:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: "Bruno Prémont" Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "L. Vinyard, Jr" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-picolcd_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.27.0 diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c index 1b5c63241af05..bbda231a7ce30 100644 --- a/drivers/hid/hid-picolcd_core.c +++ b/drivers/hid/hid-picolcd_core.c @@ -329,7 +329,6 @@ static int picolcd_raw_event(struct hid_device *hdev, { struct picolcd_data *data = hid_get_drvdata(hdev); unsigned long flags; - int ret = 0; if (!data) return 1; @@ -342,9 +341,9 @@ static int picolcd_raw_event(struct hid_device *hdev, if (report->id == REPORT_KEY_STATE) { if (data->input_keys) - ret = picolcd_raw_keypad(data, report, raw_data+1, size-1); + picolcd_raw_keypad(data, report, raw_data+1, size-1); } else if (report->id == REPORT_IR_DATA) { - ret = picolcd_raw_cir(data, report, raw_data+1, size-1); + picolcd_raw_cir(data, report, raw_data+1, size-1); } else { spin_lock_irqsave(&data->lock, flags); /*