From patchwork Thu Nov 26 13:36:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 332964 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp151255ejs; Thu, 26 Nov 2020 05:37:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/u74CDNBE2Xjn5AswJ9+Fa3TsKg52WCiTtVpHupjLGFj4IgWxaTJNNVHXpDuxG4o0aeYd X-Received: by 2002:a17:907:3f93:: with SMTP id hr19mr2836658ejc.235.1606397865230; Thu, 26 Nov 2020 05:37:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606397865; cv=none; d=google.com; s=arc-20160816; b=r4K2y/9UUKEA+dSR/3jUftRjYuUYCG6/J3mIx/wYYCEDYKmQ6BVQhyAF0SFJ/TafE+ 3cxLOYPS5nNY4gy4jVKr6MPuFK1IaxvYkbmDuKQT7yI6pWXFotFl6mdNMQJ7utdHIg17 Tqb5YeXvnCGPqVOsU+BVw9OTAugzT9i71XIPovsvYge/fNbshR0Csn+9WOKscwCzXMjg Yyyw+5Et5leMLKKIBm2TavpwkOzZ78we7RrO3AalQJF+CFQQyHmoHDsDgbAtAAD0/kse Q2ED5GaGwjhTuN2PGGjkRTIJu8IlvUVh/wuRSqJNow3DK77dEHO9trliJ1m9lNcG5Y98 7fCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cUSIVImOhh6mnD33JdJKn9l+xD1dBbES1ADQWyw/cSQ=; b=J8zflsHNgEXAws0vn98RlM6Z+hgphNCZaITBn1TSpXZQuphoSIfBDXrkwtaZWKIrCc G5/JJrhNdJUy0Mgwe6VHQB9v2LEdbTG9lxYbkl8Rl71a9jV0ce4qlt67hd6xUsWJjLxL F5UfbPzTtvIhFo2pkzh4ygYvfoWzbi1jv8uJ+CFcHFbJHxAWCzboo3BG3Jt8kepVpqWI OcFFX2S7MLKoy3DlJ4Izea87SRw8Ho3hZvOX7vhsYugkMq1gbGQjFl7k14kNNzc2GehJ +0ncriS0ohfN+h6F7/oX55LlHo/9J1Qix8pjz8W3GHVZGUzK8XBHM9vT0L/v3mxtdL4v Mo3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g6zRzVGz; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si3080863eju.318.2020.11.26.05.37.45; Thu, 26 Nov 2020 05:37:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g6zRzVGz; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390337AbgKZNgQ (ORCPT + 1 other); Thu, 26 Nov 2020 08:36:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390128AbgKZNgQ (ORCPT ); Thu, 26 Nov 2020 08:36:16 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89FB4C0613D4 for ; Thu, 26 Nov 2020 05:36:14 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id 23so2166696wrc.8 for ; Thu, 26 Nov 2020 05:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cUSIVImOhh6mnD33JdJKn9l+xD1dBbES1ADQWyw/cSQ=; b=g6zRzVGz9G1rkRBJxu5GSPNOBBUME2NZh6JpVJ0XbDF3pkN9YxfMue8xN524DY45wu Sp8DJn8yglGxMUVUM5GPZG5fg0igrw2+z38ejyPzdWeA6TxVMyH1JIGNbMgnw2MGMadV mepdLcyL/Cl1BRZNhQ8AhJAj88El5PDv3BRgRpdh4Pvrz3vVqJmiycHkmr61VYJGs8M1 3ySiuhIsQY8pQtlu3LQCrXxbvmjdS86FMsGMUahPRdEk2egdpZC1087da1lo459fWCoX qwwUH7ysRR4lYdn2qE7iY9fwvdhf3d0MC0BJ7vHqLvMXTlHcqbl+iltinxppF5bya/78 rVNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cUSIVImOhh6mnD33JdJKn9l+xD1dBbES1ADQWyw/cSQ=; b=uKX/qzso54tgvSmG8Nol0h4YyzWnddaIzg+80NILqFGRHeMQ+00l5ehCP+nePlq+uC 8u/EnsE+JMtwbOQOTMUmMJjU7DOlrWzv351p9N1euLmqaFAckta3fSeG4yOEewMPMDNV UPy+VhmKFw9Oh3c4iGDMv05iwrPn4uLlxD8avG7sfCVlVNpllgDZrENDjZIfNcgyqvZq c+y15nXzcGhF46miPqxXFc7BhveY6Uskb9/g8lEeUGasm7t1nhqLHbc9XUgvqmJ6z/Bi 8NRcHXDM649qImrLK82+wOoEN9ChtQw5LEuy7YVNwHfQbQTk4VrALPp1Kl2xtEBZtEsJ uL1A== X-Gm-Message-State: AOAM531C7OfafoPIquUDKsF7oYNWsdFlwJnr3/zMJWuWheEaVoYp0Wd8 osDvvhMjylvmm+8ulEE72y/JUg== X-Received: by 2002:adf:dd09:: with SMTP id a9mr3919342wrm.128.1606397773337; Thu, 26 Nov 2020 05:36:13 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id l3sm9056280wrr.89.2020.11.26.05.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:36:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Peter Osterlund , Stefan Gmeiner , "C. Scott Ananian" , Bruce Kalk , this to Subject: [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary Date: Thu, 26 Nov 2020 13:36:04 +0000 Message-Id: <20201126133607.3212484-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133607.3212484-1-lee.jones@linaro.org> References: <20201126133607.3212484-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’: drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Peter Osterlund Cc: Stefan Gmeiner Cc: "C. Scott Ananian" Cc: Bruce Kalk Cc: this to Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/synaptics.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 8fb7b4385ded9..3cc8b76629fa2 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -1106,8 +1106,11 @@ static void synaptics_process_packet(struct psmouse *psmouse) num_fingers = hw.w + 2; break; case 2: - if (SYN_MODEL_PEN(info->model_id)) - ; /* Nothing, treat a pen as a single finger */ + /* + * Keep defaults + * + * SYN_MODEL_PEN: Treat pens as a single finger + */ break; case 4 ... 15: if (SYN_CAP_PALMDETECT(info->capabilities))