From patchwork Thu Nov 12 11:01:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 324164 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp237854ils; Thu, 12 Nov 2020 03:05:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJxoUu09nCYYZRX9mtMlLiIK6C9q27DqXEVPbQdXNcZFtg35v/zej95Mp9vJx6+2RNVBgi67 X-Received: by 2002:aa7:c7cf:: with SMTP id o15mr4239663eds.15.1605179115064; Thu, 12 Nov 2020 03:05:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605179115; cv=none; d=google.com; s=arc-20160816; b=nrx5rEsBJyy5oLFnurxXJKje+Aicts1hFhTANtsPzTnymI8HVttHFVa3GG6vI9QYLz 86BlgbsjR1+Oyw9xaXdZq4VtQ3II5cMTQct+F+Bmh7LXqrVgW2AEq9Cq7dwi428jbag/ lZDctqAj1p4f1k6otePe+2nzkn7IWxPzvVUMa3+2tD6tPqpScYiVCf+iFv/C2LjFz3hb pRQmM1hGbhCeYDuWlzga1YCRNd58VQlydtCGcckVVkpWdeRSTUJMzc4Hq1bBDewrlu1O mwca0yUb4Nud3sYTeUUC1w/EHDQH2Ia261pxLLPJkuwlfP/m8kkNxpobgh3wUbPkPwfx sckQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CMYg6E1kdXm+yD+hzGnKjz5iwy/O1uttWSB8VdrwJX0=; b=mXWt0B7vxPjIlT7qebpiwFhJzWwD/OKkdjiw/5r1h1cB0HIJUTGpRupjNKTlLiN8Ax 83T2p5zFM8EocNoprumjNSkTfD7tBlusp0Ibh3JwnE2QBiZlPGAA/UBEZT57QISlTmdb yVQwb2TWDfVKofqHlTAJhiJUeXHXiZ/mwQDaqXYRSnR9XXk+WgoIMV5MRYhJsSmQHJop pEwlFTTTmlbOPmX0Kc5OXA93sYvowGhvsxjQDKQT6kq+3LjyZRZEu2FB2tbNw8fvceqG dNtwr8nqF2LSCT40pmcpyIqXwsjAxmshTJPFsVG0IMY3bxUiccIYTAYnAGnSyTJscnWu 5EhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FvWUQgKM; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si3596547eje.596.2020.11.12.03.05.14; Thu, 12 Nov 2020 03:05:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FvWUQgKM; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728054AbgKLLCR (ORCPT + 1 other); Thu, 12 Nov 2020 06:02:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728031AbgKLLCP (ORCPT ); Thu, 12 Nov 2020 06:02:15 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC10DC0613D1 for ; Thu, 12 Nov 2020 03:02:14 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id h2so4912511wmm.0 for ; Thu, 12 Nov 2020 03:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CMYg6E1kdXm+yD+hzGnKjz5iwy/O1uttWSB8VdrwJX0=; b=FvWUQgKMGClbxDUBdDyFjYlNDA1equD1xQMofMZntHFfIbfP4hqtgwFLYvsptlVHFp Aa1NGY3qFY0Jl10yCtnWfMq+ZoBMV4QLooxXfoCOy7mnrXWc7Urytan4kp5KKKwb9Usu LQCmz5T/bOg/MxxcYK5bq/HlGRONtHdo8DdjAsIf/gWDsqyENToN6DlsU+BL9Ol4Y5xO zTz9QsOGi30CLJ7jVaoddpKsC1cxoevAlUDfazrWUQs+TKJ+JJH56sepfrWKDi31VXiI qE5yzjYN3ApWdzebtlLXQ96ZKNunUjbulNfTxUr4TA0fAT6M3Ar/VFNlIBuOfXBC0PrH pIsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CMYg6E1kdXm+yD+hzGnKjz5iwy/O1uttWSB8VdrwJX0=; b=r6TGMPO6/dfm8pUPLD+DevITOawpa0NvoX547LpeIh91T904e7ZfFb+NqtYPuz/m6X BQpRJwis0m9nOQGd4QCVIgaZhW1x2029b/uM39BUGpEXJeeCnhcHQaVwlOppXu/eAqnq qVUb4LK/XXPOhLVfnpUInA7QXqC31MhC6SgHTbZv2Us4KJbGozxHuIA3w4mT6XX5P4gU jZnNYkbOmO3j+7mdNQ9iHR1rbh97f00fKSQM6aa3LKpjgiWuMDS/8G3WRIzEmp1j9B/v kRtY4lzbNi7oUwJ+P/9eb9a1aEW8sUoTLaIdPaGNVvg7YX1MoA/xK2T/KWL7HnPNtt2w BopQ== X-Gm-Message-State: AOAM533FmT2XI2DgKETfE96CZ0XBgaRRpXt0oFtR18sm4avOA69PPybj p7tqAdazxTNvLbU8OWuqAFLrGDiTD8ygaZFd X-Received: by 2002:a1c:df04:: with SMTP id w4mr8918637wmg.3.1605178933396; Thu, 12 Nov 2020 03:02:13 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bastien Nocera , Dmitry Torokhov , Henrik Rydberg , "K. Merker" , authored by , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 04/15] input: touchscreen: goodix: Provide some missing function parameter descriptions Date: Thu, 12 Nov 2020 11:01:53 +0000 Message-Id: <20201112110204.2083435-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/goodix.c:569: warning: Function parameter or member 'len' not described in 'goodix_check_cfg' drivers/input/touchscreen/goodix.c:587: warning: Function parameter or member 'len' not described in 'goodix_send_cfg' drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'cfg' not described in 'goodix_config_cb' drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb' drivers/input/touchscreen/goodix.c:1165: warning: Excess function parameter 'ts' description in 'goodix_config_cb' Cc: Bastien Nocera Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: "K. Merker" Cc: authored by Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/goodix.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.25.1 diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 02c75ea385e08..80a82a66a0f3b 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -564,6 +564,7 @@ static void goodix_calc_cfg_checksum_16(struct goodix_ts_data *ts) * * @ts: goodix_ts_data pointer * @cfg: firmware config data + * @len: config data length */ static int goodix_check_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len) { @@ -582,6 +583,7 @@ static int goodix_check_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len) * * @ts: goodix_ts_data pointer * @cfg: config firmware to write to device + * @len: config data length */ static int goodix_send_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len) { @@ -1156,6 +1158,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts) /** * goodix_config_cb - Callback to finish device init * + * @cfg: firmware config * @ts: our goodix_ts_data pointer * * request_firmware_wait callback that finishes