From patchwork Fri May 8 05:56:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wang, Jiada" X-Patchwork-Id: 207850 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF072C47247 for ; Fri, 8 May 2020 06:00:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6ADB20736 for ; Fri, 8 May 2020 06:00:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728307AbgEHGAE (ORCPT ); Fri, 8 May 2020 02:00:04 -0400 Received: from esa1.mentor.iphmx.com ([68.232.129.153]:38783 "EHLO esa1.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728301AbgEHGAD (ORCPT ); Fri, 8 May 2020 02:00:03 -0400 IronPort-SDR: 9I7VdDF1VzIfm6kdWbjaIG4FKAKqM7nT+8b9o8e8V9RXG91aJ01fybEXHTZhIYsxagZBwzmH/T Tm42fDRa81Ed4qH/lZel3MM971cGVe2fRn03WqAznw+9wUu48UCnQmowzhs/qTtwlIAtdo5hzC kXPcxupwlBJj2YSX0XWKbsOyQP3g8X8F1kq1vNdnY4/NC5RkBDTSOhBooqlBV9hatrwwoAhlrB TGzqWXdHR//Ox8juQyJkW5puMHZRWDzHR/FLD5B2kk76bEH60S7gF9qYOGCnu1BwB+nGrTayD4 yIo= X-IronPort-AV: E=Sophos;i="5.73,366,1583222400"; d="scan'208";a="50670152" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 07 May 2020 22:00:01 -0800 IronPort-SDR: Gisp1ek7G0L716U9x5yQZge7TL6zYKgwRZq31Ly7lUh7nBbgfYulJgo32tc3aNoPkJM1V5pgtZ 6SA8cr0McrI93vhnAaAFyoOQ3wMWqGXi2D2szPvgmJ4nLjuF1smwp+pdXUVjpbz0mP26/h9k/w 7SL1OtAicfbxg/IxNlvJkF3XAfS1Dx6Lk8qDEiog/ywdXJp9ajuPboes+jgE4zu9/trRJkO9Fk SA0n0PDn2iMbGwF3NpfFjNTd3maGEDqmkGgqfNtNLuqSdfZOXNGVOW1mSqKwS+8S855aavBEGy UC0= From: Jiada Wang To: , , , , CC: , , , , Subject: [PATCH v11 48/56] Input: Atmel: improve error handling in mxt_update_cfg() Date: Thu, 7 May 2020 22:56:48 -0700 Message-ID: <20200508055656.96389-49-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508055656.96389-1-jiada_wang@mentor.com> References: <20200508055656.96389-1-jiada_wang@mentor.com> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index c779cac565a8..83fa2caddeab 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2172,7 +2172,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem);