From patchwork Wed Feb 12 08:42:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wang, Jiada" X-Patchwork-Id: 208203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64988C2BA83 for ; Wed, 12 Feb 2020 08:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4178F20714 for ; Wed, 12 Feb 2020 08:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728533AbgBLIrM (ORCPT ); Wed, 12 Feb 2020 03:47:12 -0500 Received: from esa2.mentor.iphmx.com ([68.232.141.98]:5140 "EHLO esa2.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728544AbgBLIrM (ORCPT ); Wed, 12 Feb 2020 03:47:12 -0500 IronPort-SDR: fOy+vc4Ykexg2rAn6t6sQkNfPHvzThpPXw6PxvNBfTtRu7wk/WjDS1Dxl9pRXrTUE9am4q7bMT ay8z1X/aNFZwlNi191v9qKQCQReddtiFBzev8tF8ZR+8KckmhR58UcKVINiOcNsvxvEDJb6oEp U4+Xzjfin/u4Dyb3TC1vjsa08xmOuIV2dM6Lmet8kv6ngpgolG93WvIg8OGLcfm/5XiJcX1ffJ zucVErb9SDWsZcgMjY2oYzbvwr4Qikl3MrtW9mCtMSjRKWQ68H8MLqd0hOna2QsJRxOhmZZWYq dic= X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="45686299" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 12 Feb 2020 00:47:11 -0800 IronPort-SDR: OPjzyoNIehf1LkwreltCylrx4xOql3bqx2e5u85F6EwqZlt+QYDwNVjI07oOc/s50PF9QMleG8 kRjQK4bhs8/DAVqaQXmsWbNx2uGR0DTmx0VVFS6tzc33KsJc7CsEZmwzJxfUAJisRBr+R1459U m6FPhM+UcODwGNTrnyCTKwzgbGLFgYBYTSGjTX6AMaItABH+F/dL3l8BGe+uVTY7MXtU9xKkra +QRDvbQf9hcyZnbMXzD2dCW6Iae3egSus5lHOWtTy4Jlw65sXh79Ug8ZmLLo8xNPU0ZY0zwTEs s3w= From: Jiada Wang To: , , , , , CC: , , , , Subject: [PATCH v7 40/48] Input: Atmel: improve error handling in mxt_update_cfg() Date: Wed, 12 Feb 2020 00:42:10 -0800 Message-ID: <20200212084218.32344-41-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200212084218.32344-1-jiada_wang@mentor.com> References: <20200212084218.32344-1-jiada_wang@mentor.com> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 07228df847e3..3654f4b399d9 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2183,7 +2183,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem);