From patchwork Mon Mar 4 19:54:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159581 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp4150676jad; Mon, 4 Mar 2019 11:55:59 -0800 (PST) X-Google-Smtp-Source: APXvYqxbAv6lEAya41f7ZPsTnqGruQwm5GKCEhA+q5C6M7peXTGHNWn7adXNkLp2uiom/Z4I3vCd X-Received: by 2002:a65:4348:: with SMTP id k8mr20139618pgq.289.1551729359785; Mon, 04 Mar 2019 11:55:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551729359; cv=none; d=google.com; s=arc-20160816; b=M8qKqmKLOhnWHLCAy6V4mIq80cRzlFyWF0gDHvrM7J3PIb3HEWI2DCAYTP/I66CdmK 27iviOf1Wm6OAwd1Y9y1vSi4iCLMP+NjPRSUm0ceMH3vYdQSvNVp0S+341an8f9wxcFD Yc1Bvr1AYsV47bQ5UXQ8+JOkpKfDNUGxGKMYBiDmpOTRsdQT5gfMb/ILnSBGsYdn6hqH bMApIFKhWZr5eEcqU45BjUBXo+2Fm6yvCu+tMHi0ADSYwCCFYvy/aldjSJ1S0TuhCuLu WgdkOJaH3V1qFnrVH9RQmvsym6ybgtN6qIbPcWPXLUJV4t5yxZs04w2qNuVHRXGNjlq1 a7xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=oCZBJIaNDBBCvVUzgtDdWWdVsuCTd8Rn64hG2wJ0RNY=; b=RlyNGGFzDLeb1gE4cFMZHsIe+nXO6yZE61gKvHFMvQOsCaErsNi5z+osvPVRaR1Gcs Hm9mHjSVN4zDeOgDZPk5lpIDnUo8YBnaewTioEJi1tkZQ3HS8ib8i2g9BjKvex7NcPdd EbLTKd7mrLmmukbMCZ/nbwj/fgA/yVEIUvzugPNxUmrXVWxFjHjX08GbGRY7/2et4zrc JW/dQTtJoJP7b0vwpZhxA4vwwOJNey24PO3HBTghgQRNQy+43QISp13R/Emwp0kK2NN6 fZMJf5v5K90oUCWpcc/+UhCItxlUQlyWrHfty5lIRtJpEQmMkB1OD5umv1Rb0at29Qjk O6lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id go21si6148332plb.368.2019.03.04.11.55.59 for ; Mon, 04 Mar 2019 11:55:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726061AbfCDTz7 (ORCPT ); Mon, 4 Mar 2019 14:55:59 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:52615 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbfCDTz7 (ORCPT ); Mon, 4 Mar 2019 14:55:59 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1N95qT-1h4SQ513KR-016A9E; Mon, 04 Mar 2019 20:55:50 +0100 From: Arnd Bergmann To: Jiri Kosina , Benjamin Tissoires Cc: NOGUCHI Hiroshi , Arnd Bergmann , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: hid-asus: select CONFIG_POWER_SUPPLY Date: Mon, 4 Mar 2019 20:54:43 +0100 Message-Id: <20190304195536.1019650-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:f+i+OrDzGO5H4U2g4SqZUp9c0UQmPl0RW7oYspPkrcB5i49uSJn NzL/ZrRU2mKFqYAHpn3s5zcgYzdivprMCE1lopi5HT0NHuRdsTxpZevB006Ps4xo1sF0QMR +9ULLpfK28inUcSySNcgfwjFYG5WfsH3aZrsHoELYXrZ0NqetQzrQBzsCgPGiLX8NvOVsLI BKdHO6VFVGzUh97iaC+Mg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:8USgwDmB/OY=:gy//9rVrQEESBN2+gLPbj+ nuDyqOROJII3exPtGEnI/QNEbcPICR4qqqbgFbpNn9EGoiG12B5EbjqyQwLqbxXKuq9jzsuPk DVB4sMigqjh+TKkkBI44wE9IwSWY1QJi1+c9ygNC16Kel1epATeUWaLyfkNkD0DYAOZCUiNJi cQfOqcN4hnmFzb3gJbVhgllgaa2d7TCUnVIcWUPMmsqug6TQyRZkAbOQZitbu/Z/FXk6bG7/x MbJbtPuLvaRIfoSBIFB7IOL8qbNpHQe/zseqTe/P6VLP9it4teMEHa69FVX+APT0Sjej1MdXh EeK1fnxBuSgGKvot1V2Zg2xsSegOOx4S/JmwDMrtYNYbkaB3WyZxYnElY3FudKtZqxwEISVmh sir4mp0bB2Lz4FaUiK+bz51Ign8tA241GT49VkRMbDo13DZv3bVx2+KYGcUDbjpkcMCVCTxNW en53xbV6dJzqa7HvjbklsOpexaVQsW/QrhWsLcKnF38x8Mj+cTxCp1BpE1cR876PSdQris/iq Sk7ZhnwKL6fbce6ZI305wQd4E5DMK7xmypYNMmBOv/vQuJkAWWlfSFY9TjzJGQxPYuT0YuMe/ BqoRatQjoICDb4BWbXc8HmlLc/f5zO0JFcFom06xZtXEBczaTGW7ggNtrdEP5vIq8gZ8JUYL/ /JHcsbvfqzGTtZ67zdHjEV/2Wgt+oQD0lkc6h33fqp+69yRrooZ/a4NkNM6h+EephxctKYjCv fTJkdVN6L5jEVX7vKTVAXfAbSBJ1/fWQJfKS/g== Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The newly added power supply code fails to link when the power supply core code is disabled: drivers/hid/hid-asus.o: In function `asus_battery_get_property': hid-asus.c:(.text+0x11de): undefined reference to `power_supply_get_drvdata' drivers/hid/hid-asus.o: In function `asus_probe': hid-asus.c:(.text+0x170c): undefined reference to `devm_power_supply_register' hid-asus.c:(.text+0x1734): undefined reference to `power_supply_powers' drivers/hid/hid-asus.o: In function `asus_raw_event': hid-asus.c:(.text+0x1914): undefined reference to `power_supply_changed' Select the subsystem from Kconfig as we do for other hid drivers already. Fixes: 6311d329e12a ("HID: hid-asus: Add BT keyboard dock battery monitoring support") Signed-off-by: Arnd Bergmann --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0 diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 6ca8d322b487..4ca0cdfa6b33 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -150,6 +150,7 @@ config HID_ASUS tristate "Asus" depends on LEDS_CLASS depends on ASUS_WMI || ASUS_WMI=n + select POWER_SUPPLY ---help--- Support for Asus notebook built-in keyboard and touchpad via i2c, and the Asus Republic of Gamers laptop keyboard special keys.