From patchwork Mon Aug 6 11:11:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10512 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 746782402A for ; Mon, 6 Aug 2012 11:12:17 +0000 (UTC) Received: from mail-gh0-f180.google.com (mail-gh0-f180.google.com [209.85.160.180]) by fiordland.canonical.com (Postfix) with ESMTP id 38A90A1847B for ; Mon, 6 Aug 2012 11:12:17 +0000 (UTC) Received: by ghbg10 with SMTP id g10so574679ghb.11 for ; Mon, 06 Aug 2012 04:12:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:mime-version:content-type :x-gm-message-state; bh=e4vPfzeZnGaMAqLjBONGqNLxAZbuSm3OJw8/N4t1AUs=; b=HdR3GL/zxlDxJVdxts8KGQcz5h4uoE+oOwUs9ujd3JHo3fLG/mmqonhOfzbI71PmJQ 6vElP+GX7iTFfCEAxEZRAUeVpH4wqLHkHAD5LuriGFATAm3Tmx9FqM7BS9oGAGK1qhiY iJHHJ9oGHK5oC3hrihoG7s0xdG/uzgUj3dT5Fw2ONpcClLzVCo0VEBEn89QKDB/1WTKn fkQ1usJVVL4f+pTXjvhhi5KdxgnL8Fk0kCfZnrcixqpvTMSt5SrBCLqTJn151ZDCnWXc AotvANUszav71tWRSWH5XnUNzn+AChX97675baWlrl7ym3dhhVFNz1MIcljGSx0+5juI O1Sg== Received: by 10.50.47.161 with SMTP id e1mr4923635ign.11.1344251536358; Mon, 06 Aug 2012 04:12:16 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.87.40 with SMTP id u8csp434581igz; Mon, 6 Aug 2012 04:12:15 -0700 (PDT) Received: by 10.14.214.196 with SMTP id c44mr12583571eep.7.1344251534609; Mon, 06 Aug 2012 04:12:14 -0700 (PDT) Received: from eu1sys200aog106.obsmtp.com (eu1sys200aog106.obsmtp.com. [207.126.144.121]) by mx.google.com with SMTP id m5si9907192een.75.2012.08.06.04.11.56 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 06 Aug 2012 04:12:14 -0700 (PDT) Received-SPF: neutral (google.com: 207.126.144.121 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) client-ip=207.126.144.121; Authentication-Results: mx.google.com; spf=neutral (google.com: 207.126.144.121 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) smtp.mail=linus.walleij@stericsson.com Received: from beta.dmz-us.st.com ([167.4.1.35]) (using TLSv1) by eu1sys200aob106.postini.com ([207.126.147.11]) with SMTP ID DSNKUB+mfJtnmx1/3OyNmdeXokcQbhYVFxL1@postini.com; Mon, 06 Aug 2012 11:11:59 UTC Received: from zeta.dmz-us.st.com (ns4.st.com [167.4.16.71]) by beta.dmz-us.st.com (STMicroelectronics) with ESMTP id 2FBD549; Mon, 6 Aug 2012 11:11:29 +0000 (GMT) Received: from relay1.stm.gmessaging.net (unknown [10.230.100.17]) by zeta.dmz-us.st.com (STMicroelectronics) with ESMTP id 1C55C4D; Mon, 6 Aug 2012 07:41:09 +0000 (GMT) Received: from exdcvycastm003.EQ1STM.local (alteon-source-exch [10.230.100.61]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "exdcvycastm003", Issuer "exdcvycastm003" (not verified)) by relay1.stm.gmessaging.net (Postfix) with ESMTPS id 1CFF824C07C; Mon, 6 Aug 2012 13:11:48 +0200 (CEST) Received: from steludxu4075.lud.stericsson.com (10.230.100.153) by smtp.stericsson.com (10.230.100.1) with Microsoft SMTP Server (TLS) id 8.3.83.0; Mon, 6 Aug 2012 13:11:53 +0200 From: Linus Walleij To: Dmitry Torokhov , Cc: Linus Walleij , Lee Jones Subject: [PATCH] Revert "input: ab8500-ponkey: Create AB8500 domain IRQ mapping" Date: Mon, 6 Aug 2012 13:11:49 +0200 Message-ID: <1344251509-16008-1-git-send-email-linus.walleij@stericsson.com> X-Mailer: git-send-email 1.7.11.3 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQnc+GXUInc6Xn7Cy/mBBYPv4YYY1S6gtz9QKlqOsG02S99ZYjrt39DtLGPzCPJn1grsQRwm From: Linus Walleij This reverts commit ca3b3faf9bee4dc5df4f10eae2d1e48f7de0a8ad. I don't understand this patch. The platform_get_irq_by_name() used above already performs the irqdomain remapping, atleast when using non-devicetree boots. I get the remapped IRQ numbers out, and without reverting this the boot bombs, because the code is trying to remap already remapped IRQs. It looks to me like the ab8500_irq_get_virq() API is completely pointless so something fishy is going on here, did some infrastructure change in the v3.6 merge window? Let's revert it for now. Cc: Lee Jones Signed-off-by: Linus Walleij --- drivers/input/misc/ab8500-ponkey.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c index f06231b..84ec691 100644 --- a/drivers/input/misc/ab8500-ponkey.c +++ b/drivers/input/misc/ab8500-ponkey.c @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) ponkey->idev = input; ponkey->ab8500 = ab8500; - ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); + ponkey->irq_dbf = irq_dbf; + ponkey->irq_dbr = irq_dbr; input->name = "AB8500 POn(PowerOn) Key"; input->dev.parent = &pdev->dev;