| Message ID | cover.1744273511.git.geert+renesas@glider.be |
|---|---|
| Headers | show |
| Series | HID: HID_APPLETB_KBD and HID_APPLETB_BL should depend on X86 | expand |
> On 10 Apr 2025, at 2:01 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > The Apple Touch Bar is only present on x86 MacBook Pros. Hence add a > dependency on X86, to prevent asking the user about this driver when > configuring a kernel for a different architecture. There are a lot of spaces before Hence. Also, Apple Touch Bar is present on some Arm MacBooks as well, so probably mention that this driver is only for touchbars on x86 Macs and there is a separate driver for the Arm Macs. Anyways it's Jiri's and your call regarding this change. > > Fixes: 8e9b9152cfbdc2a9 ("HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > This is v2 of "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on > X86". > > v2: > - Split in two patches, > - Correct Fixes. > --- > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index a503252702b7b43c..119e5190a2df786e 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -163,6 +163,7 @@ config HID_APPLETB_KBD > depends on USB_HID > depends on BACKLIGHT_CLASS_DEVICE > depends on INPUT > + depends on X86 || COMPILE_TEST > select INPUT_SPARSEKMAP > select HID_APPLETB_BL > help > -- > 2.43.0 >
Hi Aditya, On Thu, 10 Apr 2025 at 10:52, Aditya Garg <gargaditya08@live.com> wrote: > > On 10 Apr 2025, at 2:01 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > The Apple Touch Bar is only present on x86 MacBook Pros. Hence add a > > dependency on X86, to prevent asking the user about this driver when > > configuring a kernel for a different architecture. > > There are a lot of spaces before Hence. That is intentional: double space between sentences. > Also, Apple Touch Bar is present on some Arm MacBooks as well, so probably mention that this driver is only for touchbars on x86 Macs and there is a separate driver for the Arm Macs. Why is there a separate driver for Arm Macs? Which driver is that? Gr{oetje,eeting}s, Geert
Hi all, The Apple Touch Bar is only present on x86 MacBook Pros. Hence this patch series adds dependencies on X86, to prevent asking the user about its drivers when configuring a kernel for a different architecture. Changes compared to v1[1]: - Split in two patches, - Correct Fixes. Thanks! [1] "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on X86" https://lore.kernel.org/4b046ce1cae2170453037c7ea006c91c12383dab.1744190441.git.geert+renesas@glider.be Geert Uytterhoeven (2): HID: HID_APPLETB_KBD should depend on X86 HID: HID_APPLETB_BL should depend on X86 drivers/hid/Kconfig | 2 ++ 1 file changed, 2 insertions(+)