| Message ID | 20250108011812.627-1-mjchen0829@gmail.com |
|---|---|
| Headers | show |
| Series | Add support for nuvoton ma35d1 keypad controller | expand |
On 08/01/2025 09:42, Ming-Jen Chen wrote: > > Krzysztof Kozlowski 於 2025/1/8 16:13 寫道: >> On Wed, Jan 08, 2025 at 01:18:11AM +0000, Ming-Jen wrote: >>> From: Ming-jen Chen <mjchen0829@gmail.com> >>> >>> Add YAML bindings for MA35D1 SoC keypad. >>> >>> Signed-off-by: Ming-jen Chen <mjchen0829@gmail.com> >>> --- >>> .../bindings/input/nuvoton,ma35d1-keypad.yaml | 82 +++++++++++++++++++ >>> 1 file changed, 82 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml >>> new file mode 100644 >>> index 000000000000..889f253b3bc2 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml >> I don't see changes. >> >> I already raised concern that you sent new versions without implementing >> or responding to comments. So the fourth (!!!) time: Filename matching >> compatible. >> >> Best regards, >> Krzysztof > > Thank you for your feedback! I now understand the changes I need to make. > > I will modify it as blow: > > compatible: > const: nuvoton,ma35d1-keypad Or change the filename... Best regards, Krzysztof
From: Ming-jen Chen <mjchen0829@gmail.com> This patch series adds keypad driver for the nuvoton ma35 ARMv8 SoC. It includes DT binding documentation and the ma35d1 keypad driver. v5: - Update nuvoton,ma35d1-keypad.yaml - Reorders the items in the properties and required blocks to ensure their order and items are consistent. v4: - Update nuvoton,ma35d1-keypad.yaml - Kept the same order of properties as in the required block. - Changed register addresses to lowercase. v3: - Update nuvoton,ma35d1-keypad.yaml - Removed vendor-specific properties and replaced them with common properties - Update ma35d1_keypad.c - Modified the driver to reflect changes in the YAML properties v2: - Update nuvoton,ma35d1-keypad.yaml - Fixed warnings and errors generated by running checkpatch.pl - Removed the previous version's properties and rewrote the properties in the Device Tree schema. - Renamed the Device Tree binding file to nuvoton,ma35d1-keypad.yaml - Update Kconfig - Added COMPILE_TEST to the depends on line in the Kconfig - Update ma35d1_keypad.c - Refactored error handling within the probe function. - Fixed the mixed use of devm and non-devm resource management. - Corrected alignment issues in the code. - Updated suspend and resume handling methods. - Fixed variable naming to remove camel casing. - Used for_each_set_bit() to check key states. - Modified the code to align with updates in the device tree binding Ming-jen Chen (2): dt-bindings: input: Add Nuvoton MA35D1 keypad input: keypad: add new keypad driver for MA35D1 .../bindings/input/nuvoton,ma35d1-keypad.yaml | 82 ++++ drivers/input/keyboard/Kconfig | 10 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/ma35d1_keypad.c | 387 ++++++++++++++++++ 4 files changed, 480 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml create mode 100644 drivers/input/keyboard/ma35d1_keypad.c