| Message ID | 20240813-b4-cst816s-b4-v1-0-78a03cbef328@gmail.com |
|---|---|
| Headers | show |
| Series | Code quality enhancing and add tag for dt-bindings | expand |
On 13/08/2024 01:22, Oleh Kuzhylnyi wrote: > Add documentation for the Hynitron CST816X touchscreen bindings. > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> How this could come with review tag if this is v1? Or is it not correctly versioned? That will confuse all the tools... git format-patch -v2 or just use b4. > Signed-off-by: Oleh Kuzhylnyi <kuzhylol@gmail.com> ... > + > +properties: > + compatible: > + enum: > + - hynitron,cst816s > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > +additionalProperties: false If there is going to be new version, this goes after required: block. Best regards, Krzysztof
On Tue, Aug 13, 2024 at 11:15 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 13/08/2024 01:22, Oleh Kuzhylnyi wrote: > > Add documentation for the Hynitron CST816X touchscreen bindings. > > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > How this could come with review tag if this is v1? Or is it not > correctly versioned? > > That will confuse all the tools... > > git format-patch -v2 or just use b4. Oops. Messed up with b4 configuration. I will resend the proper version. > > Signed-off-by: Oleh Kuzhylnyi <kuzhylol@gmail.com> > > ... > > > + > > +properties: > > + compatible: > > + enum: > > + - hynitron,cst816s > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + reset-gpios: > > + maxItems: 1 > > + > > +additionalProperties: false > > If there is going to be new version, this goes after required: block. > > > Best regards, > Krzysztof >
Patch 2/2: add driver for Hynitron CST816X touchscreen Changes in v4: Updated patch based on Dmitry Torokhov suggestions: - Moved from u8 to u16 to store coordinates - Removed __packed for touch_info struct - Move touch info from priv structure to stack - Added buf and size as new arguments for cst816x_i2c_read_register() - Removed loop from event matching Patch 1/2: dt-bindings: input: touchscreen: add Hynitron CST816X Changes in v4: - Added "Reviewed-by:" tag received from Conor Dooley Signed-off-by: Oleh Kuzhylnyi <kuzhylol@gmail.com> --- Oleh Kuzhylnyi (2): dt-bindings: input: touchscreen: add Hynitron CST816X input: add driver for Hynitron CST816X touchscreen .../input/touchscreen/hynitron,cst816s.yaml | 57 +++++ drivers/input/touchscreen/Kconfig | 12 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/hynitron-cst816x.c | 258 +++++++++++++++++++++ 4 files changed, 328 insertions(+) --- base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba change-id: 20240813-b4-cst816s-b4-f3237952c95b Best regards,