mbox series

[v2,0/2] Fix UCLogic warnings

Message ID 20240614161935.230529-1-jose.exposito89@gmail.com
Headers show
Series Fix UCLogic warnings | expand

Message

José Expósito June 14, 2024, 4:16 p.m. UTC 
Hi everyone,

This is a follow up on Arnd's work [1] fixing these warnings.

Sending it as v2 so it is clear that the first patch doesn't
need to be merged.

Best wishes,
Jose

[1] https://lore.kernel.org/linux-input/8d93cdd6-379b-48e7-8a10-9df190b12623@app.fastmail.com/T/
José Expósito (2):
  HID: uclogic: Avoid linking common code into multiple modules
  HID: uclogic: Add module description

 drivers/hid/Makefile                 | 6 ++----
 drivers/hid/hid-uclogic-core.c       | 1 +
 drivers/hid/hid-uclogic-rdesc-test.c | 2 ++
 drivers/hid/hid-uclogic-rdesc.c      | 2 ++
 4 files changed, 7 insertions(+), 4 deletions(-)

Comments

Jiri Kosina June 19, 2024, 2:34 p.m. UTC | #1 
On Fri, 14 Jun 2024, José Expósito wrote:

> The hid-uclogic-params.o and hid-uclogic-rdesc.o files are linked
> into both the driver module and the unit test, which triggers a
> W=1 warning:
> 
> scripts/Makefile.build:236: drivers/hid/Makefile: hid-uclogic-rdesc.o is added to multiple modules: hid-uclogic hid-uclogic-test
> scripts/Makefile.build:236: drivers/hid/Makefile: hid-uclogic-params.o is added to multiple modules: hid-uclogic hid-uclogic-test
> 
> Avoids this by moving these two files into a separate module
> that is used by the driver and the unit test.
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>

I've added Reported-by: for Arnd and applied, thanks!