| Message ID | 20240126160724.13278-1-hdegoede@redhat.com |
|---|---|
| Headers | show |
| Series | Input: atkbd - Fix Dell XPS 13 line suspend/resume regression | expand |
On 26.01.24 17:07, Hans de Goede wrote: > Hi Dmitry, > > There have been multiple reports that the keyboard on > Dell XPS 13 9350 / 9360 / 9370 models has stopped working after > a suspend/resume after the merging of commit 936e4d49ecbc ("Input: > atkbd - skip ATKBD_CMD_GETID in translated mode"). > > See the 4 closes tags in the first patch for 4 reports of this. > > I have been working with the first reporter on resolving this > and testing on his Dell XPS 13 9360 confirms that these patches > fix things. > > Unfortunately the commit causing the issue has also been picked > up by multiple stable kernel series now. Can you please send > these fixes to Linus ASAP, so that they can also be backported > to the stable series ASAP ? Dmitry, Hans, what's the status here? I wonder if there is still a chance to get this into -rc3 so that Greg can fix the affected stable trees as well next week or so. Ciao, Thorsten > Hans de Goede (2): > Input: atkbd - Skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID > Input: atkbd - Do not skip atkbd_deactivate() when skipping > ATKBD_CMD_GETID > > drivers/input/keyboard/atkbd.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) >
Hi, On 2/1/24 12:12, Linux regression tracking (Thorsten Leemhuis) wrote: > On 26.01.24 17:07, Hans de Goede wrote: >> Hi Dmitry, >> >> There have been multiple reports that the keyboard on >> Dell XPS 13 9350 / 9360 / 9370 models has stopped working after >> a suspend/resume after the merging of commit 936e4d49ecbc ("Input: >> atkbd - skip ATKBD_CMD_GETID in translated mode"). >> >> See the 4 closes tags in the first patch for 4 reports of this. >> >> I have been working with the first reporter on resolving this >> and testing on his Dell XPS 13 9360 confirms that these patches >> fix things. >> >> Unfortunately the commit causing the issue has also been picked >> up by multiple stable kernel series now. Can you please send >> these fixes to Linus ASAP, so that they can also be backported >> to the stable series ASAP ? > > Dmitry, Hans, what's the status here? I wonder if there is still a > chance to get this into -rc3 so that Greg can fix the affected stable > trees as well next week or so.
On Fri, Jan 26, 2024 at 05:07:22PM +0100, Hans de Goede wrote: > Hi Dmitry, > > There have been multiple reports that the keyboard on > Dell XPS 13 9350 / 9360 / 9370 models has stopped working after > a suspend/resume after the merging of commit 936e4d49ecbc ("Input: > atkbd - skip ATKBD_CMD_GETID in translated mode"). > > See the 4 closes tags in the first patch for 4 reports of this. > > I have been working with the first reporter on resolving this > and testing on his Dell XPS 13 9360 confirms that these patches > fix things. > > Unfortunately the commit causing the issue has also been picked > up by multiple stable kernel series now. Can you please send > these fixes to Linus ASAP, so that they can also be backported > to the stable series ASAP ? > > Alternatively we could revert the commit causing this, but that > commit is know to fix issues on a whole bunch of other laptops > so I would rather not revert it. > > Regards, > > Hans > > > Hans de Goede (2): > Input: atkbd - Skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID > Input: atkbd - Do not skip atkbd_deactivate() when skipping > ATKBD_CMD_GETID Applied the lot to 'for-linus' branch, I will get it into the next push. Thanks.
Hi Dmitry, There have been multiple reports that the keyboard on Dell XPS 13 9350 / 9360 / 9370 models has stopped working after a suspend/resume after the merging of commit 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode"). See the 4 closes tags in the first patch for 4 reports of this. I have been working with the first reporter on resolving this and testing on his Dell XPS 13 9360 confirms that these patches fix things. Unfortunately the commit causing the issue has also been picked up by multiple stable kernel series now. Can you please send these fixes to Linus ASAP, so that they can also be backported to the stable series ASAP ? Alternatively we could revert the commit causing this, but that commit is know to fix issues on a whole bunch of other laptops so I would rather not revert it. Regards, Hans Hans de Goede (2): Input: atkbd - Skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID Input: atkbd - Do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID drivers/input/keyboard/atkbd.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)