| Message ID | 20231204172510.35041-1-biju.das.jz@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Convert DA906{1,2} bindings to json-schema | expand |
On Mon, Dec 04, 2023 at 05:25:07PM +0000, Biju Das wrote: > Convert the da906{1,2,3} onkey device tree binding documentation to > json-schema. > > Update MAINTAINERS entries, description and onkey property by > referring to dlg,da9062-onkey binding file. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v3->v3.1: > * Squashed with patch#6 and patch#9 from v2. > * Replaced enum->const for dlg,da9061-onkey and its fallback. > * Dropped example I think this looks good Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On 04/12/2023 18:25, Biju Das wrote: > Convert the below bindings to json-schema > 1) DA906{1,2} mfd bindings > 2) DA906{1,2,3} onkey bindings > 3) DA906{1,2,3} thermal bindings > > Also add fallback for DA9061 watchdog device and document > DA9063 watchdog device. > > v3->v3.1: > * Patch#1 is merge of patch#1 from v2 + patch#8 from v2. > * Dropped comment for d9061 watchdog fallback > * Replaced enum->const for dlg,da9061-watchdog and its fallback. > * Restored patch#4 in series 1 and dropped the thermal example > * Added Ack from Conor Dooley for da9063 watchdog binding support. > * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063. > * Retained Rb tag since the changes are trivial. > * Added Ack from Conor for updating watchdog property > * Dropped link to product information. > * Patch#5(onkey) is squashed with patch#6 and patch#9 from v2. > * Replaced enum->const for dlg,da9061-onkey and its fallback. > * Dropped example > * Restored the thermal binding patch from v2. > * Dropped example > * Replaced enum->const for compatible property. > * Added Rb tag from Rob and retained Rb tag as changes are trivial. > * Added Ack from Conor Dooley for patch#7. > * Split the thermal binding patch separate > * Updated the description Hundreds of changes and just "3 -> 3.1"? This does not make sense. Also, use normal versioning: b4 diff '<20231204172510.35041-9-biju.das.jz@bp.renesas.com>' Grabbing thread from lore.kernel.org/all/20231204172510.35041-9-biju.das.jz@bp.renesas.com/t.mbox.gz --- Analyzing 21 messages in the thread ERROR: Could not auto-find previous revision Run "b4 am -T" manually, then "b4 diff -m mbx1 mbx2" Best regards, Krzysztof
Hi Krzysztof Kozlowski, Thanks for the feedback. > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Wednesday, December 6, 2023 11:06 AM > Subject: Re: [PATCH v3.1 0/8] Convert DA906{1,2} bindings to json-schema > > On 04/12/2023 18:25, Biju Das wrote: > > Convert the below bindings to json-schema > > 1) DA906{1,2} mfd bindings > > 2) DA906{1,2,3} onkey bindings > > 3) DA906{1,2,3} thermal bindings > > > > Also add fallback for DA9061 watchdog device and document > > DA9063 watchdog device. > > > > v3->v3.1: > > * Patch#1 is merge of patch#1 from v2 + patch#8 from v2. > > * Dropped comment for d9061 watchdog fallback > > * Replaced enum->const for dlg,da9061-watchdog and its fallback. > > * Restored patch#4 in series 1 and dropped the thermal example > > * Added Ack from Conor Dooley for da9063 watchdog binding support. > > * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063. > > * Retained Rb tag since the changes are trivial. > > * Added Ack from Conor for updating watchdog property > > * Dropped link to product information. > > * Patch#5(onkey) is squashed with patch#6 and patch#9 from v2. > > * Replaced enum->const for dlg,da9061-onkey and its fallback. > > * Dropped example > > * Restored the thermal binding patch from v2. > > * Dropped example > > * Replaced enum->const for compatible property. > > * Added Rb tag from Rob and retained Rb tag as changes are trivial. > > * Added Ack from Conor Dooley for patch#7. > > * Split the thermal binding patch separate > > * Updated the description > > > Hundreds of changes and just "3 -> 3.1"? This does not make sense. Bot reported some issues with v2. So immediately I send v3 which clashed with review comments from Conor and Rob. No one has reviewed V3. V3.1 = basically Review comments from v2 + Fix for Bot errors. > > Also, use normal versioning: > > b4 diff '<20231204172510.35041-9-biju.das.jz@bp.renesas.com>' > Grabbing thread from > lore.kernel.org/all/20231204172510.35041-9- > biju.das.jz@bp.renesas.com/t.mbox.gz > --- > Analyzing 21 messages in the thread > ERROR: Could not auto-find previous revision > Run "b4 am -T" manually, then "b4 diff -m mbx1 mbx2" Can you please clarify more? I may be missing something here? I just rebase to linux-next and send patches using the command git send-email --dry-run --annotate *.patch All patches Updated with TO and CC recipients. Am I missing anything here w.r.to versioning? Cheers, Biju
On 06/12/2023 12:16, Biju Das wrote: > Hi Krzysztof Kozlowski, > > Thanks for the feedback. > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Wednesday, December 6, 2023 11:06 AM >> Subject: Re: [PATCH v3.1 0/8] Convert DA906{1,2} bindings to json-schema >> >> On 04/12/2023 18:25, Biju Das wrote: >>> Convert the below bindings to json-schema >>> 1) DA906{1,2} mfd bindings >>> 2) DA906{1,2,3} onkey bindings >>> 3) DA906{1,2,3} thermal bindings >>> >>> Also add fallback for DA9061 watchdog device and document >>> DA9063 watchdog device. >>> >>> v3->v3.1: >>> * Patch#1 is merge of patch#1 from v2 + patch#8 from v2. >>> * Dropped comment for d9061 watchdog fallback >>> * Replaced enum->const for dlg,da9061-watchdog and its fallback. >>> * Restored patch#4 in series 1 and dropped the thermal example >>> * Added Ack from Conor Dooley for da9063 watchdog binding support. >>> * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063. >>> * Retained Rb tag since the changes are trivial. >>> * Added Ack from Conor for updating watchdog property >>> * Dropped link to product information. >>> * Patch#5(onkey) is squashed with patch#6 and patch#9 from v2. >>> * Replaced enum->const for dlg,da9061-onkey and its fallback. >>> * Dropped example >>> * Restored the thermal binding patch from v2. >>> * Dropped example >>> * Replaced enum->const for compatible property. >>> * Added Rb tag from Rob and retained Rb tag as changes are trivial. >>> * Added Ack from Conor Dooley for patch#7. >>> * Split the thermal binding patch separate >>> * Updated the description >> >> >> Hundreds of changes and just "3 -> 3.1"? This does not make sense. > > Bot reported some issues with v2. So immediately I send v3 which clashed > with review comments from Conor and Rob. > > No one has reviewed V3. > > V3.1 = basically Review comments from v2 + Fix for Bot errors. v4, don't introduce some minor numbering to create impression of no changes, especially if you have multiple changes. > > >> >> Also, use normal versioning: >> >> b4 diff '<20231204172510.35041-9-biju.das.jz@bp.renesas.com>' >> Grabbing thread from >> lore.kernel.org/all/20231204172510.35041-9- >> biju.das.jz@bp.renesas.com/t.mbox.gz >> --- >> Analyzing 21 messages in the thread >> ERROR: Could not auto-find previous revision >> Run "b4 am -T" manually, then "b4 diff -m mbx1 mbx2" > > > Can you please clarify more? I may be missing something here? > > I just rebase to linux-next and send patches using the command > > git send-email --dry-run --annotate *.patch > > All patches Updated with TO and CC recipients. > > Am I missing anything here w.r.to versioning? v3 -> v4. Best regards, Krzysztof
Hi Krzysztof Kozlowski, Thanks for the feedback. > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Wednesday, December 6, 2023 11:18 AM > Subject: Re: [PATCH v3.1 0/8] Convert DA906{1,2} bindings to json-schema > > On 06/12/2023 12:16, Biju Das wrote: > > Hi Krzysztof Kozlowski, > > > > Thanks for the feedback. > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Wednesday, December 6, 2023 11:06 AM > >> Subject: Re: [PATCH v3.1 0/8] Convert DA906{1,2} bindings to > >> json-schema > >> > >> On 04/12/2023 18:25, Biju Das wrote: > >>> Convert the below bindings to json-schema > >>> 1) DA906{1,2} mfd bindings > >>> 2) DA906{1,2,3} onkey bindings > >>> 3) DA906{1,2,3} thermal bindings > >>> > >>> Also add fallback for DA9061 watchdog device and document > >>> DA9063 watchdog device. > >>> > >>> v3->v3.1: > >>> * Patch#1 is merge of patch#1 from v2 + patch#8 from v2. > >>> * Dropped comment for d9061 watchdog fallback > >>> * Replaced enum->const for dlg,da9061-watchdog and its fallback. > >>> * Restored patch#4 in series 1 and dropped the thermal example > >>> * Added Ack from Conor Dooley for da9063 watchdog binding support. > >>> * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063. > >>> * Retained Rb tag since the changes are trivial. > >>> * Added Ack from Conor for updating watchdog property > >>> * Dropped link to product information. > >>> * Patch#5(onkey) is squashed with patch#6 and patch#9 from v2. > >>> * Replaced enum->const for dlg,da9061-onkey and its fallback. > >>> * Dropped example > >>> * Restored the thermal binding patch from v2. > >>> * Dropped example > >>> * Replaced enum->const for compatible property. > >>> * Added Rb tag from Rob and retained Rb tag as changes are trivial. > >>> * Added Ack from Conor Dooley for patch#7. > >>> * Split the thermal binding patch separate > >>> * Updated the description > >> > >> > >> Hundreds of changes and just "3 -> 3.1"? This does not make sense. > > > > Bot reported some issues with v2. So immediately I send v3 which > > clashed with review comments from Conor and Rob. > > > > No one has reviewed V3. > > > > V3.1 = basically Review comments from v2 + Fix for Bot errors. > > v4, don't introduce some minor numbering to create impression of no > changes, especially if you have multiple changes. OK, When I send next version, I will use V5 and revision history(log change) I will use v4 instead of v3.1 as it has multiple changes. Is it ok? Cheers, Biju
On Mon, Dec 04, 2023 at 05:25:02PM +0000, Biju Das wrote: > Convert the below bindings to json-schema > 1) DA906{1,2} mfd bindings > 2) DA906{1,2,3} onkey bindings > 3) DA906{1,2,3} thermal bindings > > Also add fallback for DA9061 watchdog device and document > DA9063 watchdog device. > > v3->v3.1: No, it's v4. The various tools (PW, b4) don't understand point versions. Rob
Hi Rob Herring, thanks for the feedback. > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Wednesday, December 6, 2023 1:59 PM > Subject: Re: [PATCH v3.1 0/8] Convert DA906{1,2} bindings to json-schema > > On Mon, Dec 04, 2023 at 05:25:02PM +0000, Biju Das wrote: > > Convert the below bindings to json-schema > > 1) DA906{1,2} mfd bindings > > 2) DA906{1,2,3} onkey bindings > > 3) DA906{1,2,3} thermal bindings > > > > Also add fallback for DA9061 watchdog device and document > > DA9063 watchdog device. > > > > v3->v3.1: > > No, it's v4. The various tools (PW, b4) don't understand point versions. It is a mistake from my side. I will send same patch series as v4? So that one can, compare the current patch series(v4) against v2 and v3. Cheers, Biju
Convert the below bindings to json-schema 1) DA906{1,2} mfd bindings 2) DA906{1,2,3} onkey bindings 3) DA906{1,2,3} thermal bindings Also add fallback for DA9061 watchdog device and document DA9063 watchdog device. v3->v3.1: * Patch#1 is merge of patch#1 from v2 + patch#8 from v2. * Dropped comment for d9061 watchdog fallback * Replaced enum->const for dlg,da9061-watchdog and its fallback. * Restored patch#4 in series 1 and dropped the thermal example * Added Ack from Conor Dooley for da9063 watchdog binding support. * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063. * Retained Rb tag since the changes are trivial. * Added Ack from Conor for updating watchdog property * Dropped link to product information. * Patch#5(onkey) is squashed with patch#6 and patch#9 from v2. * Replaced enum->const for dlg,da9061-onkey and its fallback. * Dropped example * Restored the thermal binding patch from v2. * Dropped example * Replaced enum->const for compatible property. * Added Rb tag from Rob and retained Rb tag as changes are trivial. * Added Ack from Conor Dooley for patch#7. * Split the thermal binding patch separate * Updated the description v2->v3: * Updated Maintainer entries for watchdog,onkey and thermal bindings * Fixed bot errors related to MAINTAINERS entry, invalid doc references and thermal examples by merging patch#4. v1->v2: Link: https://lore.kernel.org/all/20231201110840.37408-5-biju.das.jz@bp.renesas.com/ * DA9062 and DA9061 merged with DA9063 * Sorted the child devices * mfd,onkey and thermal are pointing to child bindings Biju Das (8): dt-bindings: mfd: da9062: Update watchdog description dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog dt-bindings: mfd: dlg,da9063: Update watchdog property dt-bindings: input: Convert da906{1,2,3} onkey to json-schema dt-bindings: thermal: Convert da906{1,2} thermal to json-schema dt-bindings: mfd: dlg,da9063: Sort child devices dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema .../bindings/input/da9062-onkey.txt | 47 ---- .../bindings/input/dlg,da9062-onkey.yaml | 39 ++++ .../devicetree/bindings/mfd/da9062.txt | 124 ---------- .../devicetree/bindings/mfd/dlg,da9063.yaml | 221 +++++++++++++++--- .../bindings/thermal/da9062-thermal.txt | 36 --- .../bindings/thermal/dlg,da9062-thermal.yaml | 35 +++ .../watchdog/dlg,da9062-watchdog.yaml | 13 +- MAINTAINERS | 6 +- 8 files changed, 272 insertions(+), 249 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt create mode 100644 Documentation/devicetree/bindings/input/dlg,da9062-onkey.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/da9062.txt delete mode 100644 Documentation/devicetree/bindings/thermal/da9062-thermal.txt create mode 100644 Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml