| Message ID | 20230417182909.33833-1-rrameshbabu@nvidia.com |
|---|---|
| Headers | show |
| Series | HID: shield | expand |
Hi Randy, Thanks for the feedback. You are correct about the styling issue in my patch. I will fix this. I do want to bring to attention that there seem to be a couple of kernel config options in the Kconfig file for the hid subsystem that currently violate the styling rules. It probably would make sense to have a clean-up patch for this issue overall (separate from this patch, which I will correct in my next version). -- Rahul Rameshbabu On Mon, 17 Apr, 2023 12:20:51 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > According to Documentation/process/coding-style.rst, Kconfig help text should > be indented by 2 spaces after the "help" line: > > 10) Kconfig configuration files > ------------------------------- > > For all of the Kconfig* configuration files throughout the source tree, > the indentation is somewhat different. Lines under a ``config`` definition > are indented with one tab, while help text is indented an additional two > spaces. Example:: > > config AUDIT > bool "Auditing support" > depends on NET > help > Enable auditing infrastructure that can be used with another > kernel subsystem, such as SELinux (which requires this for > logging of avc messages output). Does not do system-call > auditing without CONFIG_AUDITSYSCALL.
Hi. This is an initial driver implementation for supporting NVIDIA SHIELD peripherals. Currently supports the following functionality for the THUNDERSTRIKE (SHIELD 2017) controller. - Haptics (ff_memless) - Serial number query (sysfs) - Hardware information query (sysfs) - Firmware version query (sysfs) Changes: v2 -> v3: * Renamed drivers/hid/hid-shield.c -> drivers/hid/hid-nvidia-shield.c. * Added space between braces for terminating element in shield_devices array. v1 -> v2: * Declared thunderstrike_hostcmd_req_work_handler as static. Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/oe-kbuild-all/202304011342.6Bh3cWhA-lkp@intel.com/ Link: https://lore.kernel.org/oe-kbuild-all/202304020922.vsngJnBT-lkp@intel.com/ Rahul Rameshbabu (1): HID: shield: Initial driver implementation with Thunderstrike support MAINTAINERS | 6 + drivers/hid/Kconfig | 18 + drivers/hid/Makefile | 1 + drivers/hid/hid-ids.h | 3 + drivers/hid/hid-nvidia-shield.c | 587 ++++++++++++++++++++++++++++++++ 5 files changed, 615 insertions(+) create mode 100644 drivers/hid/hid-nvidia-shield.c Link: https://lore.kernel.org/linux-input/20230410170840.16119-1-rrameshbabu@nvidia.com/ Link: https://lore.kernel.org/linux-input/20230401032150.7424-1-rrameshbabu@nvidia.com/