| Message ID | 20221029161240.15548-1-jose.exposito89@gmail.com |
|---|---|
| Headers | show |
| Series | Add support for XP-PEN Deco LW | expand |
On Sat, 29 Oct 2022, Mia Kanashi wrote: > >The XP-PEN Deco LW drawing tablet can be connected by USB cable or using > >a USB Bluetooth dongle. When it is connected using the dongle, there > >might be a small delay until the tablet is paired with the dongle. > > > >Fetching the device battery during this delay results in random battery > >percentage values. > > > >Add a quirk to avoid actively querying the battery percentage and wait > >for the device to report it on its own. > > > >Reported-by: Mia Kanashi <chad@redpilled.dev> > >Signed-off-by: José Expósito <jose.exposito89@gmail.com> [ ... snip ... ] > I've tested this patch and now power supply status is correctly set to > Unknown and capacity is set to 0 initially. > > Just a note that that issue occured not only with the dongle, but a > cable also. It seems that tablet just doesn't respond to the query. > > Thank you for the work! Based on this, can I assume that I can turn Reported-by: Mia Kanashi <chad@redpilled.dev> into Reported-and-tested-by: Mia Kanashi <chad@redpilled.dev> for the final version? Thanks,
On 4 November 2022 15:13:34 EET, Jiri Kosina <jikos@kernel.org> wrote: >Based on this, can I assume that I can turn > > Reported-by: Mia Kanashi <chad@redpilled.dev> > >into > > Reported-and-tested-by: Mia Kanashi <chad@redpilled.dev> > >for the final version? > >Thanks, Yes, but maintainer docs don't recommend using combined tags. :) Please do not use combined tags, e.g. Reported-and-tested-by, as they just complicate automated extraction of tags. link: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html?highlight=Reported-and-tested-by#ordering-of-commit-tags
On Sat, 29 Oct 2022, José Expósito wrote: > v1 -> v2: https://lore.kernel.org/linux-input/20221028081656.GA19766@elementary/T/ > > - Barnabás Pőcze: Use strstarts() instead of a custom implementation > > v2 -> v3: https://lore.kernel.org/linux-input/20221029145511.GA7941@elementary/T/ > > - Mia Kanashi: When using the USB dongle, do not fetch battery until > the tablet is paired > > José Expósito (2): > HID: input: do not query XP-PEN Deco LW battery > HID: uclogic: Add support for XP-PEN Deco LW > > drivers/hid/hid-input.c | 6 +++ > drivers/hid/hid-uclogic-params.c | 73 ++++++++++++++++++++++++++++++++ > drivers/hid/hid-uclogic-rdesc.c | 34 +++++++++++++++ > drivers/hid/hid-uclogic-rdesc.h | 7 +++ > 4 files changed, 120 insertions(+) Now in hid.git#for-6.2/uclogic.
On Fri, Nov 04, 2022 at 02:13:34PM +0100, Jiri Kosina wrote: > On Sat, 29 Oct 2022, Mia Kanashi wrote: > > > >The XP-PEN Deco LW drawing tablet can be connected by USB cable or using > > >a USB Bluetooth dongle. When it is connected using the dongle, there > > >might be a small delay until the tablet is paired with the dongle. > > > > > >Fetching the device battery during this delay results in random battery > > >percentage values. > > > > > >Add a quirk to avoid actively querying the battery percentage and wait > > >for the device to report it on its own. > > > > > >Reported-by: Mia Kanashi <chad@redpilled.dev> > > >Signed-off-by: José Expósito <jose.exposito89@gmail.com> > > [ ... snip ... ] > > > I've tested this patch and now power supply status is correctly set to > > Unknown and capacity is set to 0 initially. > > > > Just a note that that issue occured not only with the dongle, but a > > cable also. It seems that tablet just doesn't respond to the query. > > > > Thank you for the work! > > Based on this, can I assume that I can turn > > Reported-by: Mia Kanashi <chad@redpilled.dev> > > into > > Reported-and-tested-by: Mia Kanashi <chad@redpilled.dev> > > for the final version? > > Thanks, > > -- > Jiri Kosina > SUSE Labs > Thanks for adding the tags and reviewing and merging the patches Jiří! Jose