mbox series

[v2,0/1] VRC-2 Car Controller

Message ID 20220902082552.2433744-1-marcus.folkesson@gmail.com
Headers show
Series VRC-2 Car Controller | expand

Message

Marcus Folkesson Sept. 2, 2022, 8:25 a.m. UTC 
Hi,

The device creates two USB endpoints where on of those represent the X/Y
axis as 16 buttons which is not.. quite right.
So get rid of that endpoint.

Also fix the report descriptor for the other endpoint.

Output from hid-recorder:
#  X:     32 | Y:   1001 | # 
E: 000105.808008 7 20 00 e9 03 00 00 00

Link to previous discussion:
https://lore.kernel.org/all/CAO-hwJL-3vAzywjeUsopsRSJX6j-maC5R75ekxZg-W_oKDqYYw@mail.gmail.com/


v2:
- Remove .remove
- Change help text in Kconfig
- Remove redundant check for USB endpoint in vrc2_report_fixup

Marcus Folkesson (1):
  HID: Add driver for VRC-2 Car Controller

 MAINTAINERS            |  6 +++
 drivers/hid/Kconfig    | 10 +++++
 drivers/hid/Makefile   |  1 +
 drivers/hid/hid-vrc2.c | 91 ++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 108 insertions(+)
 create mode 100644 drivers/hid/hid-vrc2.c

Comments

Benjamin Tissoires Sept. 20, 2022, 1:34 p.m. UTC | #1 
On Fri, Sep 2, 2022 at 10:20 AM Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
>
> Hi,
>
> The device creates two USB endpoints where on of those represent the X/Y
> axis as 16 buttons which is not.. quite right.
> So get rid of that endpoint.
>
> Also fix the report descriptor for the other endpoint.
>
> Output from hid-recorder:
> #  X:     32 | Y:   1001 | #
> E: 000105.808008 7 20 00 e9 03 00 00 00
>
> Link to previous discussion:
> https://lore.kernel.org/all/CAO-hwJL-3vAzywjeUsopsRSJX6j-maC5R75ekxZg-W_oKDqYYw@mail.gmail.com/
>
>
> v2:
> - Remove .remove
> - Change help text in Kconfig
> - Remove redundant check for USB endpoint in vrc2_report_fixup
>
> Marcus Folkesson (1):
>   HID: Add driver for VRC-2 Car Controller
>
>  MAINTAINERS            |  6 +++
>  drivers/hid/Kconfig    | 10 +++++
>  drivers/hid/Makefile   |  1 +
>  drivers/hid/hid-vrc2.c | 91 ++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 108 insertions(+)
>  create mode 100644 drivers/hid/hid-vrc2.c
>

Applied to for-6.1/rc-controllers in hid.git

Thanks a lot for this work!

Cheers,
Benjamin