mbox series

[v2,0/3] Magic Keyboard first generation and 2015 FN key mapping

Message ID 20220208183704.40101-1-jose.exposito89@gmail.com
Headers show
Series Magic Keyboard first generation and 2015 FN key mapping | expand

Message

José Expósito Feb. 8, 2022, 6:37 p.m. UTC 
Hi everyone,

This patchset adds the missing key mapping for the Magic Keyboard first
generation and the 2015 models.

Since the first generation model had numlock emulation in place, I
decided to fix the bug (described in the patch) and keep it in place
just because it has been there for so long that people might use it.
Having said that, there is no indication in the keyboard about which
keys can be used as numbers or how to enable/disable numlock.
I think that a patch removing APPLE_NUMLOCK_EMULATION might make sense,
but I didn't want to remove existing functionality without asking :)

Thanks a lot,
José Expósito

v2: Resolve conflicts

José Expósito (3):
  HID: apple: Refactor key translation setup
  HID: apple: Magic Keyboard first generation FN key mapping
  HID: apple: Magic Keyboard 2015 FN key mapping

 drivers/hid/hid-apple.c | 100 ++++++++++++++++++++++++++++++----------
 1 file changed, 76 insertions(+), 24 deletions(-)

Comments

Jiri Kosina Feb. 16, 2022, 3:50 p.m. UTC | #1 
On Tue, 8 Feb 2022, José Expósito wrote:

> Hi everyone,
> 
> This patchset adds the missing key mapping for the Magic Keyboard first
> generation and the 2015 models.
> 
> Since the first generation model had numlock emulation in place, I
> decided to fix the bug (described in the patch) and keep it in place
> just because it has been there for so long that people might use it.
> Having said that, there is no indication in the keyboard about which
> keys can be used as numbers or how to enable/disable numlock.
> I think that a patch removing APPLE_NUMLOCK_EMULATION might make sense,
> but I didn't want to remove existing functionality without asking :)
> 
> Thanks a lot,
> José Expósito
> 
> v2: Resolve conflicts

Queued in hid.git#for-5.18/apple. Thanks José,