mbox series

[RFC,v2,0/5] Input: goodix - platform/x86: touchscreen_dmi - Move quirks to touchscreen_dmi.c

Message ID 20210504185746.175461-1-hdegoede@redhat.com
Headers show
Series Input: goodix - platform/x86: touchscreen_dmi - Move quirks to touchscreen_dmi.c | expand

Message

Hans de Goede May 4, 2021, 6:57 p.m. UTC
Hi Dmitry, Bastien,

Here v2 of the patch series to move the DMI quirks for upside-down and
x-axis-inverted touchscreens in goodix.c to the generic x86 touchscreen
mechanism found in drivers/platform/x86/touchscreen_dmi.c .

As I mentioned in my reply to the v1 RFC I've dropped the:
"platform/x86: touchscreen_dmi: Match on ACPI HID instead of ACPI companion-dev-name"
patch from this version; and for completeness sake I've added a
couple of other pending touchscreen_dmi.c patches.

Note this is still marked as RFC for now since I have been unable to confirm
the ACPI HID for the touchscreen on the Cube I15-TC which is necessary
for the touchscreen_dmi.c code. I've send an email to the reporter and
the author of the patch adding the quirk for the Cube I15-TC.

As discussed in the "[PATCH] platform/x86: touchscreen_dmi: Add swap-x-y
quirk for Goodix touchscreen on Estar Beauty HD tablet" thread, I'll
prepare an immutable branch for Dmitry to pull once this is ready
for merging.

Note if I get no reply to the questions surrounding patch 2/5,
I'll probably just drop that patch and merge the rest.

Regards,

Hans


Hans de Goede (4):
  Input: goodix - platform/x86: touchscreen_dmi - Move upside down
    quirks to touchscreen_dmi.c
  Input: goodix - platform/x86: touchscreen_dmi - Move inverted-x quirk
    to touchscreen_dmi.c
  platform/x86: touchscreen_dmi: Add an extra entry for the upside down
    Goodix touchscreen on Teclast X89 tablets
  platform/x86: touchscreen_dmi: Add info for the Goodix GT912 panel of
    TM800A550L tablets

Teava Radu (1):
  platform/x86: touchscreen_dmi: Add info for the Mediacom Winpad 7.0
    W700 tablet

 drivers/input/touchscreen/goodix.c     |  74 ----------------
 drivers/platform/x86/touchscreen_dmi.c | 112 +++++++++++++++++++++++++
 2 files changed, 112 insertions(+), 74 deletions(-)

Comments

Hans de Goede May 19, 2021, 3:20 p.m. UTC | #1
Hi,

On 5/4/21 8:57 PM, Hans de Goede wrote:
> From: Teava Radu <rateava@gmail.com>

> 

> Add touchscreen info for the Mediacom Winpad 7.0 W700 tablet.

> Tested on 5.11 hirsute.

> Note: it's hw clone to Wintron surftab 7.

> 

> Signed-off-by: Teava Radu <rateava@gmail.com>

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>


I'm going to prepare an immutable branch for patches 1-4 of this series
(with patch 2 dropped since I haven't gotten any testing feedback for it).

Since this is an unrelated touchscreen quirk and I want to send it out in the
next pdx86-fixes pullreq for 5.13, I've added this to the pdx86 review-hans
and fixes branches now.

Regards,

Hans


> ---

>  drivers/platform/x86/touchscreen_dmi.c | 8 ++++++++

>  1 file changed, 8 insertions(+)

> 

> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c

> index f63d2110e224..40c970908a99 100644

> --- a/drivers/platform/x86/touchscreen_dmi.c

> +++ b/drivers/platform/x86/touchscreen_dmi.c

> @@ -1153,6 +1153,14 @@ const struct dmi_system_id touchscreen_dmi_table[] = {

>  			DMI_MATCH(DMI_BIOS_VERSION, "jumperx.T87.KFBNEEA"),

>  		},

>  	},

> +	{

> +		/* Mediacom WinPad 7.0 W700 (same hw as Wintron surftab 7") */

> +		.driver_data = (void *)&trekstor_surftab_wintron70_data,

> +		.matches = {

> +			DMI_MATCH(DMI_SYS_VENDOR, "MEDIACOM"),

> +			DMI_MATCH(DMI_PRODUCT_NAME, "WinPad 7 W10 - WPW700"),

> +		},

> +	},

>  	{

>  		/* Mediacom Flexbook Edge 11 (same hw as TS Primebook C11) */

>  		.driver_data = (void *)&trekstor_primebook_c11_data,

>