mbox series

[0/2] hid: intel-ish-hid: ipc: enable OOB support for EHL

Message ID 20201216063640.4086068-1-lixu.zhang@intel.com
Headers show
Series hid: intel-ish-hid: ipc: enable OOB support for EHL | expand

Message

Zhang, Lixu Dec. 16, 2020, 6:36 a.m. UTC
The EHL (Elkhart Lake) based platforms provide a OOB (Out of band)
service, which allows wakup device when the system is in S5 (Soft-Off
state). This OOB service can be enabled/disabled from BIOS settings.

These two patches is to enable this feature for EHL platform.

We have tested these patches on both ISH platforms and EHL platforms,
it works fine.

Zhang Lixu (2):
  hid: intel-ish-hid: ipc: finish power flow for EHL OOB
  hid: intel-ish-hid: ipc: Address EHL Sx resume issues

 drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  1 +
 drivers/hid/intel-ish-hid/ipc/ipc.c     | 27 +++++++++++++
 drivers/hid/intel-ish-hid/ipc/pci-ish.c | 54 ++++++++++++++++++++++++-
 3 files changed, 81 insertions(+), 1 deletion(-)

Comments

Jiri Kosina Jan. 4, 2021, 3:12 p.m. UTC | #1
On Wed, 16 Dec 2020, Zhang Lixu wrote:

> The EHL (Elkhart Lake) based platforms provide a OOB (Out of band)

> service, which allows wakup device when the system is in S5 (Soft-Off

> state). This OOB service can be enabled/disabled from BIOS settings.

> 

> These two patches is to enable this feature for EHL platform.

> 

> We have tested these patches on both ISH platforms and EHL platforms,

> it works fine.

> 

> Zhang Lixu (2):

>   hid: intel-ish-hid: ipc: finish power flow for EHL OOB

>   hid: intel-ish-hid: ipc: Address EHL Sx resume issues

> 

>  drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  1 +

>  drivers/hid/intel-ish-hid/ipc/ipc.c     | 27 +++++++++++++

>  drivers/hid/intel-ish-hid/ipc/pci-ish.c | 54 ++++++++++++++++++++++++-

>  3 files changed, 81 insertions(+), 1 deletion(-)


Srinivas, can I please get your Acked-by / Reviewed-by for this? Thanks,

-- 
Jiri Kosina
SUSE Labs
srinivas pandruvada Jan. 4, 2021, 4:01 p.m. UTC | #2
On Mon, 2021-01-04 at 16:12 +0100, Jiri Kosina wrote:
> On Wed, 16 Dec 2020, Zhang Lixu wrote:

> 

> > The EHL (Elkhart Lake) based platforms provide a OOB (Out of band)

> > service, which allows wakup device when the system is in S5 (Soft-

> > Off

> > state). This OOB service can be enabled/disabled from BIOS

> > settings.

> > 

> > These two patches is to enable this feature for EHL platform.

> > 

> > We have tested these patches on both ISH platforms and EHL

> > platforms,

> > it works fine.

> > 

> > Zhang Lixu (2):

> >   hid: intel-ish-hid: ipc: finish power flow for EHL OOB

> >   hid: intel-ish-hid: ipc: Address EHL Sx resume issues

> > 

> >  drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  1 +

> >  drivers/hid/intel-ish-hid/ipc/ipc.c     | 27 +++++++++++++

> >  drivers/hid/intel-ish-hid/ipc/pci-ish.c | 54

> > ++++++++++++++++++++++++-

> >  3 files changed, 81 insertions(+), 1 deletion(-)

> 

> Srinivas, can I please get your Acked-by / Reviewed-by for this?

Acked on individual patches.

Thanks,
Srinivas


> Thanks,

>
Zhang, Lixu Jan. 5, 2021, 2:42 a.m. UTC | #3
On Mon, Jan 04, 2021 at 08:01:36AM -0800, Srinivas Pandruvada wrote:
> On Mon, 2021-01-04 at 16:12 +0100, Jiri Kosina wrote:

> > On Wed, 16 Dec 2020, Zhang Lixu wrote:

> > 

> > > The EHL (Elkhart Lake) based platforms provide a OOB (Out of band)

> > > service, which allows wakup device when the system is in S5 (Soft-

> > > Off

> > > state). This OOB service can be enabled/disabled from BIOS

> > > settings.

> > > 

> > > These two patches is to enable this feature for EHL platform.

> > > 

> > > We have tested these patches on both ISH platforms and EHL

> > > platforms,

> > > it works fine.

> > > 

> > > Zhang Lixu (2):

> > >   hid: intel-ish-hid: ipc: finish power flow for EHL OOB

> > >   hid: intel-ish-hid: ipc: Address EHL Sx resume issues

> > > 

> > >  drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  1 +

> > >  drivers/hid/intel-ish-hid/ipc/ipc.c     | 27 +++++++++++++

> > >  drivers/hid/intel-ish-hid/ipc/pci-ish.c | 54

> > > ++++++++++++++++++++++++-

> > >  3 files changed, 81 insertions(+), 1 deletion(-)

> > 

> > Srinivas, can I please get your Acked-by / Reviewed-by for this?

> Acked on individual patches.

> 

> Thanks,

> Srinivas

> 

> 

> > Thanks,

> > 

> 

> 


Thanks.
Jiri Kosina Jan. 6, 2021, 4:20 p.m. UTC | #4
On Wed, 16 Dec 2020, Zhang Lixu wrote:

> The EHL (Elkhart Lake) based platforms provide a OOB (Out of band)

> service, which allows wakup device when the system is in S5 (Soft-Off

> state). This OOB service can be enabled/disabled from BIOS settings.

> 

> These two patches is to enable this feature for EHL platform.

> 

> We have tested these patches on both ISH platforms and EHL platforms,

> it works fine.

> 

> Zhang Lixu (2):

>   hid: intel-ish-hid: ipc: finish power flow for EHL OOB

>   hid: intel-ish-hid: ipc: Address EHL Sx resume issues

> 

>  drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  1 +

>  drivers/hid/intel-ish-hid/ipc/ipc.c     | 27 +++++++++++++

>  drivers/hid/intel-ish-hid/ipc/pci-ish.c | 54 ++++++++++++++++++++++++-

>  3 files changed, 81 insertions(+), 1 deletion(-)


Applied to hid.git#for-5.12/intel-ish.

-- 
Jiri Kosina
SUSE Labs