From patchwork Mon May 29 06:23:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 686781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6CDCC7EE2F for ; Mon, 29 May 2023 06:24:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231468AbjE2GYG (ORCPT ); Mon, 29 May 2023 02:24:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231455AbjE2GYF (ORCPT ); Mon, 29 May 2023 02:24:05 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E40ADAF; Sun, 28 May 2023 23:23:29 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2af1c884b08so36191041fa.1; Sun, 28 May 2023 23:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685341408; x=1687933408; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qAYjfYPDkeseUEX3Qju/rMoDAuLOVXMDR9FoKi3lXW8=; b=LdGoCbTSxryOs8Qo3Ri/QyjATODUIwbB9X0bApaeks2mrJVyUWgpAbsz4csJjgqLVy r4MJ9L74W/bkS4zpCN14qkNvZDnhjUQHBzEUuPOj43+ZPbyHQ+YwU5VelRkeEwrRhgfV XAzUHoKVuRdP6rJ7MGfBNA8vLN7lvDl2ff4KWd7T6eIMMrFkeO4bV5rfr9XxWq+GzDZd R+0L28kyPVXPITJZUEXwl+2u+m9hKMH1Hs05+ubkfEv31dQ9YvN9EiOrQ309jxzSoYFm OEuGO7CgfEXSN5G30leLZMDnoXFoLcTnfj+hvBcLvVAujxOYK/2Yg6RJD30zSl+1sQyp 1jLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685341408; x=1687933408; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qAYjfYPDkeseUEX3Qju/rMoDAuLOVXMDR9FoKi3lXW8=; b=ZS3m84CicR9JqCn/1vdS5A/ngTe0qE6Be8gcxTKfJTqzVXPe5ZgroV0oeNamVgvMZb vWjBYaVkqcw1VwChq7jur0VUEsVEqA8/OAWanBs6NMQqMKs1sk/0yqtF9dSrVVQrabrb VDKkqKdX4LTy/873wLAZh4vxdET+I0GC8oDlAOmn8I8p3FktMXFyX3aCo8gQq8QtJ47r 7F8rtWq/Ky+VBNb/3jUGdUYafA16sbz4Q0OkKgK1Zr5XhYRiRvdt9W1ZaSxUJIY5ey3+ Y1pqlzYJq+nK+HWeBNNNYkYnmeO4ez5l9U3nmtpHrJB7rDPx6vcBBNstzU/Dtbu9VNG0 57CA== X-Gm-Message-State: AC+VfDyEYHsER5H2Z993HATrJGTapiTWiQ+Xe2TehTZvFQDIOmJbc9b+ BDvzq9znoRj2iccPovMR5e0= X-Google-Smtp-Source: ACHHUZ6Wzd8EORP/soOSqvLc1RQARXsD4vdEjqHtxoqGB6E7ai03uoQZNFPpavZeUpcBp1H64LhQUQ== X-Received: by 2002:a05:651c:2044:b0:2af:222d:9695 with SMTP id t4-20020a05651c204400b002af222d9695mr2224914ljo.9.1685341407947; Sun, 28 May 2023 23:23:27 -0700 (PDT) Received: from fedora (62-78-225-252.bb.dnainternet.fi. [62.78.225.252]) by smtp.gmail.com with ESMTPSA id u3-20020a2e9b03000000b002aeee2a093csm2306817lji.59.2023.05.28.23.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 May 2023 23:23:27 -0700 (PDT) Date: Mon, 29 May 2023 09:23:23 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v7 4/9] pinctrl: wpcm450: relax return value check for IRQ get Message-ID: <659ca38e756b724b4192ff2923e8fdf6970dcb8a.1685340157.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org fwnode_irq_get[_byname]() were changed to not return 0 anymore. The special error case where device-tree based IRQ mapping fails can't no longer be reliably detected from this return value. This yields a functional change in the driver where the mapping failure is treated as an error. The mapping failure can occur for example when the device-tree IRQ information translation call-back(s) (xlate) fail, IRQ domain is not found, IRQ type conflicts, etc. In most cases this indicates an error in the device-tree and special handling is not really required. One more thing to note is that ACPI APIs do not return zero for any failures so this special handling did only apply on device-tree based systems. Drop the special (no error, just skip the IRQ) handling for DT mapping failures as these can no longer be separated from other errors at driver side. Signed-off-by: Matti Vaittinen Reviewed-by: Jonathan Neuschäfer Acked-by: Linus Walleij Reviewed-by: Jonathan Cameron --- Revision history: v5 => : - No changes v4 => v5: Fix typo in subject "elax" => "relax" Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok. The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone. --- drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c index 2d1c1652cfd9..f9326210b5eb 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c @@ -1106,8 +1106,6 @@ static int wpcm450_gpio_register(struct platform_device *pdev, irq = fwnode_irq_get(child, i); if (irq < 0) break; - if (!irq) - continue; girq->parents[i] = irq; girq->num_parents++;