From patchwork Mon Sep 16 12:15:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 829084 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E1CD149C57 for ; Mon, 16 Sep 2024 12:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726488931; cv=none; b=OvF5LyYg6teEmwoWWdL8OKlONLUBtP0tTvjO1JXkFgeJy2yriR3QNUqY7qOIl/a9nyiHi1kB/h6lUhpMKIkxc+J12CY+5YqH3BbvcQ+W6G8FBvE1mPhPPOrL0q53j/zSHc1lhjGllWBEtYoxfog+67isxOwuz/eA4/+Jjy5R5Fo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726488931; c=relaxed/simple; bh=x/eSy/WZngJyR2Y1V+cS6ZDXgK4xdbIYX/lcxdZ5Lfw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qjpuuhG6GL5kloIP3/Nq3Y9RIWwca3STuB3WFLvBFc6s9YfsdLr7tosGXHa2EhgC8zA3HpptDxbcTmpBnlPuMTFiON/KAtk6eQAMjh78LfnHwjKC57TxS6pWubxQkiqDHCpCJ66ibUmRHM6C6KiyKmbxo0wMlUpfMd3JcNs/oGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=Pr/nOfRC; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="Pr/nOfRC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=k1; bh=3WW7oYrAHHYvUV DPvSSbuhZgtgCR0ALACH7FRX5ibzE=; b=Pr/nOfRCwkZOWp6tZyV+ZnYgx7b6XD /KXiIBBfZPA5WuaJhR4Y/de6382qGKturGnCM8B9I/6tdMWk9HuStk7WKyv6lyNr ghZ7oVnXhPcfjxf+2gxwt4xr35PXLvq6arpIpSv5+NTRdhIUbcV28EU84KyIxUTb n1gR9ndFIAWyEGWmbMn2WqDDVHo2ZgaPWjkywfPnJeOoEjcdcGsdlZ1O8Kx30L9u 6TIK2KFNsWg+Vl014E/x/EEYG7354kr0Uw3TMTY/rePngK5nBbBIMltZC8raR5wr wBYC2xlsXhHHqfAsgvCAjD9tOrqdgIfSUi0zrvNo0e3QJvHNegKIzIeA== Received: (qmail 1991357 invoked from network); 16 Sep 2024 14:15:24 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 16 Sep 2024 14:15:24 +0200 X-UD-Smtp-Session: l3s3148p1@GVoJhzsizsq5aIoy From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Vladimir Zapolskiy , Jinjie Ruan , Mukesh Kumar Savaliya , linux-arm-msm@vger.kernel.org Subject: [PATCH] i2c: qcom-geni: Keep comment why interrupts start disabled Date: Mon, 16 Sep 2024 14:15:17 +0200 Message-ID: <20240916121516.3102-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The to-be-fixed commit rightfully reduced a race window, but also removed a comment which is still helpful after the fix. Bring the comment back. Fixes: e2c85d85a05f ("i2c: qcom-geni: Use IRQF_NO_AUTOEN flag in request_irq()") Signed-off-by: Wolfram Sang Reviewed-by: Bjorn Andersson --- drivers/i2c/busses/i2c-qcom-geni.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 4c9050a4d58e..03c05dcc2202 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -818,6 +818,8 @@ static int geni_i2c_probe(struct platform_device *pdev) init_completion(&gi2c->done); spin_lock_init(&gi2c->lock); platform_set_drvdata(pdev, gi2c); + + /* Disable the interrupt so that the system can enter low-power mode */ ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN, dev_name(dev), gi2c); if (ret) {