From patchwork Mon Aug 19 18:45:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 820434 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1679A18A6C9; Mon, 19 Aug 2024 18:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724093170; cv=none; b=jOhPkvyXaXtjEAYbAxGDStMf/Yp/q0Wpmh/j5aT+S10PENpx0LZsNI5eCLoYiByibJO66ddjWjeJTkUrU3AxvApyPzcgCDr6w4GO2T0atP69JC/BnVsLRnMuQLy6fBlt//XY815pnbuhbwNSTd/psS750RhWzAGpmhYx9IuNh20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724093170; c=relaxed/simple; bh=KoT/31pGAd0xE2KmlmoMP1RqpQ6AxIOuaCMFure4zbE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eSqxGgUAO8HowdG1cuj0MHiXTmHo/Av5zwAPjCJHqWhqffEDHMqwiBklFp/aBKAoVu4/s3pDQpFgNBwIFYlgzNMZIT4gX1ktXmFuRgXljb5KmFlwHlP5JENg8Xl3qQfvb4sfGwMVHwMayKsZwNraW79Y1ZjcG7oOQ0hgWuU/4EI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=daD9xcLa; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="daD9xcLa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724093169; x=1755629169; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KoT/31pGAd0xE2KmlmoMP1RqpQ6AxIOuaCMFure4zbE=; b=daD9xcLaSjrSckrw8CN3hWQIDmE1MgawRWZLHjJxaa9+TkeUN1QvfGb8 yRSbXqc02ETg4dxtsiKHR3w77VUWHqrBI07hpykmKS5cXtgTERV8BpSlK boocK7NGuq8UZAlChJ9GGyuXSdv4FqiSn+e0comklgSwB+le+OvOtule2 dtrT0CepgVxaPGJ4QtZq8vP4oANpJqovctujUZCcJSjKc/2hGidke+zWV auFwfsr6MFc3JCzgUgrrj7ghwD+VN6I1B/+91DKP1TNItJL/k/yW3/aYU HkQtfZqs20gND0AV7/GPVqO6ui77+9Js5Fhl+YLYUhwcglKiHE1S+OzuW w==; X-CSE-ConnectionGUID: yuVtukRGRqCXaOsFPwWUWg== X-CSE-MsgGUID: MU7rAcgkRSmOZ15UMBQLXQ== X-IronPort-AV: E=McAfee;i="6700,10204,11169"; a="22537666" X-IronPort-AV: E=Sophos;i="6.10,159,1719903600"; d="scan'208";a="22537666" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 11:46:09 -0700 X-CSE-ConnectionGUID: 9ZkS7+3zQjmmQUgRscmMlw== X-CSE-MsgGUID: RXpicG8OQcGdTldZJ+RE7Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,159,1719903600"; d="scan'208";a="60433959" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa009.jf.intel.com with ESMTP; 19 Aug 2024 11:46:06 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6485A751; Mon, 19 Aug 2024 21:46:01 +0300 (EEST) From: Andy Shevchenko To: Andi Shyti , Andy Shevchenko , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jarkko Nikula , Mika Westerberg , Jan Dabros , Narasimhan.V@amd.com, Borislav Petkov , Kim Phillips Subject: [PATCH v3 6/7] i2c: designware: Drop return value from i2c_dw_acpi_configure() Date: Mon, 19 Aug 2024 21:45:12 +0300 Message-ID: <20240819184600.2256658-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240819184600.2256658-1-andriy.shevchenko@linux.intel.com> References: <20240819184600.2256658-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 i2c_dw_acpi_configure() is called without checking of the returned value, hence just drop it by converting to void. Reviewed-by: Andi Shyti Acked-by: Jarkko Nikula Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-common.c | 4 +--- drivers/i2c/busses/i2c-designware-core.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 4160c5e57df4..f0d7cad92f1c 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -255,7 +255,7 @@ static void i2c_dw_acpi_params(struct device *device, char method[], kfree(buf.pointer); } -int i2c_dw_acpi_configure(struct device *device) +void i2c_dw_acpi_configure(struct device *device) { struct dw_i2c_dev *dev = dev_get_drvdata(device); struct i2c_timings *t = &dev->timings; @@ -285,8 +285,6 @@ int i2c_dw_acpi_configure(struct device *device) dev->sda_hold_time = fs_ht; break; } - - return 0; } EXPORT_SYMBOL_GPL(i2c_dw_acpi_configure); diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index 3e48f446ce53..ebcf816b731c 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -420,7 +420,7 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev); void i2c_dw_adjust_bus_speed(struct dw_i2c_dev *dev); #if IS_ENABLED(CONFIG_ACPI) -int i2c_dw_acpi_configure(struct device *device); +void i2c_dw_acpi_configure(struct device *device); #else -static inline int i2c_dw_acpi_configure(struct device *device) { return -ENODEV; } +static inline void i2c_dw_acpi_configure(struct device *device) { } #endif