From patchwork Fri Aug 16 17:02:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 819831 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C48A1C3F1D; Fri, 16 Aug 2024 17:12:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723828364; cv=none; b=pWy5imAARTOiMWbCBEbWtpKTm3PHvNjuT8INR61V8ceByfR2/DVjgRskZrNe5WagnbPgItYsosh5lIh7uz72YKjboEPy2eOufQsQOLS2zf04IcxsN2wm2cJB+XdG8fgQoFCjrAfqtt9n0Yr7OffEj+HzSCNqGB7JaIh3aiOnCn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723828364; c=relaxed/simple; bh=KoT/31pGAd0xE2KmlmoMP1RqpQ6AxIOuaCMFure4zbE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fz0p6EZnha/PLWZ6sNDunTnIz+Mz1+PNAmGbJKi14plqHWr/wh1ewA9V0z/DGx8iATw0vBpo36vHgBMtNHhWxOnHSf9HPGoxBsqPT88CCdEybZ9iE2Zo0B5LqumakpwfR2PNgF5XGJeFFlfz7ndAhpeezF8f4xUJtexBpk/juuw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SLZ9PFnO; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SLZ9PFnO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723828363; x=1755364363; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KoT/31pGAd0xE2KmlmoMP1RqpQ6AxIOuaCMFure4zbE=; b=SLZ9PFnOHTlbx+z5NZ8+bfoQfrOEcdiIIKaTOi0OHaU8yWQMyPd+7hm+ Yv5q/cHk02gKfNvnYLmuINbJixOdcwMGanSE/tYsXW3PwZF/wca/7jA0q h3BB5aokaBlHlpiZR5d/cZ7aCiFA12N4nnY8Sbh9iz+yaDZ76sek3KYSs oOGwdbOEDCmr1YU1bHkC023A3fwXjVM8CuMgTH7EuddeLlnJyvPdmnCz/ IjKMUn5XpQSVhkH1xKGAsHiigJHBG73lsJCgYR5wiWPQO6l5hWGqmTiWY 3G2UNj2wwPwaulcfQMJk/Z0DI2pSfdA0ihPxuZJM/rasDgmi5tYUhbrCT g==; X-CSE-ConnectionGUID: jq9DREQdSmOvhjbmcGPz0g== X-CSE-MsgGUID: q2qeyS5KT7uTElGvDI3gkw== X-IronPort-AV: E=McAfee;i="6700,10204,11166"; a="39644614" X-IronPort-AV: E=Sophos;i="6.10,152,1719903600"; d="scan'208";a="39644614" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2024 10:12:39 -0700 X-CSE-ConnectionGUID: Op6rMOtVR9uB+x3Lzx8n2g== X-CSE-MsgGUID: 7y+7OoLYSoG/N3uloeN1Ug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,152,1719903600"; d="scan'208";a="64394903" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa004.fm.intel.com with ESMTP; 16 Aug 2024 10:12:37 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B899B39D; Fri, 16 Aug 2024 20:12:32 +0300 (EEST) From: Andy Shevchenko To: Andi Shyti , Andy Shevchenko , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jarkko Nikula , Mika Westerberg , Jan Dabros , Narasimhan.V@amd.com, Borislav Petkov , Kim Phillips Subject: [PATCH v1 6/7] i2c: designware: Drop return value from i2c_dw_acpi_configure() Date: Fri, 16 Aug 2024 20:02:04 +0300 Message-ID: <20240816171225.3506844-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240816171225.3506844-1-andriy.shevchenko@linux.intel.com> References: <20240816171225.3506844-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 i2c_dw_acpi_configure() is called without checking of the returned value, hence just drop it by converting to void. Reviewed-by: Andi Shyti Acked-by: Jarkko Nikula Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-common.c | 4 +--- drivers/i2c/busses/i2c-designware-core.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 4160c5e57df4..f0d7cad92f1c 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -255,7 +255,7 @@ static void i2c_dw_acpi_params(struct device *device, char method[], kfree(buf.pointer); } -int i2c_dw_acpi_configure(struct device *device) +void i2c_dw_acpi_configure(struct device *device) { struct dw_i2c_dev *dev = dev_get_drvdata(device); struct i2c_timings *t = &dev->timings; @@ -285,8 +285,6 @@ int i2c_dw_acpi_configure(struct device *device) dev->sda_hold_time = fs_ht; break; } - - return 0; } EXPORT_SYMBOL_GPL(i2c_dw_acpi_configure); diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index 3e48f446ce53..ebcf816b731c 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -420,7 +420,7 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev); void i2c_dw_adjust_bus_speed(struct dw_i2c_dev *dev); #if IS_ENABLED(CONFIG_ACPI) -int i2c_dw_acpi_configure(struct device *device); +void i2c_dw_acpi_configure(struct device *device); #else -static inline int i2c_dw_acpi_configure(struct device *device) { return -ENODEV; } +static inline void i2c_dw_acpi_configure(struct device *device) { } #endif