From patchwork Thu Jul 11 12:08:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 812695 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B931715B0F9 for ; Thu, 11 Jul 2024 12:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720699716; cv=none; b=GBPWEJc6fm1Gx738M/sVDWjn3gM7lwXatkaMT3x1q7HALKTOagwYFJxQ8jj05oW09klR0NCEl2FCPW94Ur0hR6ZcmcDBqs5Ny5np4DEwNTHyqqxi+miIe/XplV5R+9VnEA9XQbQPjuB3NDfF35QT33qdRICTa3uWCMY7n+rVx1s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720699716; c=relaxed/simple; bh=Esq9EMKJr//KVXY3Wy6aclmtW8kRS5RmnOqmM+v1FPM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jCjHJnQKX/bFMkCVsoqNKsAZWrb5AMjE9DbGq15t3SPOGEB4cpC4x1tReCV+jjXWqLfieVl0psqjUJRLaZYpbdIGs4ugpRqbmsS+nOG6Nq9/j6b2ov8Ul6Je+FY6y9ucsBM2XtrXiokPIFdrp/LaiQz5r8QIvDIqE6me0JjsRuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=lO1tvjIc; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="lO1tvjIc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=k1; bh=lKGOUQFqKioITe ghw3RVtO5M91yc2jLfkEIsxyv+arY=; b=lO1tvjIci896byHtFUPTYQvzgpTOsa sCJ5WexlsUMN/nOk6BvtTVEH2T3A4x9xq2H9uf2N3xlub+ZcbdRh6vnS0dUd8TU5 aCmKsmEOl/jvasLjVyDIQu7b7pYBIJlstaVhz0k04/k9I7aiDw6E3lKcCkL6mqcq 1WX7dkGWvjGerwF6+MUaFKWNNO6wVytzzo1A8ajAPJf/sQHEAltS9Q7scfjaL0T6 v7gglmrZ19534WsX8ye4EnqtXiU8Fr6X/GUdGkcXyxmqounK3ndF/sb5KuvHrMmR gBJ2HdU1tspNm/J/74Dnpq5VOWD6N0+BGgUcr23brK84UfC9RCwQSVDA== Received: (qmail 837138 invoked from network); 11 Jul 2024 14:08:22 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 11 Jul 2024 14:08:22 +0200 X-UD-Smtp-Session: l3s3148p1@rTeHnvccMJkgAwDPXwmZAIsFIv4n+Dpm From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] i2c: testunit: avoid re-issued work after read message Date: Thu, 11 Jul 2024 14:08:19 +0200 Message-ID: <20240711120818.46543-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The to-be-fixed commit rightfully prevented that the registers will be cleared. However, the index must be cleared. Otherwise a read message will re-issue the last work. Fix it and add a comment describing the situation. Fixes: c422b6a63024 ("i2c: testunit: don't erase registers after STOP") Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-slave-testunit.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/i2c/i2c-slave-testunit.c b/drivers/i2c/i2c-slave-testunit.c index ca43e98cae1b..23a11e4e9256 100644 --- a/drivers/i2c/i2c-slave-testunit.c +++ b/drivers/i2c/i2c-slave-testunit.c @@ -118,6 +118,13 @@ static int i2c_slave_testunit_slave_cb(struct i2c_client *client, queue_delayed_work(system_long_wq, &tu->worker, msecs_to_jiffies(10 * tu->regs[TU_REG_DELAY])); } + + /* + * Reset reg_idx to avoid that work gets queued again in case of + * STOP after a following read message. But do not clear TU regs + * here because we still need them in the workqueue! + */ + tu->reg_idx = 0; break; case I2C_SLAVE_WRITE_REQUESTED: